Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1152906pxf; Fri, 12 Mar 2021 03:17:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJw+vDfOGSBWJI8na3XZAQun6OMrEJJsBZ7+cWPf9PsJocykUKB+3KcYG/lCvA+v9fU/u/o2 X-Received: by 2002:a17:906:6095:: with SMTP id t21mr7935872ejj.384.1615547825468; Fri, 12 Mar 2021 03:17:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615547825; cv=none; d=google.com; s=arc-20160816; b=zuMoWchCjModte4loGted0KrZ7InCkZKk6/BF4YOdNXbAr0GHJFC0Wx+cFCZ/Jntqr ZCBzjLVP8I2746RAAhI/OVQnfQzdXgQfVyn/s2wc5T95kr4PEPq/Muc8NM+GvsFXn6RS EdJh7Y/7hFDLutgbR/Kr9YFzNExHwNTJwWp5843siKHxKMaAA6nXT4AR97HnFIPbByLS yIj9x2qlhvfvRdi6+bL9kd9XdMoTdsM0rrfx7zHwlbmQyhhILcdR6ugIMffLus1Wv9Oz GdH55YFPnic2mw2V6kVTZgGIBpFnH/NW9jMjUrc1sOgFpIcrjW5Uk0kYBoNUPLgSsNy/ doyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hXSshFQeFLOgp+frZhl0j2pqci63p2uc+L6BvWuJgGc=; b=bdX81EZplw2NSKrxx3QUUU46TSpm++16tRv4WAD4dJSLHkkJt0TNw4YEHXMHRfWMbs dOW5PTlEM2fuz+3ntU4kmLZNlyAxwydxXZIWAjQ5rQXX8DpBsYKCEo8si/8u8s2xOz8I vHoLp6IzQBdJFkBmRbEJi0kpVsuLj//2NGwjVZJj2bUEMJ+vbhxJ7qSJ4z4zSGc5aebF FloRKcml9xqCweGkuYX90WquMwNecf7OmaKgZSmSx0Uus72CMNyoR2A6hnGAA6aA7hSZ v+BFy+eXvAQBXVMAVtSrC6ODThcPtJmSNCv5AR8KR/i6OKUtYTq/tTWW2otMfo8CpC/3 +7ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EjGbAqUT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si3860360ejb.59.2021.03.12.03.16.42; Fri, 12 Mar 2021 03:17:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EjGbAqUT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233690AbhCLLPq (ORCPT + 99 others); Fri, 12 Mar 2021 06:15:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35705 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233633AbhCLLPf (ORCPT ); Fri, 12 Mar 2021 06:15:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615547734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hXSshFQeFLOgp+frZhl0j2pqci63p2uc+L6BvWuJgGc=; b=EjGbAqUT+7yqt/nCQDCIPnn+Uc1miZfOf/PcoEQqseLVgLLEbxYGfmBXycrCFJIbPQiIhx BZhnIVfkQK+wYlWMcKsZX27GRZSe2r2ebRjET5uzIVtudDOPj0aYwkwXbrBKukug90oFeS ZdraPcWllzNyHgP9GqFnm3LUV6Dk6q8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-QvrsFBn2OPm5U9RfuB7OUg-1; Fri, 12 Mar 2021 06:15:30 -0500 X-MC-Unique: QvrsFBn2OPm5U9RfuB7OUg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 27152100C691; Fri, 12 Mar 2021 11:15:28 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.40.192.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 991C17A8CA; Fri, 12 Mar 2021 11:14:59 +0000 (UTC) Date: Fri, 12 Mar 2021 12:14:56 +0100 From: Andrew Jones To: Yanan Wang Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Ben Gardon , Sean Christopherson , Vitaly Kuznetsov , Peter Xu , Marc Zyngier , Ingo Molnar , Adrian Hunter , Jiri Olsa , Arnaldo Carvalho de Melo , Arnd Bergmann , Michael Kerrisk , Thomas Gleixner , wanghaibin.wang@huawei.com, yezengruan@huawei.com, yuzenghui@huawei.com Subject: Re: [RFC PATCH v4 2/9] tools headers: Add a macro to get HUGETLB page sizes for mmap Message-ID: <20210312111456.ukxss6uxu3frqmiu@kamzik.brq.redhat.com> References: <20210302125751.19080-1-wangyanan55@huawei.com> <20210302125751.19080-3-wangyanan55@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210302125751.19080-3-wangyanan55@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 02, 2021 at 08:57:44PM +0800, Yanan Wang wrote: > We know that if a system supports multiple hugetlb page sizes, > the desired hugetlb page size can be specified in bits [26:31] > of the flag arguments. The value in these 6 bits will be the > shift of each hugetlb page size. > > So add a macro to get the page size shift and then calculate the > corresponding hugetlb page size, using flag x. > > Cc: Ben Gardon > Cc: Ingo Molnar > Cc: Adrian Hunter > Cc: Jiri Olsa > Cc: Arnaldo Carvalho de Melo > Cc: Arnd Bergmann > Cc: Michael Kerrisk > Cc: Thomas Gleixner > Suggested-by: Ben Gardon > Signed-off-by: Yanan Wang > Reviewed-by: Ben Gardon > --- > include/uapi/linux/mman.h | 2 ++ > tools/include/uapi/linux/mman.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/include/uapi/linux/mman.h b/include/uapi/linux/mman.h > index f55bc680b5b0..8bd41128a0ee 100644 > --- a/include/uapi/linux/mman.h > +++ b/include/uapi/linux/mman.h > @@ -41,4 +41,6 @@ > #define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB > #define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB > > +#define MAP_HUGE_PAGE_SIZE(x) (1 << ((x >> MAP_HUGE_SHIFT) & MAP_HUGE_MASK)) Needs to be '1ULL' to avoid shift overflow when given MAP_HUGE_16GB. Thanks, drew > + > #endif /* _UAPI_LINUX_MMAN_H */ > diff --git a/tools/include/uapi/linux/mman.h b/tools/include/uapi/linux/mman.h > index f55bc680b5b0..8bd41128a0ee 100644 > --- a/tools/include/uapi/linux/mman.h > +++ b/tools/include/uapi/linux/mman.h > @@ -41,4 +41,6 @@ > #define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB > #define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB > > +#define MAP_HUGE_PAGE_SIZE(x) (1 << ((x >> MAP_HUGE_SHIFT) & MAP_HUGE_MASK)) > + > #endif /* _UAPI_LINUX_MMAN_H */ > -- > 2.23.0 >