Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1185154pxf; Fri, 12 Mar 2021 04:07:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJybS8EWl7F8Mf3dnTvpdxlygxwRyfn/ewMuKB/4+OwXjLIfngosEdTWdSnZDcIZ5rCEjKfQ X-Received: by 2002:aa7:da0f:: with SMTP id r15mr13614652eds.111.1615550866617; Fri, 12 Mar 2021 04:07:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615550866; cv=none; d=google.com; s=arc-20160816; b=giwsixKPJfUfFf5MA7ivLoXejDsAP8OLp2h6tYP4KGf/m2nN65hpBlBtPvWkhuwRqD 9hMHjM+789RFf5SPuJMNXIKFwHBqczL8BaDD8AgRDh+CKN7g/XWDTTP0951jPm7bSldY 6y1NGFWHmD1b/qWKbaw08JMcfcFk5Gg/9feWzN96bZq1IP+mXi1VSxReP1UIh6D7vNyS QE+8ayEwV2K9VFqt5+n5TIwb1CZD9GvijKiYgfUjERt0gsCZfFc/Gg0dNaMvkwOVf0q6 hxav5yM2Xe3/rlkvGrTSX9JexWThYZqb0i3qDWc4CG3y34n8d5uZ0rDQis3jC7te3Hcm 9spA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=p07pYjywy0KeJoA82JxD6kvBwCo3hQ4RFzlwhjt5scw=; b=0+DfhUSEjmVPfOX5k27c5eDl60eDD0CT9giu2gStdIPjgTgZ0PSR6Mhw031Li+FjJC aWuW0BF5yEkLcXAWayvno2baaT4o2m8l3Fe3L/9nTeDEpAtbwYHz4nGnn7nsqr+JUMwA 4JjYZRukfKWmrUnCgCMRpu2gb+EqiaJ7VG3NKutbSmKHNd39li+Go6ktD1Su/kCyAliF eSOiuy7xQrlGV9J7S0zUCuDOxCKgAT+pOnzT2J9yx6xHOoZEki8rJU4OTU7AAfs2ZiEk A2J8b8ua48BxeXTJcb2BdX5In4DIbRirI1SKrBXSHYdH0+ZLBN9Ofxg+7YNcGoZuYqS9 XHNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZMnlJOK4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg25si3522699ejc.50.2021.03.12.04.07.17; Fri, 12 Mar 2021 04:07:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZMnlJOK4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229505AbhCLMGL (ORCPT + 99 others); Fri, 12 Mar 2021 07:06:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:55206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbhCLMGK (ORCPT ); Fri, 12 Mar 2021 07:06:10 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 470F764FD6; Fri, 12 Mar 2021 12:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615550769; bh=DHmyk8GUReblYUlhSMgM0JiPJvuHbVNLZgcQ4Uqew+8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZMnlJOK4+abTr5z6UYLOMd63xUlgezqJXvqxpjbY9ta+qtcZwgxxfDbPmXKjn9G/x fJH3pXeWHvA3lHlndJknsq+TlkHWBGctbcZ81JOI6QsX3ZMv0nto7+QDcim7ArHJOj 9I2mVhq9wW7bbwMSGLddZUQCee/FnVMFe3vTv7qt+FXXGGY2F6rtrcv+V9DZqtm7t+ WU6H07eYP7vHhX0lFQfBr6wobUMro6CUc76cwUfvvD82C5sTLKLO/AJOmNRIeBK1fe 6c/mh7emCx1217+ygNXUp4FTLCvL4uNCNfu0hgYTLvLGOVAiG7NWTlatoHNVIMKJGt DeotHYNFPoIhQ== Date: Fri, 12 Mar 2021 12:04:56 +0000 From: Mark Brown To: Michael Walle Cc: Sameer Pujar , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, jonathanh@nvidia.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, robh@kernel.org, sharadg@nvidia.com, thierry.reding@gmail.com Subject: Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock Message-ID: <20210312120456.GD5348@sirena.org.uk> References: <1612939421-19900-2-git-send-email-spujar@nvidia.com> <20210309144156.18887-1-michael@walle.cc> <611ed3362dee3b3b7c7a80edfe763fd0@walle.cc> <20210311161558.GG4962@sirena.org.uk> <20210312113544.GB5348@sirena.org.uk> <6ed28bb5330879b1919aced5174f319f@walle.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2Z2K0IlrPCVsbNpk" Content-Disposition: inline In-Reply-To: <6ed28bb5330879b1919aced5174f319f@walle.cc> X-Cookie: Lake Erie died for your sins. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2Z2K0IlrPCVsbNpk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 12, 2021 at 01:01:41PM +0100, Michael Walle wrote: > Am 2021-03-12 12:35, schrieb Mark Brown: > > If the card has a clock API clock as sysclk then set_sysclk(() should > > be configuring that clock. > What do you mean by "the card". The simple-audio-card itself? > Take a look at: > https://elixir.bootlin.com/linux/v5.12-rc2/source/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts#L29 > Does the card has a clock? IMHO the WM8904 codec has a clock, but not > the audio card. The clock on the CODEC, which the card configures. The CODEC should be passing on the configuration to the clock API. --2Z2K0IlrPCVsbNpk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBLWOcACgkQJNaLcl1U h9Dr4wf/RvhCgjsXMqQfCMBjIX58G+v9Cg2OPPplcaKKCYDjRg91mNXrL3E80qFQ HOfZJ33uxBY2xnzXmfnttbMlnRrQys2U0XPqbQXNnJTnHmJu4XqVU/j+c8QJeKJK DCYp/qmAvUqm3i4KDM/bbqIeNCiXHtVZ6FvLdrEL8smdJhXdMGFA24rOvNMlhCyw T2/y0+K/70cbhiWTrVFs4LyRnGdlIooLdErAfQ0ZoXnsid0QNObGiS0eOSjssjke gfwoUWcR5skL2eEzLBkWAOnJM1Am5S56kSpMaF/69BfwwINbfV7GpCZFOHbI+Zy1 0ZPH0ScPMHaRdPcpq9ArImBAxwU+Fw== =mvjs -----END PGP SIGNATURE----- --2Z2K0IlrPCVsbNpk--