Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Authentication-Results-Original: huawei.com; dkim=none (message not signed)
 header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;
Subject: Re: [PATCH RFC v1 04/15] iommu/arm-smmu-v3: Update CD base address
 info for user-space
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        iommu@lists.linux-foundation.org,
        virtualization@lists.linux-foundation.org, joro@8bytes.org,
        will.deacon@arm.com, mst@redhat.com, robin.murphy@arm.com,
        eric.auger@redhat.com, alex.williamson@redhat.com,
        kevin.tian@intel.com, jacob.jun.pan@linux.intel.com,
        yi.l.liu@intel.com, lorenzo.pieralisi@arm.com,
        shameerali.kolothum.thodi@huawei.com
References: <20210115121342.15093-1-vivek.gautam@arm.com>
 <20210115121342.15093-5-vivek.gautam@arm.com> <YD/D9HJxH9L503an@myrica>
From:   Vivek Kumar Gautam <vivek.gautam@arm.com>
Message-ID: <51280327-e1a1-f3fc-a2dd-2d3bd740aa9f@arm.com>
Date:   Fri, 12 Mar 2021 18:01:28 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YD/D9HJxH9L503an@myrica>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.162.16.71] (217.140.105.56) by PN1PR0101CA0036.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Fri, 12 Mar 2021 12:31:33 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 6b417bfe-245a-4d51-119f-08d8e552d30a
X-MS-TrafficTypeDiagnostic: AM0PR08MB3075:|DB6PR0802MB2264:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DB6PR0802MB2264B231A1039C2734BFC8C8896F9@DB6PR0802MB2264.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: SokZYv1GmHpjfdptX7Mf6Vspmb5wBdJ6f5rWJ2eX2joakNfCIiFD2XizyNmGp3F8Hq+imFbQM/FdncyEpa5deymJVtZ/8BZJNr68DJFKQc/GdMsapgtCVEWQ2N43ET6lP5UYXXNnntE7TZZ7X5UqkDrPA/ktYMRs8oX4hVbqgMPiu2Z2bE6A709xKvRxEgPaeQb+FlSdWQGm5RO7MJmgridRcri85vLtFLIUuS0YrjVnT+l1vwMpLflkLA+AFdwR5yXnZ31yEhJrJstVq95ZFRRCZRu5jfW2P7LM/SzYESfAFtj+v6VYmFbUS0P0Qhhtrmx8QTkFFmp5iGyrHmZnNfdbjLlRsn1t5e26EuQClO//cdCDp7gaN1/8fGbTqsTIjxqgGKi6cB/elAawzqAJueG1pLWj/kwPj3H7DJdLf5ONqVMRciwRAvtCFD6vN2I2q08bYy4m5FzIWwO+0U672uCKoQIxVXOWkwuPXKJgQ6Qoi0dTT3dWP0tnAGWI2eZW8n6uBRXPLkqpm6KbrLgYcmWMUN7aWNYyd60DlbqjciEpzlB+cy4qHJbLFCthflbHT61OX+ey+StXnsGwQytTizEZbs+E45hVWTnLMD7kYZzT6f6T5TjJtVKYOKEoCi26tsoy8CqjmDg9ACLS/S3b9g/aVcwlZcKtgUh1lwN2kOY=
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3268.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(39860400002)(396003)(136003)(366004)(316002)(52116002)(83380400001)(8676002)(36756003)(86362001)(6916009)(8936002)(2616005)(5660300002)(478600001)(16526019)(26005)(4326008)(7416002)(6486002)(186003)(16576012)(53546011)(31686004)(31696002)(66556008)(66476007)(66946007)(6666004)(2906002)(15650500001)(956004)(43740500002)(45980500001)(414714003)(473944003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Z25Wbk5OSWtZZ0phU1AzNDB5WUNFeFdjTGlsaGhEbEFWSEc1cFAyZTZMNHUr?=
 =?utf-8?B?UzN4d0ZFYmRyTDFYWjREVWo4RmU4Rm5YbEJvbHpYaWpmR1ZVc1lCdnI1WlJz?=
 =?utf-8?B?VDNicjQxekZ5Njk2UVFQK2RERDMzK3VZRndVN3d3RjBPc2o4UU9VZ1VzY2Rr?=
 =?utf-8?B?dnU5TnlHbm4wT3J3bmdiNERZNjVoQml3YjhkMW50KzEwUjZYaEM3bmRXdVJ4?=
 =?utf-8?B?R3pJV3lMa1p0UjBUVzdTakdRNlV6KzdML09wNDBzQ1FWMi9KcHI2eWVDd2sw?=
 =?utf-8?B?QVhINzB4TDBYTS9FYk9WQ09BOWdoRFdIQU5MTEQ1V2l3RUkxR3lBOWw1V0NX?=
 =?utf-8?B?eHpJV3NhMXhBQW0yS0psbzJXazNHQmttczFHbHNYQlNOZ1JmYlBRYS9saC91?=
 =?utf-8?B?U3pOUEF0K0ptd21UOEF3SStQanoxMTA0TjRxcEJLell4TlhpYnQ4QnBFQlBy?=
 =?utf-8?B?d2pCcDAzcmVKSy9xdFYrNWZ2S0FicjVpLzNMMHpuN1JDS1ArV3U4UWUrNEkz?=
 =?utf-8?B?RXNHczJJMVFwdHQ1VHZONEVsQU1OYWRFMlRRQ3h6czJwUnNaTTJVMS9mMnE5?=
 =?utf-8?B?cjc0RkUvNnE2Qm9vUVg3Uy9QS2FDYzJ0M2VBdlRZRHp6WFZ1dmc4RE5ZMjdh?=
 =?utf-8?B?ZU1icENEckRHVnZaZm1YT0txZllKREltKzNoK1c0NElNNndPcWFSRldOYVZ0?=
 =?utf-8?B?eEdvVmZJRFJrbHBRWjZvVzdRd3ZiaCtuK05TNDVPL0xDYnRzQ0d1UWZBeHVq?=
 =?utf-8?B?VFdjSytFSTdGNWRNM3U0UWhRNmZ3VWM3ZGRsUDV3TFkwZ3hTSW0vOXo3c1A2?=
 =?utf-8?B?YW9xWWN0cWErYkhGTWNqcVZTaUgxNVlTRWcyQzVYWGpCQkFVZHcybUpmL1Fs?=
 =?utf-8?B?YUhtQ1c3MkU2Y0M2WVRyWUh1K0d2NW9hUTh3d3VsdzJqSGZWeTJxNC9tajNJ?=
 =?utf-8?B?cFpyRWU3T0Y4bHVQSzlVMWNDTFBiRXdyQWhTNmRWT0NvRGZ0c3hmZEpXa3Zv?=
 =?utf-8?B?QWI5WjFBL0lqWWZhdmEyRGU4TjNKZUVabm50cFl2enZ0Rklnd0xmenJCLzNm?=
 =?utf-8?B?ZUUrK2Y4RFdLL3V5Z0wwTUtYS3VUUjUva2l5aHJsQ2pvaU1NWEVaN3NTNmJF?=
 =?utf-8?B?UmR0U0JJYTdqdUJJQjUyb0Rsc2dzem9ZcWVRclMwbnVwYWNuMjdtVTQ5Q2g5?=
 =?utf-8?B?ZGFWZ0xyVitEbVVqQ3kvTTQyd0UvT0I1bzhrUlhEVmNuUWJxeHdnTGhkNklO?=
 =?utf-8?B?ampFZ0hTWm9RSFRYMHhOVHdTeXptckVXY0ViQlhKUzEyZUJSQVUvbXFtU2ZV?=
 =?utf-8?B?T2xHR2k3Uk82NWZJajlMaTZ6ajFKamdVREEyUzY3dUgxajgyMFJsU1dmNnlp?=
 =?utf-8?B?S0JQMS9rYWlyak0wS3JNNE5ZRE84V1JVNVlLMUp2SlVFUVBRT0VMS2ZIVUlY?=
 =?utf-8?B?bTB4Y0g0VHFPYU93ekM3UHVJK00yQ0VYblNCVFFlOU5KeHR4bDc4VlIvUW9E?=
 =?utf-8?B?NXFZOWtHTjFKU0xLVmE1Q1F5ODRKQkl6TW9BYnVDNTNuQWlYdjBmSWxrZ1pR?=
 =?utf-8?B?eE5ES2lOSjNiOWdqRlBzeVBSQ3BEaXF4NGJFNmlIOGZnTnh2SExhcjdZT1lG?=
 =?utf-8?B?Z3Q4My9mL0tnbUl3TEcrd0tGenZqVHpzRFh6Snl1QVkyWXNxcnYvT214SUpx?=
 =?utf-8?B?cGhGN2s2ZWt0T0ZsREdqdGs2RmlzOFpqUjRFQS9sRmU2ZU1LbTFUVk1kMDFj?=
 =?utf-8?Q?Mm6DyuwpX8RV6iqpIKz/HJpN/i6Km9MFGeEaqeY?=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3075
Original-Authentication-Results: huawei.com; dkim=none (message not signed)
 header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: 3182366d-8c37-4b67-eae0-08d8e552c6dd
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2Ok6R5G9iOWWRc5LFvhSPLUa6I806nJqFEDnDYme+9S2sCMoIJksRvULjS4ADsTZiPaoscj5mA6r4tl/pleKC+CpseGK+/ef3PkmczOXB8S9D3aTLz1J94n5vxWytn+15orn4kcnoec4iTGM3vxdYpq2lJQNGyOGfJ3TYQvUL/+PomjebBoxRkbFBf2M4NlTtxTaT/jzPPpj3FBlpVgwFBtJ1xlCAJYHlHQZHqBBou7Vg7OwBMM0fkQxfYvyNqPR+wCoXDG23viKizvTODvnsv1wg1sanH9VwOVoHfXelifU5+6p5WF8FcQgbSzdggFQLiYZZBJUm6rQBPbwKQA/sy3Wbumcay5wrHwJiuX3mHLJ2f5t8SDadCTSdIuBqWgLjzi1QdWhYoNV9Ti2h16ymjrHYU/jY3a8NOTgKMMpOrsfaVQ4Vac4VZV9VoCYZ7i3M/gL1oeTJZaB21NRIc+MI27LakKKvNcS7SYJ4b9RluI4FhYPXh+JvbwDctwvicGxjla50haBwquVBB1cG5FtCILawFvykoFxmJPhE+OzsJ6AnuwCNktU9uzaMZqWQAzuhGptyb/PbhATMeq8FiCil5TUy1bvPJXSqaqKKX0UbBMBX/Xo4kZkRrNkNRUF1SdzEdPKEC7Pqbac+ewPsbkLgEj+mZ7jQfCntBjkxJI3G4XqlkTrFOfofNI+sZpeD347SQ90v+gEzZOy8KVV8nodEyU/GLdiJCyUZ8BZBS4adVw=
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(346002)(376002)(46966006)(36840700001)(70586007)(107886003)(6486002)(5660300002)(6666004)(186003)(6862004)(956004)(2616005)(70206006)(316002)(16576012)(26005)(2906002)(8936002)(16526019)(15650500001)(356005)(31686004)(82740400003)(36756003)(478600001)(47076005)(81166007)(83380400001)(31696002)(82310400003)(86362001)(336012)(36860700001)(8676002)(53546011)(4326008)(43740500002)(473944003)(414714003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 12:31:56.3076
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b417bfe-245a-4d51-119f-08d8e552d30a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2264
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jean,

On 3/3/21 10:44 PM, Jean-Philippe Brucker wrote:
> On Fri, Jan 15, 2021 at 05:43:31PM +0530, Vivek Gautam wrote:
>> Update base address information in vendor pasid table info to pass that
>> to user-space for stage1 table management.
>>
>> Signed-off-by: Vivek Gautam <vivek.gautam@arm.com>
>> Cc: Joerg Roedel <joro@8bytes.org>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: Robin Murphy <robin.murphy@arm.com>
>> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
>> Cc: Eric Auger <eric.auger@redhat.com>
>> Cc: Alex Williamson <alex.williamson@redhat.com>
>> Cc: Kevin Tian <kevin.tian@intel.com>
>> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
>> Cc: Liu Yi L <yi.l.liu@intel.com>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
>> ---
>>   drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c
>> index 8a7187534706..ec37476c8d09 100644
>> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c
>> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-cd-lib.c
>> @@ -55,6 +55,9 @@ static __le64 *arm_smmu_get_cd_ptr(struct iommu_vendor_psdtable_cfg *pst_cfg,
>>   		if (arm_smmu_alloc_cd_leaf_table(dev, l1_desc))
>>   			return NULL;
>>   
>> +		if (s1cfg->s1fmt == STRTAB_STE_0_S1FMT_LINEAR)
>> +			pst_cfg->base = l1_desc->l2ptr_dma;
>> +
> 
> This isn't the right place, because this path allocates second-level
> tables for two-level tables. I don't think we need pst_cfg->base at all,
> because for both linear and two-level tables, the base pointer is in
> cdcfg->cdtab_dma, which can be read directly.

Sure, will remove this.

> 
> Thanks,
> Jean
> 
>>   		l1ptr = cdcfg->cdtab + idx * CTXDESC_L1_DESC_DWORDS;
>>   		arm_smmu_write_cd_l1_desc(l1ptr, l1_desc);
>>   		/* An invalid L1CD can be cached */
>> @@ -211,6 +214,9 @@ static int arm_smmu_alloc_cd_tables(struct iommu_vendor_psdtable_cfg *pst_cfg)
>>   		goto err_free_l1;
>>   	}
>>   
>> +	if (s1cfg->s1fmt == STRTAB_STE_0_S1FMT_64K_L2)
>> +		pst_cfg->base = cdcfg->cdtab_dma;
>> +
>>   	return 0;
>>   
>>   err_free_l1:
>> -- 
>> 2.17.1
>>