Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Authentication-Results-Original: huawei.com; dkim=none (message not signed)
 header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;
Subject: Re: [PATCH RFC v1 06/15] iommu/virtio: Add headers for table format
 probing
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        iommu@lists.linux-foundation.org,
        virtualization@lists.linux-foundation.org, joro@8bytes.org,
        will.deacon@arm.com, mst@redhat.com, robin.murphy@arm.com,
        eric.auger@redhat.com, alex.williamson@redhat.com,
        kevin.tian@intel.com, jacob.jun.pan@linux.intel.com,
        yi.l.liu@intel.com, lorenzo.pieralisi@arm.com,
        shameerali.kolothum.thodi@huawei.com
References: <20210115121342.15093-1-vivek.gautam@arm.com>
 <20210115121342.15093-7-vivek.gautam@arm.com> <YD/ExjIwG/as52CI@myrica>
From:   Vivek Kumar Gautam <vivek.gautam@arm.com>
Message-ID: <375eae7c-4bfd-331d-4dbb-2cba857ae369@arm.com>
Date:   Fri, 12 Mar 2021 18:24:25 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YD/ExjIwG/as52CI@myrica>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.162.16.71] (217.140.105.56) by PN1PR0101CA0001.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Fri, 12 Mar 2021 12:54:29 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 9cdc8244-f03d-4661-281e-08d8e55601d1
X-MS-TrafficTypeDiagnostic: AM0PR08MB4403:|PR2PR08MB4762:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PR2PR08MB4762871C6FF0D14FAA378E79896F9@PR2PR08MB4762.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: E9678DsWv6Y7XvWJ9/ZYkCxLWtRMcrBFELBvGejU0RJ/S/ymPdwxdQthkiglqipmvBO6uNKyflMJL4dOetv8lF0vo7Jp4o42JiKumFTlCmBIzHNHURwolOkR518i6gPXPDpfcGW3uVvy2R2lWQ/NcD0LiuErUh63WYzNLgkauvk6SOYm5L8UEMWxaW5GE3U90ynRoT1MS/448gpqG5VwMjMhPimDPZ10a5VBl7XjFQLT651q7YnuWk8JH6o+7yAx+ok2k6UKfL4kMm0HlQz1PqOvJ9ZClkmCaxR7xIbT46R4+98IbLPsrzg11Lzy5tu0OuXLa4mx6OevAXJ4ntcSn+f256Zf/1N+RFuCQ6ZDXH43Mn+1X+qu8NIG+RvVuFaVe7GUHxkstYEfY2cJ+PYOTjr7QUjden8Bym3EPJsrnBi2sBtN5FLPkSB2NOed1KN+0ph5ollYrdd9YdG3t7/bGZr3KaPxUifdVIcU58j9onZzTuAqiOk6WHKGJqamFwIrcB3bhIvXpl1P7rr0M0zehu5Bsv09rf/L4gjdgbBQfF//rPOcN+oZNeWlrSCYOs/m2iqKRxBlcgxNSyDnYm9i3sGiyOujtq04Kh5sezjVJtw2dWOUY11TOhm0jW0xSzJW5qdWXUf1aiQk73eAmnU0CBC3Q0N+E1AIPXYtIXwGbFK5wkS7s0Vs0mFpqo7t0mYI9KdkOyDCRzi98fz3Q+Azd6S273e75hyrrnUDf0pZjX4=
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3268.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(39860400002)(136003)(396003)(366004)(83380400001)(36756003)(52116002)(31696002)(31686004)(53546011)(316002)(86362001)(16576012)(6486002)(66946007)(6916009)(66556008)(66476007)(5660300002)(966005)(8936002)(478600001)(8676002)(2906002)(4326008)(16526019)(186003)(6666004)(26005)(7416002)(956004)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cngvNURjaVJvbFFIVlBxZWkzRGV2ZjRsRXJDQW9haFJ4WlpDUlM3TWphVyt4?=
 =?utf-8?B?L3pES0NOTXJKZHorUjdqZjZUTW1EOWhpMzNEdTdnOXBzRUdSYlkrblMzT011?=
 =?utf-8?B?V3UwNEc5MmJpUkt5UTI1TldyLzdITG1sKzRiUytQNGFVQkNtM2kzeUV6ZnZx?=
 =?utf-8?B?MGV2VHRkUXgrOVNjcUtyc3dhMFJpOEFNZTZMVEUwdFFrMEl3S2gzR2JxbXQy?=
 =?utf-8?B?Rjhqb3ZQSnAxWml1QXpTVWNhN2tsVkk0WWx6bWpzVkx6Q1pLRXQ3eGQ4MjF4?=
 =?utf-8?B?MnVaYTFEZHFzZHFIUG9FRkI2R1pjSUVMYS9Xa3VnTjZkY21sTmJoQjRtRjdv?=
 =?utf-8?B?NlArZW5DWjdBekVvS0t6MVhSQklXZ0tpYW9jOUFVN0ZzYnhTRXc2d1EzcGpj?=
 =?utf-8?B?cHhadXZIaVBpTEZaQm9qRnpHS1FuTE41ZGxycWpSV1JFRjJ0V3EybmxkZzdr?=
 =?utf-8?B?ZzlRQ2U2NTNRcDJMYnBzNk9Jc3FwM1c3cFVCQVNnZlR4cSsxTUNrNkJ4RDBL?=
 =?utf-8?B?dnNXblZZRFZjWW1mbVJ0WE5zR2pRdTlIZ3ROd0hJLzN1TlE1YzNKVUxURWU3?=
 =?utf-8?B?ZnduNVM3Y1BEbGUwUmd5TjM0ZXBsOEprRC8zaVF0cUZoN3FOSHR1UlZjdjZ1?=
 =?utf-8?B?eFBYSDQvS3F5UDZ4amJHU00waDk3bG9sVmZtRm9yOVQwWWo1U05Mb25WUDFz?=
 =?utf-8?B?QSt5SWlUTkZQd084WjEyenMzREs5YVY1bElmWk83a1J2Q24zNTBIdnBVMzlT?=
 =?utf-8?B?L1U1UmlCTTUvYlVhZURvc0RyQUJFMlQxQVRoaGhZSFBMcUFTTUxtVEhMdzRN?=
 =?utf-8?B?U2NPTGVSd0UwcEZxZEZacTVpY2V3WllxeEhkWVgvUEJvNXZYWmp2aFhCZ2cw?=
 =?utf-8?B?OUdVMmtueXYvQ09tMHltekN4dEdIWXJaVWJxZnZpZlJBR3lLWjZhRjAzZXdi?=
 =?utf-8?B?S1ZBSFBaRlBWSWRGQXJscjRqVGFHRFNBMEdEMUQ0YmRJMW4yUGxCZ2RvM0x4?=
 =?utf-8?B?OFBldktTT2dNNHZHaDFvUmQ2MnpRZW5oQVhqaEVZK0V1aS9qT3VPbmhxR0Na?=
 =?utf-8?B?NlJYa3o0d3ZEL1ZHaWdEcW5aUHcrQTZwRWl6SUFVc3dJY1RMSXF5dEg2c0h4?=
 =?utf-8?B?UTZUd2czMEJLZE5hRVc1NGhEK1R3aVFFQk1mb05CdGp0RWpsTUFCdDhVd1ZT?=
 =?utf-8?B?eTlLampSUktxMzdaV01jcjlKOUNaU3FPQTFQN3l5NWlucTR4NmRNb2VucExo?=
 =?utf-8?B?QUlKUCtVYlZsdXh0WFlqcTc0MVNMMmlzRG4xQkRXK2FDUjhlSzdTcU9GQWRa?=
 =?utf-8?B?OS9JQnVrcU9hNTB3T1VOazNFaFg2SEhpbDl3ZDIxVmVOdFJySHhCKzdMN3VD?=
 =?utf-8?B?ZTVHQmR5ZklhVzlsMk9QMkNpM0J4YmdoTmtkRVNiN3JFQnB2b3NCdFc0WXo3?=
 =?utf-8?B?Q0taclNONDFEeU1oSHBtVEdXOGNJeGRudFdzTExoMFdIUkdNZEZ5dXdSeitu?=
 =?utf-8?B?YUNaSjNnY2NBa2hMSC9pNWl0SlExTHR6Wk1EdXpmLzZGQ3BxaExIMG12aGNQ?=
 =?utf-8?B?WFhOUzZyc1hwVVpyNW95MGFORjBGUGF4eFpOWjhXQ2NJNC93WmI2L1pXZGFG?=
 =?utf-8?B?eE51UXloVE5aUFNCMUQ4eEZ6T1NRekE3RlRXREMweHZVU0RkZjFTbGZLYlFn?=
 =?utf-8?B?MkFkc240Um92dEcxcjViMG5FNWdXcFVuMjE1NWJhWFI0OVJxY1FTQ0NSWGtV?=
 =?utf-8?Q?7Yjv8/bDDzwA5N7O8YnpYXU4lsn8WE7wxj8CQ7e?=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4403
Original-Authentication-Results: huawei.com; dkim=none (message not signed)
 header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: 4f1a8829-bd5d-4ef5-8560-08d8e555fb48
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: BwdbBxAEwdPA3wRlWV+R9TRGJQ+yYU4Qu350pcNYkk4QNTnc4kUcgkaUXVxtfAIN8QKSgzRFTYkSYZJAzYwGrnmERbt3P7btkiXjiDQEksvDrF05fwRCH55yMpPkaMcb8cUqNkwOd/EEKcABWmvXhg5CtAlmrt59Uneg5GdpywTWBv832sU2Uqam11gDRZ6B+3oyuLoTGkOmJ0Jnr+unjE7okR+Jn4IXzqKfSstwJcBmw2ooY1rOcM4tSFXJn7+YJrbwwIoYmMwPf0w8U/Qeml0uEAIZUmhOlTxA5Al9vA1KNPLBehPrsv47HA8wwvf83piGcUmnmpLeH2wrXddOZZChmURXvdM0EMPRzcmkT5AnTMYT+FCbyn7HoR9C2NaMJgNjYndzE/2zAmzAZZjR7T3LL0BEtHoVpqgfWuX8I1hvdopx9aet8i5i65PBY9gV/kmX74osygXYl1DYP62wvY9xij1ZsrIUyBHv7CzeN1bwLvkfLYlPRyCc3GSPgwdBwyaeO39wkZG1Nc0Zz1xCDhdB3bJ164Z37N8kwpl4h2AtHzaVZ+fgJxxZk37F+rhaupz0LJv4/pEejR6U02D4Zw6zukSNM2nlkpEYPiZPjoCa+AJA2MdJ1F8ZRwWOIqPOZJeoGsj244+4zQ04YlFajTWQ4X/pbx53xa+u6NhhrG3yjYdCzuvvC0RAwsJMf+wCGXATL+DNU+TkiZeyNPRoCgpIxUQjGHpwsaq7ujw1cI1VX5aQInTQMKoe8TbRCFBGwC/2LAECaVElEIuYENi0+Q==
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(136003)(39860400002)(376002)(346002)(36840700001)(46966006)(8676002)(5660300002)(6486002)(6666004)(107886003)(2906002)(966005)(16526019)(316002)(16576012)(478600001)(53546011)(336012)(4326008)(8936002)(186003)(26005)(956004)(2616005)(6862004)(83380400001)(31686004)(36756003)(82740400003)(356005)(82310400003)(36860700001)(81166007)(47076005)(31696002)(86362001)(70206006)(70586007)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 12:54:43.2818
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cdc8244-f03d-4661-281e-08d8e55601d1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4762
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/3/21 10:47 PM, Jean-Philippe Brucker wrote:
> On Fri, Jan 15, 2021 at 05:43:33PM +0530, Vivek Gautam wrote:
>> From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
>>
>> Add required UAPI defines for probing table format for underlying
>> iommu hardware. The device may provide information about hardware
>> tables and additional capabilities for each device.
>> This allows guest to correctly fabricate stage-1 page tables.
>>
>> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
>> [Vivek: Use a single "struct virtio_iommu_probe_table_format" rather
>>          than separate structures for page table and pasid table format.
> 
> Makes sense. I've integrated that into the spec draft, added more precise
> documentation and modified some of the definitions.
> 
> The current draft is here:
> https://jpbrucker.net/virtio-iommu/spec/virtio-iommu-v0.13.pdf
> Posted on the list here
> https://lists.oasis-open.org/archives/virtio-dev/202102/msg00012.html

Thanks, I took an initial look, will review it this week.

> 
>> 	Also update commit message.]
>> Signed-off-by: Vivek Gautam <vivek.gautam@arm.com>
>> Cc: Joerg Roedel <joro@8bytes.org>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> Cc: Robin Murphy <robin.murphy@arm.com>
>> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
>> Cc: Eric Auger <eric.auger@redhat.com>
>> Cc: Alex Williamson <alex.williamson@redhat.com>
>> Cc: Kevin Tian <kevin.tian@intel.com>
>> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
>> Cc: Liu Yi L <yi.l.liu@intel.com>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
>> ---
>>   include/uapi/linux/virtio_iommu.h | 44 ++++++++++++++++++++++++++++++-
>>   1 file changed, 43 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/virtio_iommu.h b/include/uapi/linux/virtio_iommu.h
>> index 237e36a280cb..43821e33e7af 100644
>> --- a/include/uapi/linux/virtio_iommu.h
>> +++ b/include/uapi/linux/virtio_iommu.h
>> @@ -2,7 +2,7 @@
>>   /*
>>    * Virtio-iommu definition v0.12
>>    *
>> - * Copyright (C) 2019 Arm Ltd.
>> + * Copyright (C) 2019-2021 Arm Ltd.
> 
> Not strictly necessary. But if you're modifying this comment please also
> remove the "v0.12" above

Sure, let me keep the copyright year unchanged until we finalize the 
changes in draft spec.

> 
>>    */
>>   #ifndef _UAPI_LINUX_VIRTIO_IOMMU_H
>>   #define _UAPI_LINUX_VIRTIO_IOMMU_H
>> @@ -111,6 +111,12 @@ struct virtio_iommu_req_unmap {
>>   
>>   #define VIRTIO_IOMMU_PROBE_T_NONE		0
>>   #define VIRTIO_IOMMU_PROBE_T_RESV_MEM		1
>> +#define VIRTIO_IOMMU_PROBE_T_PAGE_SIZE_MASK	2
>> +#define VIRTIO_IOMMU_PROBE_T_INPUT_RANGE	3
>> +#define VIRTIO_IOMMU_PROBE_T_OUTPUT_SIZE	4
>> +#define VIRTIO_IOMMU_PROBE_T_PASID_SIZE		5
>> +#define VIRTIO_IOMMU_PROBE_T_PAGE_TABLE_FMT	6
>> +#define VIRTIO_IOMMU_PROBE_T_PASID_TABLE_FMT	7
> 
> Since there is a single struct we can have a single
> VIRTIO_IOMMU_PROBE_T_TABLE_FORMAT.

Right, that would make sense.

> 
>>   
>>   #define VIRTIO_IOMMU_PROBE_T_MASK		0xfff
>>   
>> @@ -130,6 +136,42 @@ struct virtio_iommu_probe_resv_mem {
>>   	__le64					end;
>>   };
>>   
>> +struct virtio_iommu_probe_page_size_mask {
>> +	struct virtio_iommu_probe_property	head;
>> +	__u8					reserved[4];
>> +	__le64					mask;
>> +};
>> +
>> +struct virtio_iommu_probe_input_range {
>> +	struct virtio_iommu_probe_property	head;
>> +	__u8					reserved[4];
>> +	__le64					start;
>> +	__le64					end;
>> +};
>> +
>> +struct virtio_iommu_probe_output_size {
>> +	struct virtio_iommu_probe_property	head;
>> +	__u8					bits;
>> +	__u8					reserved[3];
>> +};
>> +
>> +struct virtio_iommu_probe_pasid_size {
>> +	struct virtio_iommu_probe_property	head;
>> +	__u8					bits;
>> +	__u8					reserved[3];
>> +};
>> +
>> +/* Arm LPAE page table format */
>> +#define VIRTIO_IOMMU_FOMRAT_PGTF_ARM_LPAE	1
> 
> s/FOMRAT/FORMAT

Sure.

> 
>> +/* Arm smmu-v3 type PASID table format */
>> +#define VIRTIO_IOMMU_FORMAT_PSTF_ARM_SMMU_V3	2
> 
> These should be with the Arm-specific definitions patches 11 and 14

Right, will add these definitions with Arm specific patches.

Best regards
Vivek

[snip]