Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Authentication-Results-Original: huawei.com; dkim=none (message not signed)
 header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;
Subject: Re: [PATCH RFC v1 09/15] iommu/virtio: Update table format probing
 header
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        iommu@lists.linux-foundation.org,
        virtualization@lists.linux-foundation.org, joro@8bytes.org,
        will.deacon@arm.com, mst@redhat.com, robin.murphy@arm.com,
        eric.auger@redhat.com, alex.williamson@redhat.com,
        kevin.tian@intel.com, jacob.jun.pan@linux.intel.com,
        yi.l.liu@intel.com, lorenzo.pieralisi@arm.com,
        shameerali.kolothum.thodi@huawei.com
References: <20210115121342.15093-1-vivek.gautam@arm.com>
 <20210115121342.15093-10-vivek.gautam@arm.com> <YD/Fiuxd9/kThGxt@myrica>
From:   Vivek Kumar Gautam <vivek.gautam@arm.com>
Message-ID: <84bd0439-9517-37b7-8827-08c6effdadd6@arm.com>
Date:   Fri, 12 Mar 2021 18:28:31 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YD/Fiuxd9/kThGxt@myrica>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.162.16.71] (217.140.105.56) by PN1PR01CA0115.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Fri, 12 Mar 2021 12:58:36 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 58f3cf3b-a97b-4c27-1f89-08d8e5569365
X-MS-TrafficTypeDiagnostic: AM9PR08MB6897:|AS8PR08MB6421:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AS8PR08MB64216D4E1FCE962C9F62606B896F9@AS8PR08MB6421.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: sCq1ZdYqC2ZP1vkNAbKgywR4XROgOyLpqA20YcxPAT8f10SldRwbJpXde5F/Syb13vWRDThYLNvC3jgU3NJcFeXvM0Ljni1yMJS0uD4D/mZUrl8tlhF7v7hXilP9OW0yInvVNQwicgGitiPaQRnMDz9fdKCwDeujMPU8JvLs9U1V4tXtlQlOfys5bFE+MjW2wBMMyAoct9i8evsRQQlP1jjq8HQ/dtoAnwcHFeMYrhg63tDKoMdQQ4Fzpo2pwC43dk0+k3PzXC1meUmPjpQF0XWs0dYl5CySlBbScb++FWXnDok3MYfUSyxUErkTwKTFvMWmqU5VoY+2W6fBbNAZNUCnujL7wJ3QjQB7CTtWn+uQipTbM+E+B0bMo0YrKo5UuiP5mOXBUHvelF9TMChwx4TYFlYEkUy3isolwBn8XrbU7NG0Xi8Sk4VVVfMqiJRlfRTA5C0EYoGxOTZX+ClBTQDHUn8NG+k/z6tBWlGcRxBPEgbn5dTCRoXDi+HZmqf5CmpmDUdaDta7sl7Ent5rPNWnoQQQEFxttq3n+xbrb+ltedU9mxOF/NlxXyF1kJgv0hdTZL5XxvY6rget/Yft1t+LjxrcXMuXRJixEFQXIequHi4LZGyi/MdqSI/d+IRA5f+8vNaIi2t+EaswuDDxKg==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3268.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(478600001)(8936002)(16526019)(36756003)(31686004)(8676002)(53546011)(4326008)(83380400001)(31696002)(86362001)(6666004)(52116002)(5660300002)(186003)(6486002)(66476007)(6916009)(316002)(26005)(2906002)(7416002)(16576012)(956004)(2616005)(66556008)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YVVja2laOFBNSURMZmp4cU5UR2FybnRxVFhKTlVBb0VyTmluODFlTWFSWG1X?=
 =?utf-8?B?TFZ2dmxnMzJxUnFzamdoZzRUb3lCMjQ2WmlDYnJJbFRINEFCUkJQclo3YzVH?=
 =?utf-8?B?TlR2cklwT3FoOXUwM3NINUdwcTI1QmlsZXU1ZlliMGQxTGllellyeWprUnhT?=
 =?utf-8?B?N3QvUkk4VEJwZEFZUTdKTU56WHUydDNkOVNoek9KSTUzcTI5eFJmcXRrUW5C?=
 =?utf-8?B?ZTM5U01QRnBtY2RWZURaV1k0VEF2ZGthSlNVQ2ZIS1hDczBQUitpN0RxeW5V?=
 =?utf-8?B?YzVjbGRxM2lEcTFnditLNWRRZDIzNEhlVlBNRUowUitrQ0JpL1NaWTB0Ri9a?=
 =?utf-8?B?ZmJQSmNIakoxb2thVmI3K2ZqOExZblF1TWN4c1FVUXhUUlhxYkRINExZcEti?=
 =?utf-8?B?VGVyUmlqYm5HdW1Ub2h4ekd5MEtkaXhma1h1L1JmUmk1TFhWczBodWYvd3dJ?=
 =?utf-8?B?NHF0L1RPT1V5c01BTVRhWERiNUNTTjlHV2tyM2ppeFlwZUpIY2hYeVVLMUpG?=
 =?utf-8?B?ZDE2YmlUNm1CQkMvcG5PY21jS1I2K21Kby9mazFGN2o3K2NyNzYxNU5aYmhU?=
 =?utf-8?B?d3RaQUtaMEh6QU1sMnFWWFBrMFk2bE1DbVQyOGhXYitMMk5tdnhvL1ZKdkJM?=
 =?utf-8?B?cnM3STM5akFJdUU0SjQwaDRGSGtvbVdTUFNpYTRnbjRRckJUZ2lJT3ZmUTFs?=
 =?utf-8?B?Vkl6dzM2TGFLVWU0UEkwbDhGN2dSTkFWNDRrOG1CV3AzRkt5R0MxNTB2ZnNG?=
 =?utf-8?B?VFB6YXhuOU93V0gxL21wbStic3JZbG1leTlCNHZJYVpzalRaQ3pZbHJZTHlT?=
 =?utf-8?B?ZHFsUnVtbkJKSEdPQXdCb2JKenpQdk50dk9HY2lkVzFraVg1LzNoRkZzSmk4?=
 =?utf-8?B?RlJxM3VSL0tVMFdvQ0tJb0NLcWNvOW5hNFNoUkRBZE4yMjFwbnJCbFl3VlZL?=
 =?utf-8?B?N1QydUg1d21JZWFIMFIxdEN4NW1aWkNsTFlYREttRGtVWUZnUjhoL1ZmQjJB?=
 =?utf-8?B?TEJ6Wm1jUjRsajAwQ1hCdG1lU1k1ZUdiRVp2T0RFTkJVaXBneHJNc3J3em92?=
 =?utf-8?B?K05rTGsxRXMyWWtPUk5sUUJwbkR4RkYrckJaaVVDa1lRSnZrb1FiLzh5RmZs?=
 =?utf-8?B?SkYrL3VIdHRsTU1KbzZJTUdHdmJyRmlCM3MrRmQ3a0llV3owWU1rUlBvdXRI?=
 =?utf-8?B?dW9SdEprQ3U4U0R2T0tGVnBlbUNwang5ZGZvaVJ2Z0ZxK3dUREsrL0hjV0xO?=
 =?utf-8?B?UjZNR1pDWE8weVJMM0RsUnFWL2xpbmNPTVJqRVhBeHR1Q2s3aE9YRERxMFB6?=
 =?utf-8?B?TFFSckhFNUJQRnFpcFdFMFR6UEpvQVdmczJPSDVOZEZ6Nm1zUkh6WmlZcTBG?=
 =?utf-8?B?OTBvYnJuT3IyWEx5TFEvZmJKaXo2MTI0OVZITnIvcVk3SUFHbVNjdTI2eThM?=
 =?utf-8?B?Q0NpK0JYdWJZN2FjLzBwU2EyeGJaMHBDQ1NXOU5LdndRY0hxVjhFWDl3RktD?=
 =?utf-8?B?eStxdDd0WnJHZUtkL2w0c0xXOEtIVTVxYmNVU0k3RExYblpDOHNxSDgwd2Uz?=
 =?utf-8?B?MlpPN1BZSnUxcllyU3ZsaGZ6UWJPYkdJV1hrMkUvb1ZKeHJ2dFlpZ1lQMDgw?=
 =?utf-8?B?a016OHR4WFdBdkgvcVdkZnpOMGhxRzMvbmFIRCtBanE2WGZ6WkhxM3pFeTlk?=
 =?utf-8?B?SkpPbWVUNTJPalp2czY2MW94S2lmbnRaOXZaRy9CZmtkc0NjR3p4OVFCVGlK?=
 =?utf-8?Q?9zkSWIzJbw7Jev0zfmxQ1aEFTnd+eOy4N7RadN0?=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6897
Original-Authentication-Results: huawei.com; dkim=none (message not signed)
 header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: cd491e29-8b33-4d77-c529-08d8e5568e46
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EL1nbdMmyM30MIbgbhr7s8cvGC3wMvsvXs9ZE3CA2mrPEkGo5bti70f8gJ1DSEorm6RoHHHX/8DJCjQU04AZkUF9ZJqshrYFQs0PVuDlMlTt4EhAGNwIsHGPreeBEu8ada0AX3tCOtJaq2ckNEopqZxGv50s6bAGtrNeg5WznzOUQiayJhNt+Vn9QAM6ll8yxmX3fYCNtezT6eHeqFSDOJO60VBhg6xHmTk/vRLL3Xo624vUDgnTIy1yX3P1rjwSVDb4MJa8HlIKAcraFNX42yPTC/EJli0oV1F6ShfwnGfeIoJ+JemqRte5SRdCUPubnTwmxewXinwaYxb7AmtGMfsReqrrg0jHV1bTh7PjRyEvMJWYSG+smjl2zBYfORaqzy6K8yOx0cYyWytIAnwoyhVnrFIJxlW0BfRavB9zr2BB1bNFjWN7TuUKfEf1X3tGdKS6Ru8adiGM4V9ybqdZGNnv2RhAwvAgptSe8orilD5hQSkNiyjEUt2NYzlnpNHvzm8nw6Hb4WsOi+5LRIUNW64SpM/yyUQJUjCnae94ZgRKVXo4vU5PVhU4R2gFneNXPm7i1MVATi0xJGI4EQW42yvPC4kHGhrhAEuksMh+WRbpD0yZU6xXjQzG9F9dt7Gye66EVGzaDtCrJAUBB6GbqZNxUniQtc7COa1d5aLvbyxO00vssFc23Gs998HklA5F
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(396003)(136003)(39860400002)(376002)(46966006)(36840700001)(5660300002)(70586007)(82310400003)(86362001)(16576012)(53546011)(6486002)(186003)(478600001)(70206006)(81166007)(8676002)(356005)(26005)(2616005)(956004)(336012)(8936002)(107886003)(36756003)(6862004)(47076005)(16526019)(316002)(2906002)(4326008)(82740400003)(31696002)(31686004)(83380400001)(36860700001)(6666004)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 12:58:47.3969
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 58f3cf3b-a97b-4c27-1f89-08d8e5569365
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6421
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/3/21 10:51 PM, Jean-Philippe Brucker wrote:
> On Fri, Jan 15, 2021 at 05:43:36PM +0530, Vivek Gautam wrote:
>> Add info about asid_bits and additional flags to table format
>> probing header.
>>
>> Signed-off-by: Vivek Gautam <vivek.gautam@arm.com>
>> Cc: Joerg Roedel <joro@8bytes.org>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> Cc: Robin Murphy <robin.murphy@arm.com>
>> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
>> Cc: Eric Auger <eric.auger@redhat.com>
>> Cc: Alex Williamson <alex.williamson@redhat.com>
>> Cc: Kevin Tian <kevin.tian@intel.com>
>> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
>> Cc: Liu Yi L <yi.l.liu@intel.com>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
>> ---
>>   include/uapi/linux/virtio_iommu.h | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/virtio_iommu.h b/include/uapi/linux/virtio_iommu.h
>> index 43821e33e7af..8a0624bab4b2 100644
>> --- a/include/uapi/linux/virtio_iommu.h
>> +++ b/include/uapi/linux/virtio_iommu.h
>> @@ -169,7 +169,10 @@ struct virtio_iommu_probe_pasid_size {
>>   struct virtio_iommu_probe_table_format {
>>   	struct virtio_iommu_probe_property	head;
>>   	__le16					format;
>> -	__u8					reserved[2];
>> +	__le16					asid_bits;
>> +
>> +	__le32					flags;
> 
> This struct should only contain the head and format fields. asid and flags
> should go in a specialized structure - virtio_iommu_probe_pgt_arm64 in the
> latest spec draft, where I dropped the asid_bits field in favor of an
> "ASID16" flag.

Right, will take care of this looking at the spec draft.

Best regards
Vivek

> 
> Thanks,
> Jean
>