Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 12 Mar 2021 14:14:50 +0100
Message-ID: <s5heegktsxh.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Xu Wang <vulab@iscas.ac.cn>
Cc:     tiwai@suse.com, perex@perex.cz, joe@perches.com, jgg@ziepe.ca,
        chao@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: sb: Remove extra brackets
In-Reply-To: <20210312093625.65650-1-vulab@iscas.ac.cn>
References: <20210312093625.65650-1-vulab@iscas.ac.cn>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 12 Mar 2021 10:36:25 +0100,
Xu Wang wrote:
> 
> Remove extra brackets.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Thanks for the patch.  But this kind of change alone makes little
benefit, as it doesn't improve the readability significantly.
So I'd take such a change only if it's really needed, e.g. if it's a
preliminary work for the further real fixes.


Takashi


> ---
>  sound/isa/sb/sb16_csp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/isa/sb/sb16_csp.c b/sound/isa/sb/sb16_csp.c
> index 8635a2b6b36b..2c292bf0f5ae 100644
> --- a/sound/isa/sb/sb16_csp.c
> +++ b/sound/isa/sb/sb16_csp.c
> @@ -769,7 +769,7 @@ static int snd_sb_csp_autoload(struct snd_sb_csp * p, snd_pcm_format_t pcm_sfmt,
>  
>  			p->running = 0;				/* clear autoloaded flag */
>  			p->mode = 0;
> -			return (err);
> +			return err;
>  		} else {
>  			p->running = SNDRV_SB_CSP_ST_AUTO;	/* set autoloaded flag */
>  			p->acc_width = SNDRV_SB_CSP_SAMPLE_16BIT;	/* only 16 bit data */
> -- 
> 2.17.1
>