Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <f6efb2f36fc1f40eb22df027e6bc956cac71745e.1615498565.git.andreyknvl@google.com>
 <6cb4988a241f086be7e7df3eea79416a53377ade.1615498565.git.andreyknvl@google.com>
 <YEtH3oADQeTx1+bK@elver.google.com>
In-Reply-To: <YEtH3oADQeTx1+bK@elver.google.com>
From:   Andrey Konovalov <andreyknvl@google.com>
Date:   Fri, 12 Mar 2021 14:52:52 +0100
Message-ID: <CAAeHK+w=3E+oowUUWfnF=SX9KYYqbV+hp1OsUFPpJf8HGnJx9g@mail.gmail.com>
Subject: Re: [PATCH 09/11] kasan: docs: update shadow memory section
To:     Marco Elver <elver@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Alexander Potapenko <glider@google.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 12, 2021 at 11:52 AM Marco Elver <elver@google.com> wrote:
>
> On Thu, Mar 11, 2021 at 10:37PM +0100, Andrey Konovalov wrote:
> [...]
> > -The kernel maps memory in a number of different parts of the address
> > -space. This poses something of a problem for KASAN, which requires
> > -that all addresses accessed by instrumented code have a valid shadow
> > -region.
> > -
> > -The range of kernel virtual addresses is large: there is not enough
> > -real memory to support a real shadow region for every address that
> > -could be accessed by the kernel.
> > +The kernel maps memory in several different parts of the address space.
> > +The range of kernel virtual addresses is large: there is not enough real
> > +memory to support a real shadow region for every address that could be
> > +accessed by the kernel. Therefore, KASAN only maps real shadow for certain
> > +parts of the address space.
> >
> >  By default
> >  ~~~~~~~~~~
>
> While we're here, can we change this "By default" heading which seems
> wrong -- the paragraph starts with "By default, ..." as well.
>
> Perhaps "Default Behaviour"?

Sounds good, thanks!