Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1318486pxf; Fri, 12 Mar 2021 07:05:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJw3XNUJzEYcxpXnpAY4eIkK1mZrij+F7VWp3KtwfiBKN3ghcMs42oPTPu4wAfCUUwrwp1+H X-Received: by 2002:a5d:67c8:: with SMTP id n8mr14461420wrw.351.1615561509350; Fri, 12 Mar 2021 07:05:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615561509; cv=none; d=google.com; s=arc-20160816; b=qlwG94LKMPqDTG+8ZCa4bha/32mJAIdzDrkpM2Wb8MVEDKC/lG3oWZLVyJbkXoHaOw yECN32DnBn+UPYii6PyMq7WSTFDCZ3tkLw8ELKWjlE+J8Vk+ivpieS6f5MwaNQDxVSwn QvoJuQrIbEXLxyeL1lJj4SFOFTI40HMYC6J8JG9Ds4SVUYuOVwMvcj/ZOifuiHp3WSXc ap/5CEYcKFXGFOObt01zGFMWFzmlpE42k+JpPjP23N1XbHylhT9oE8iaSd02D2abJu/V u3Q3cNJX2cqzoYjcnWX3U/5ZOlXvypM5kxuBZOtdJaRsjren5vEks60N6R1RRHSy9+XG 363g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=oYoujhPE8PbUgmSNk8xDlQ7ZjhesQKrZNlt+OkHT5mg=; b=gRS4LNdnybPi2PFBWJZjEYM7suZY3lI31hfQ0aqHWLOXxyMlzMLFC1IgP/a28m0UbX x2JOfrpVc/Q2UhW6B6OOH5xoWqQTjS6jyrsxY8tpCEbnEw8kZkNFTUw0hOkSDAhdwTRL uxz02qrvJce6DAGeQTR8z16yyluzrDEGYYVTKNDO24Ijs2ntuYxIGAhpZLl+/JZUM0A9 YzWRkd5AD02BdjCQpj02pFtLlJYvjSHrys3Q8ISCOg4qVNp7sNfqkoV5J9UOGKPrIkOv BZ9dR27QrwWzcVmp/GzVCBj2OO0gOVxebqQ5jinUkOgEhlIPPNNHcChHFROxOu76Smtc DDTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d5si4005699edr.381.2021.03.12.07.04.40; Fri, 12 Mar 2021 07:05:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231378AbhCLPDd (ORCPT + 99 others); Fri, 12 Mar 2021 10:03:33 -0500 Received: from elvis.franken.de ([193.175.24.41]:53061 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbhCLPCt (ORCPT ); Fri, 12 Mar 2021 10:02:49 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lKjJN-0002Tu-00; Fri, 12 Mar 2021 16:02:45 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 28F12C1E4A; Fri, 12 Mar 2021 16:00:00 +0100 (CET) Date: Fri, 12 Mar 2021 16:00:00 +0100 From: Thomas Bogendoerfer To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-mips@vger.kernel.org, Florian Fainelli , Vivek Unune , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH mips/linux.git 0/5] firmware: bcm47xx_nvram: refactor finding & reading NVRAM Message-ID: <20210312150000.GA3743@alpha.franken.de> References: <20210308090320.9765-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210308090320.9765-1-zajec5@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 08, 2021 at 10:03:15AM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > This patchset refactors driver part finding and reading NVRAM. > > It been tested on BCM4706. Updated code checks the same offsets as > before. Driver still finds & copies NVRAM content. > > It's a new patchset replacing previous single-patch attempt: > [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM > > Rafał Miłecki (5): > firmware: bcm47xx_nvram: rename finding function and its variables > firmware: bcm47xx_nvram: add helper checking for NVRAM > firmware: bcm47xx_nvram: extract code copying NVRAM > firmware: bcm47xx_nvram: look for NVRAM with for instead of while > firmware: bcm47xx_nvram: inline code checking NVRAM size > > drivers/firmware/broadcom/bcm47xx_nvram.c | 92 ++++++++++++----------- > 1 file changed, 47 insertions(+), 45 deletions(-) series applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]