Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1329671pxf; Fri, 12 Mar 2021 07:16:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzIxxCQ1sWHs4tqmtpJXGN9tuxZDSyWlwAqaDxUE1HYpEEvGmU/B9vct+jEQf6iAtFN558 X-Received: by 2002:a17:906:8593:: with SMTP id v19mr9146975ejx.32.1615562174904; Fri, 12 Mar 2021 07:16:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615562174; cv=none; d=google.com; s=arc-20160816; b=VksAtYaN2kPFIYz0g4r/Ym15G0279xJDiaUSfBCcXleFHcWMzOFQ9FPb4gXq2a9V6E kkei4h8DIOZ5FExzinP8XpEyizcnNJLPR3y+M86WenXA81SBzf194dg+CoyS+OYITxGi fawGQhSYZmqyc7xg/EYOGs7ncWOWnBWkCBLU7ZOG9Hti7iAzonjSYyritznlq1sFhNM5 vu9zC5cfkMhDDqotK5ynjm0bjwaybTa40HNdcCsAauWoPUE1fd/FQ3bfqFFttJH+UAMn DDGnPm4ykOayxpvxc106xwX02Rtn+bb1lGl5Da758nlzeRQuvleuiGDOhX8KBfhL4Czd cqhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=d2Mt7Uy8Ud9JGdeuhKcoAs+Rwf4BhQisN6LvVUQfCJQ=; b=pWR1g6VpP4K0b2Gpz1lqx9jmcMnSjAxnmBpQVb/Vj0WqdC8bC2MtrgV5UK3XvPaoi1 qcaXNyX1zVq5bTzQqIo0horYRSJITxEDjNTe3Kl71U7yxeOe9GT/Awv9sK911/DIqyrw Mfae0R5NJJwJbLRRcM1iUOH+ysh6nwwr82HZemSh7PLAbn6uS5MQ/G5FTUSAdcYDlTCs UqsldHEr54jWqdsCWJztcy4IX9S3rbQvrKC9GsSY+T6x2qTfR8m1Vugih01C61JyVaKs ZI3BonaDL0PwFebIhAaL1fllYAIZTJbdap666hytYE3YbQz4komoCCdNk0asI2d5sv0V 9y9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ss27si4257010ejb.322.2021.03.12.07.15.43; Fri, 12 Mar 2021 07:16:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231906AbhCLPOo (ORCPT + 99 others); Fri, 12 Mar 2021 10:14:44 -0500 Received: from mga09.intel.com ([134.134.136.24]:64001 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231378AbhCLPOi (ORCPT ); Fri, 12 Mar 2021 10:14:38 -0500 IronPort-SDR: TPOU6JerdHtdffdrR8ScxdhgD2VYLhF3RHXzGRfmPNlEI5MrCg6blzNXN3yR+Sqi8aSwilkr0f nyl9Xc5xlrpg== X-IronPort-AV: E=McAfee;i="6000,8403,9921"; a="188937870" X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="188937870" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 07:14:38 -0800 IronPort-SDR: N9VKMYmfTNXld/b1lKiAKQX9WjkVM8fH8w/SpuamD0I9dPp4y3Cc+5h2l+36NOargUQ6UYLh7Y yH3nlMdZQlQQ== X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="448645717" Received: from tassilo.jf.intel.com ([10.54.74.11]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 07:14:38 -0800 Date: Fri, 12 Mar 2021 07:14:37 -0800 From: Andi Kleen To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH] perf stat: Create '--add-default' option to append default list Message-ID: <20210312151437.GO203350@tassilo.jf.intel.com> References: <20201222011131.12326-1-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201222011131.12326-1-yao.jin@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 22, 2020 at 09:11:31AM +0800, Jin Yao wrote: > The event default list includes the most common events which are widely > used by users. But with -e option, the current perf only counts the events > assigned by -e option. Users may want to collect some extra events with > the default list. For this case, users have to manually add all the events > from the default list. It's inconvenient. Also, users may don't know how to > get the default list. > > It's better to add a new option to append default list to the -e events. > The new option is '--add-default'. A more concise syntax would be -e +event The + would apply to the whole event list if there are multiple. and maybe -event too to remove something from the default list. -Andi