Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 9gFnzml09DRhBU7q5eQxdO3vkmg4C6ivyqGmzmfhVbCt5oAc9q+JWH635J7U0mtocmO22xDorW
 X+a0+NvoLU3A==
IronPort-SDR: /MOo4RgUkeskOo5LyvcFj8gURJEvIBko0VV7mgZ8vW4D1omMtxOAPIyuB6BKo3FFBJ0zybdTpu
 xjQc5LFKsWoQ==
Message-ID: <4609846ceedc24505dcaaba40933abb8b3e577e1.camel@linux.intel.com>
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and
 __TIME__ macros
From:   Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Antonio Terceiro <antonio.terceiro@linaro.org>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 12 Mar 2021 07:30:48 -0800
In-Reply-To: <20210312135746.1695294-1-antonio.terceiro@linaro.org>
References: <20210312135746.1695294-1-antonio.terceiro@linaro.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2021-03-12 at 10:57 -0300, Antonio Terceiro wrote:
> These macros introduce nondeterminism in builds, and break
> reproducible
> builds.

Thanks. I will include this change in my pull request.

-Srinivas

> 
> Signed-off-by: Antonio Terceiro <antonio.terceiro@linaro.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>  tools/power/x86/intel-speed-select/isst-config.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/power/x86/intel-speed-select/isst-config.c
> b/tools/power/x86/intel-speed-select/isst-config.c
> index 582feb88eca3..c50c754a656e 100644
> --- a/tools/power/x86/intel-speed-select/isst-config.c
> +++ b/tools/power/x86/intel-speed-select/isst-config.c
> @@ -2791,7 +2791,6 @@ static void usage(void)
>  static void print_version(void)
>  {
>  	fprintf(outf, "Version %s\n", version_str);
> -	fprintf(outf, "Build date %s time %s\n", __DATE__, __TIME__);
>  	exit(0);
>  }
>