Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1479929pxf; Fri, 12 Mar 2021 10:24:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsnnmFLTYDgfZkg2I5+WBPe9gHVKZCWdR8R9db8F8+z6/zdaFfUI30GeVojBESm8gFcm2y X-Received: by 2002:a17:906:ad4:: with SMTP id z20mr9819976ejf.496.1615573476664; Fri, 12 Mar 2021 10:24:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615573476; cv=none; d=google.com; s=arc-20160816; b=GQRxaY3B4F13IeKxPvUnd4rbowhqkf55CwR91OkTTK+bZ4MXWAGLGUvEEkSC8veiLQ 6QQK84vDzKxVh7Fl80RJsRqilBDknI+bMnpnVM3SUvBGAO/s2S5/DkmzwRB7AiZaGwK4 +Y7xN7fbGqBPlrOvOe1wqHh7i+K85VJWfh7qv+3f0GmYmfyUVGda2Ibh6fqZKyUnlTa7 kbKLVcg62wuD2b0NJLdeyWvmFHN64Gx/y0q3BBOaKqakECQ1pnhqJY4Y04vHUWBAxqTz LXdR2qaLQF75zBpArkl2NNpj0QHb1n4wHrhMnpHvVVTPpQ8ARYTKQff/KXA9UtizV49l 6+ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=92C4R1FtehelMBNt1Nmm/pE757Nzi/scIIInslZC7XE=; b=lqLX4WuvqL0AiLV9AuhwiP0TObJB0vfGzATzq0++QLlePPnDtt2fYtnYcgANM65KLj tSzz35HGnuBCh9h15vsqKVhKNTDYTZc0SJWmtqCrNIIzuTc0aoxK+6rJqFD/iQUVr2Qm nqBfwmqfUfGfMZ97uizns+McT2MYvHbdF0FmN/K4EvvJSKTvK2afP9LIz4x2A34zteNI vOlsxgVn5Op17tJj47brtMgf+Ss4nIeKWt3Chg699lN8AXgIqhembLnv4DF0CpSTgkkW VGiipa9Of6jmk9lNPHmBbZS2kWgUqhvE2rrmjqFrRH30B2bA2Ds1TSwOUHaU6LBMzeXr jOFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gb25si5023605ejc.472.2021.03.12.10.24.14; Fri, 12 Mar 2021 10:24:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233151AbhCLSXV (ORCPT + 99 others); Fri, 12 Mar 2021 13:23:21 -0500 Received: from mga02.intel.com ([134.134.136.20]:36913 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233119AbhCLSXK (ORCPT ); Fri, 12 Mar 2021 13:23:10 -0500 IronPort-SDR: UBpjiXn3sfteBFShaxHfLAXvrfK5UqElR9/6oEVo6kQ/Cufhnrbv7ANjTdv6MW1yHfSpw8hRrz YgILN9jI82xQ== X-IronPort-AV: E=McAfee;i="6000,8403,9921"; a="175999084" X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="175999084" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 10:23:09 -0800 IronPort-SDR: 7mFQaj0ncPzQXy21S4P27cDT1gMH9RkZghKZHFmkHbTRU4dX40t5Fpomkj5fWPLIPGcNGEjFAE FZ/IEpgbVSCg== X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="377791901" Received: from amiteshs-mobl.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.212.37.30]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 10:23:08 -0800 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Lars-Peter Clausen , =?UTF-8?q?Nuno=20S=C3=A1?= , Liam Girdwood , Jaroslav Kysela , Takashi Iwai Subject: [PATCH 02/23] ASoC: ad1836: remove useless return Date: Fri, 12 Mar 2021 12:22:25 -0600 Message-Id: <20210312182246.5153-3-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com> References: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cppcheck warning: sound/soc/codecs/ad1836.c:311:9: warning: Identical condition and return expression 'ret', return value is always 0 [identicalConditionAfterEarlyExit] return ret; ^ sound/soc/codecs/ad1836.c:308:6: note: If condition 'ret' is true, the function will return/exit if (ret) ^ sound/soc/codecs/ad1836.c:311:9: note: Returning identical expression 'ret' return ret; ^ Likely copy/paste between adc and dac cases. Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/ad1836.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/ad1836.c b/sound/soc/codecs/ad1836.c index a46152560294..08a5651bed9f 100644 --- a/sound/soc/codecs/ad1836.c +++ b/sound/soc/codecs/ad1836.c @@ -305,8 +305,6 @@ static int ad1836_probe(struct snd_soc_component *component) return ret; ret = snd_soc_dapm_add_routes(dapm, ad183x_adc_routes, num_adcs); - if (ret) - return ret; return ret; } -- 2.25.1