Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1480282pxf; Fri, 12 Mar 2021 10:25:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJwLlhW8zkpHriDxgtG1yorq64jaeYQY7gCA50krylXHjTuvqV0OEQrM1ySu9FET+p0oO517 X-Received: by 2002:aa7:d3d8:: with SMTP id o24mr15783867edr.165.1615573510235; Fri, 12 Mar 2021 10:25:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615573510; cv=none; d=google.com; s=arc-20160816; b=FFyA0G+O2bXviyK6+VwoezIQcXtNbPnzgoDiElbaCwpbp4RELbOtBqQZc6qhwnvdhv kjbMvTN5bqq4ZgIspkRCJMdujzNm9aijR2y/oKqW+z+8nbpc9c+XG/Kp2nl5DDtltnPS z3l2Piko9EZpAT3U8Lna8DPL/CUvb4h+4CKtaGdUg73Mtj5Ofyr/WIZh1tu2OpguOoHO ccEiqewvfHpc6knCswaj6qWH/bZyDUpvlenS2Ty7tAugoSuGrNsBmVXcSUS/7rwOjq8r cO/TeuBh8LqvMYZi90Eknf/PQk4VRdmFYZAJ1PwDr/BqkXdOMnfHfKzLE+PFhHv2fKCM lF0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=MKdFVKx2yuTo6ZdC7AMqwNzl+uKGRU83A+pVTMwmLg8=; b=xggBqi3y5BqFS76jk1KGYgdFgHb+8TKHaHyqIxboyw+7mTX71ZEBeJXJ7jgUIRMzOm zLWo5tz9xSyTvCanV/Yo2sczrlbixcF/WOjXZksMA4j6BA5mO9gJmE2MluUQXlgu78LM l0NIwv0DQQhJULK2TUeC8mV0f7mn2j6NGFAx6oDl7eXkhdo86+0h5Q+Vr5BMPxfXZ1Tl 5EPSYNqq84bW/KcnosVptrWSQd5giWUPRYr+0IYNud5l/aPae0zz8ae9420yOYl85O7R SYozdpy4OWLgAqkpdoZUESFS6Z+hbVEnyH7KOtFJXxvb8WAEFd0k1bm+0VYZUuQ2ej51 Diwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zc18si4495716ejb.148.2021.03.12.10.24.47; Fri, 12 Mar 2021 10:25:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233219AbhCLSXY (ORCPT + 99 others); Fri, 12 Mar 2021 13:23:24 -0500 Received: from mga02.intel.com ([134.134.136.20]:36926 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231906AbhCLSXO (ORCPT ); Fri, 12 Mar 2021 13:23:14 -0500 IronPort-SDR: zkA+pTH2tXQx6pTwxX1DIbRiKKm+viqAjvdN1l8eij9DN4HGoAJNWUcbnJNeQN2KRkFFVTYLNU HRHLboI7eaHw== X-IronPort-AV: E=McAfee;i="6000,8403,9921"; a="175999094" X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="175999094" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 10:23:13 -0800 IronPort-SDR: QqSJl6GqR83C0e1V9F0rNWXneiMt4IABHFnIUl5YH3DYsIw/OIfDhsvJtSC6hWb0VEFFffamOJ OdqkXBbqKPpA== X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="377791918" Received: from amiteshs-mobl.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.212.37.30]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 10:23:12 -0800 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto Subject: [PATCH 05/23] ASoC: cx2070x: remove useless assignment Date: Fri, 12 Mar 2021 12:22:28 -0600 Message-Id: <20210312182246.5153-6-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com> References: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cppcheck warning: sound/soc/codecs/cx2072x.c:830:26: style: Variable 'reg1.r.rx_data_one_line' is reassigned a value before the old one has been used. [redundantAssignment] reg1.r.rx_data_one_line = 1; ^ sound/soc/codecs/cx2072x.c:782:26: note: reg1.r.rx_data_one_line is assigned reg1.r.rx_data_one_line = 1; ^ sound/soc/codecs/cx2072x.c:830:26: note: reg1.r.rx_data_one_line is overwritten reg1.r.rx_data_one_line = 1; ^ sound/soc/codecs/cx2072x.c:831:26: style: Variable 'reg1.r.tx_data_one_line' is reassigned a value before the old one has been used. [redundantAssignment] reg1.r.tx_data_one_line = 1; ^ sound/soc/codecs/cx2072x.c:783:26: note: reg1.r.tx_data_one_line is assigned reg1.r.tx_data_one_line = 1; ^ sound/soc/codecs/cx2072x.c:831:26: note: reg1.r.tx_data_one_line is overwritten reg1.r.tx_data_one_line = 1; ^ Likely copy/paste. Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/cx2072x.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/codecs/cx2072x.c b/sound/soc/codecs/cx2072x.c index 8ab22815c2c9..d2d004654c9b 100644 --- a/sound/soc/codecs/cx2072x.c +++ b/sound/soc/codecs/cx2072x.c @@ -827,9 +827,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x) } regdbt2.r.i2s_bclk_invert = is_bclk_inv; - reg1.r.rx_data_one_line = 1; - reg1.r.tx_data_one_line = 1; - /* Configures the BCLK output */ bclk_rate = cx2072x->sample_rate * frame_len; reg5.r.i2s_pcm_clk_div_chan_en = 0; -- 2.25.1