Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1480638pxf; Fri, 12 Mar 2021 10:25:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzgHz0znTBENrUbGfSKTkZmb350O0MrpcxWtvF4nuHYXpahZML1x/TzhKV3pfxb5jnK+psW X-Received: by 2002:a17:906:5607:: with SMTP id f7mr9826328ejq.262.1615573548107; Fri, 12 Mar 2021 10:25:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615573548; cv=none; d=google.com; s=arc-20160816; b=WnGQRnX1LXp/0JqCCKJnM5pdzV8yyfauXgaEKwNlgOTGGWzZH9VDMk08AxxglvvVfJ jxHzcHEzDB0ppZzmlEq9GLaxdRkgty72G6lmm9eHgRTanurc3DrOhjdKciwx3HO1VDCP mfWVZ3gvaQlmCxRePbIVqWPIRNRc9/l3tgl+548VK2dluk6QQhCIlqZtpQoKZ5RDX/3J X6Nq/xN0uc1j2+EOlQjy38cbMYAwq/+dqwFM/58vJWyt3rEln3OXkbGIFrP4oixi/eeT jtxXgQWr6jt0sNJjku7vdvgVKTkWU8wplQuE52F/4HSk7auICwMQ9O7+hecKSCiHUooE vIDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=3iqCckQ/5HTLfDmILu9e0HrluBeEnJRIorL5tT2tBs0=; b=scDs/5XPq9Upn4LqD+1ohKYzBV2vvdY3kyDwkgUW/oQl5Nd3Mhwa8qcYmuPws/qtRV pBCFLL4Y5mFqskp5RHgvgZQbya3OooJkOJ3LsIfm1+s8fZr/28V1Q3GZDg8zGfMzypTb KmQVfTKkY3Wy5eRfIKcN7730rxM4K13cpA5wyZhI3z8e+JBGDmrXUFIzPW6uxNFetSbX s2AA6GhB9hWjaQ1dOfKVYL5Qbdr+uvatboUK5Uv0cuEjewhgc+dz8mY2mLuyJt4DM/hI CbzbCJw7CRsyiR8mfxmsTwN86JntJ5S0IGImjkv5sveTdZO3zcUUTc5wD7LAaRIA7tSC UdlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e17si4677801edy.193.2021.03.12.10.25.25; Fri, 12 Mar 2021 10:25:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233395AbhCLSY2 (ORCPT + 99 others); Fri, 12 Mar 2021 13:24:28 -0500 Received: from mga07.intel.com ([134.134.136.100]:4236 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233265AbhCLSXu (ORCPT ); Fri, 12 Mar 2021 13:23:50 -0500 IronPort-SDR: 7IRRpOqPL/bk7xkx1X1wBRR/PPMYeiziceHm7RarHsuoW5EQzDzmYpxKuwYpg9sq6lLPZC+kvC KlhtWc8Lo+IQ== X-IronPort-AV: E=McAfee;i="6000,8403,9921"; a="252888948" X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="252888948" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 10:23:50 -0800 IronPort-SDR: 54u62mvE4uW4wS6G4ftoPq0ntq/SJ548ytmfzyLNWx9vvVPDlgz+rU4A3yT1CKwqUK2lUUXzUl iKHNULZDCLYg== X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="377792057" Received: from amiteshs-mobl.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.212.37.30]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 10:23:49 -0800 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Dan Murphy , Jonghwan Choi , Peter Ujfalusi , Krzysztof Kozlowski , Kuninori Morimoto Subject: [PATCH 19/23] ASoC: tas2562: remove useless assignment Date: Fri, 12 Mar 2021 12:22:42 -0600 Message-Id: <20210312182246.5153-20-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com> References: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cppcheck throws a warning: sound/soc/codecs/tas2562.c:203:4: style: Assignment of function parameter has no effect outside the function. [uselessAssignmentArg] tx_mask &= ~(1 << right_slot); ^ This assignment seems to come from a copy/paste but the value is indeed not used. Let's remove it. Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/tas2562.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index 19965fabe949..ba23f9f07f04 100644 --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -200,7 +200,6 @@ static int tas2562_set_dai_tdm_slot(struct snd_soc_dai *dai, right_slot = left_slot; } else { right_slot = __ffs(tx_mask); - tx_mask &= ~(1 << right_slot); } } -- 2.25.1