Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1480688pxf; Fri, 12 Mar 2021 10:25:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJzG9kupZw4qN7Kf3leFR1koE8/7Q2e7U9wZDhS+QP4mBV8OseEBgQhtgk1HjN6AkmGuohv0 X-Received: by 2002:a17:906:380b:: with SMTP id v11mr10239812ejc.183.1615573554290; Fri, 12 Mar 2021 10:25:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615573554; cv=none; d=google.com; s=arc-20160816; b=SuxALj9ZIafEvEbXE6SNvdIP/5JZPP8V+LDIe0xj/yifbGAyj9pdpUF2kUGf/OWJ8Y YFOgTOkouadXpCXbqZv1/gmfY3FahDkNkozKl5zuzpTkIsaG5t7ULYp1WgMiSw+s7juH AbMlVwMxgodAI+tS9Dw8bWDaxB86+qxMqFjOAj8dPGB73gKWhS6gBOLCKvKbpR7YL8ug cpIE131Vty/hiXUIoziErxXkB5eE4Eb0KDPyXWrGktyi60CyOf8xhPmBf3p+apQxRnlP Nl5gNgh14h4KiB4+npP0h99+PlyvkJyf2OUK03SRIa+Ze9gecZ/ttg0oStr46UT63Zb9 cTlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=Ol/xPu4uKQEGd349O8SMcTMKLiKkSLnpEhlJweQlsxg=; b=dc5I4n1Ey4go4/Ain+o0OMqZkh8xchv31ulej+nhhFZf7T25t6Q7GNL26THjeXsWqD LagKwNDf30rnojvoJ9J2xbup/LgHEM2WVtxJexRMBPUJdxtDDETNk8nq0uHc3GLRHitT ZKnQI+h0cgMMDBcNjN0PYyDIswZ8dvUIlvYpLhraqVn4AhrscB8ST7HhrgcD7Nnk5yAl bmNBniBx5T9hfQhp0XiHMnT5hsdlQNXs+ObmkPZ/bfQ8lMRd2qwdboTxk+yyea1vkjyh YzX5l9OLWZ9mGaDfsvSDJwGeAhXb50FbIXzETIT0Yg0clqfb9Cn6NsK6+dZ7JwMjfKIh +i+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si4687027eds.169.2021.03.12.10.25.29; Fri, 12 Mar 2021 10:25:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233507AbhCLSYa (ORCPT + 99 others); Fri, 12 Mar 2021 13:24:30 -0500 Received: from mga07.intel.com ([134.134.136.100]:4236 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233298AbhCLSXw (ORCPT ); Fri, 12 Mar 2021 13:23:52 -0500 IronPort-SDR: CKf9roMpF6ilpoeClNXaGYdGVS0YENuiuTtjGLrxGAgsV8P0Qv98C37GFJRxIe8pBcqz3nGLmX 2xuYPOTtFsmg== X-IronPort-AV: E=McAfee;i="6000,8403,9921"; a="252888953" X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="252888953" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 10:23:52 -0800 IronPort-SDR: o8BsyRpU/yc0CdyM5I3L1bh5ATKYgIyYoD4rM7Z3YXWGPwZgTOw+zfGiYLvYsTGC2dYAqXCbBS kcCRuVHdnKnQ== X-IronPort-AV: E=Sophos;i="5.81,244,1610438400"; d="scan'208";a="377792064" Received: from amiteshs-mobl.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.212.37.30]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 10:23:51 -0800 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Dan Murphy , Kuninori Morimoto , Krzysztof Kozlowski , Jonghwan Choi Subject: [PATCH 20/23] ASoC: tas2562: remove warning on return value Date: Fri, 12 Mar 2021 12:22:43 -0600 Message-Id: <20210312182246.5153-21-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com> References: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cppcheck warning: sound/soc/codecs/tas2562.c:530:9: warning: Identical condition and return expression 'ret', return value is always 0 [identicalConditionAfterEarlyExit] return ret; ^ sound/soc/codecs/tas2562.c:525:6: note: If condition 'ret' is true, the function will return/exit if (ret) ^ sound/soc/codecs/tas2562.c:530:9: note: Returning identical expression 'ret' return ret; ^ Fix with return 0 Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/tas2562.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index ba23f9f07f04..10302552195e 100644 --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -526,7 +526,7 @@ static int tas2562_volume_control_put(struct snd_kcontrol *kcontrol, tas2562->volume_lvl = ucontrol->value.integer.value[0]; - return ret; + return 0; } /* Digital Volume Control. From 0 dB to -110 dB in 1 dB steps */ -- 2.25.1