Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <69f51dfe3ad24840ea1ef1f38cfe033f0fc62080.1615411783.git.rgb@redhat.com>
In-Reply-To: <69f51dfe3ad24840ea1ef1f38cfe033f0fc62080.1615411783.git.rgb@redhat.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Fri, 12 Mar 2021 16:38:15 -0500
Message-ID: <CAHC9VhTdD4FVHKDygOZPjvNeHPNGjyoTQ-TzrFHP5xpd9UtSKw@mail.gmail.com>
Subject: Re: [PATCH] MAINTAINERS: update audit files
To:     Richard Guy Briggs <rgb@redhat.com>
Cc:     Linux-Audit Mailing List <linux-audit@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Eric Paris <eparis@parisplace.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 11, 2021 at 11:41 AM Richard Guy Briggs <rgb@redhat.com> wrote:
>
> Add files maintaned by the audit subsystem.
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  MAINTAINERS | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6eff4f720c72..a17532559665 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3015,9 +3015,13 @@ L:       linux-audit@redhat.com (moderated for non-subscribers)
>  S:     Supported
>  W:     https://github.com/linux-audit
>  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git
> +F:     arch/*/*/*audit*.[ch]

That looks like it has about two too many wildcards to hold up over time :)

I understand what you're trying to do here, and while I don't disagree
in principle, I worry that the arch specific paths vary enough that
trying to handle it here is going to be a bit of a mess.

> +F:     arch/x86/include/asm/audit.h

The fact that we need a special entry for the single header under x86
tends to reinforce that.  The other additions make sense, but I think
it may be best to leave the arch specific areas alone for now.

> +F:     include/asm-generic/audit_*.h
>  F:     include/linux/audit.h
>  F:     include/uapi/linux/audit.h
>  F:     kernel/audit*
> +F:     lib/*audit.c
>
>  AUXILIARY DISPLAY DRIVERS
>  M:     Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
> --
> 2.27.0

-- 
paul moore
www.paul-moore.com