Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030472AbWJCTCH (ORCPT ); Tue, 3 Oct 2006 15:02:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030476AbWJCTCH (ORCPT ); Tue, 3 Oct 2006 15:02:07 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:57800 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S1030472AbWJCTCE (ORCPT ); Tue, 3 Oct 2006 15:02:04 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Dave Hansen Cc: vgoyal@in.ibm.com, linux kernel mailing list , Reloc Kernel List , ebiederm@xmission.com, akpm@osdl.org, ak@suse.de, horms@verge.net.au, lace@jankratochvil.net, hpa@zytor.com, magnus.damm@gmail.com, lwang@redhat.com, dzickus@redhat.com, maneesh@in.ibm.com Subject: Re: [PATCH 6/12] i386: CONFIG_PHYSICAL_START cleanup References: <20061003170032.GA30036@in.ibm.com> <20061003171531.GF3164@in.ibm.com> <1159901109.18746.9.camel@localhost.localdomain> Date: Tue, 03 Oct 2006 12:59:21 -0600 In-Reply-To: <1159901109.18746.9.camel@localhost.localdomain> (Dave Hansen's message of "Tue, 03 Oct 2006 11:45:09 -0700") Message-ID: User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 33 Dave Hansen writes: > On Tue, 2006-10-03 at 13:15 -0400, Vivek Goyal wrote: >> diff -puN arch/i386/boot/compressed/misc.c~i386-CONFIG_PHYSICAL_START-cleanup > arch/i386/boot/compressed/misc.c >> --- > linux-2.6.18-git17/arch/i386/boot/compressed/misc.c~i386-CONFIG_PHYSICAL_START-cleanup > 2006-10-02 13:17:58.000000000 -0400 >> +++ linux-2.6.18-git17-root/arch/i386/boot/compressed/misc.c 2006-10-02 > 14:33:44.000000000 -0400 >> @@ -9,11 +9,11 @@ >> * High loaded stuff by Hans Lermen & Werner Almesberger, Feb. 1996 >> */ >> >> +#include >> #include >> #include >> #include > > Isn't config.h implicitly included everywhere by the build system now? > I don't think this is needed. It should be. That is one of the issues I received feedback on, the first round. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/