Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1814362pxf; Fri, 12 Mar 2021 21:43:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJxiRUP2Are15ze02Ko2YeJivclfaXUX8E3mWCGWrAivSiGKuHGXyQS8JFa/5OhKbEem5Qfu X-Received: by 2002:a17:906:684b:: with SMTP id a11mr12023289ejs.329.1615614189415; Fri, 12 Mar 2021 21:43:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615614189; cv=none; d=google.com; s=arc-20160816; b=FQn+4CbHxt+AOcehceXBIulrUpkOAyORdqF1uSq60V2acyqe2qH54JtEVPKdroKUkB Hh5nTUJ9jSKJNbpzk91xQh4HovTTQAu8Yni28aUJmikCVNLfVPZcBZxQNpkFPUzjcv5Q daJpXeNpEGWYgXv5kujF89OxJ4P21RXTWuh2x1Gf/tuhDGKxjrr0nhM85KEIs1nj/mNd nVeBg0AyvxkYUfp8QkNQBQbU4pY/Lj4qKNX3cKNDj+Ahkm5jHT8hRYED62uzzZ3IuBMp A9R4AL0jJ2p19E0l/UajXLwM+wuYoh1mPRUwxi61XYH24p4ti2u6gqCGBj4ghH4HbAlI FSkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=k9JxB+H+3CYGFE+sWWv4hE2XTv5Q5jaRYOuDcz/bFXk=; b=u/VoAwychoT8dEYoLOIHqstvY3BZfuC80cXA2mu4ESKmiHXGd9uDmzBIXUSAWEanbU Ong4OMU1ruAWi0/G7qB0HDdFzxHcfzpzZe42LNVevZJbUNElOt8VS4zwOxEJfev8itTi H28aC1rJ7XeOozrAaihFykctW2D5j1vVAzt8+0zNoEws6SHg2+1dfK9JKg1MvBwfO1Jr TfAvWkezUtfXJIw4NppOn77IDClrC3d4yoQ04jkx+anwqnHg4seuSlzry7v/tvT8m0ud NvzlEIaIqcta5QSlrdioCLwu1UtWiRkloh3479sGIkzav2UwC1KJc/8YgruoxAO0ZVDb b4+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=qPfBoK6o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc7si5791706edb.420.2021.03.12.21.42.47; Fri, 12 Mar 2021 21:43:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=qPfBoK6o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232210AbhCMFbl (ORCPT + 99 others); Sat, 13 Mar 2021 00:31:41 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:12835 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230349AbhCMFbZ (ORCPT ); Sat, 13 Mar 2021 00:31:25 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1615613485; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=k9JxB+H+3CYGFE+sWWv4hE2XTv5Q5jaRYOuDcz/bFXk=; b=qPfBoK6oJLvvvevkSu1zAzRxeja0oOLC2qpBU80o9RjqEaSFn5OvcN6RKNO4Ac5z3/8cOkHl c1EMlVhiOeBKcBEWONsTnvrbLjyFLNpnvHryycuBGcF3q1byJ1uKtzTxTnguP/VK9u5sH7Br AA6DBiP+eZYhp1N9NsykeZojy+c= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 604c4e2b4db3bb68019ed885 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 13 Mar 2021 05:31:23 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 34DDCC43461; Sat, 13 Mar 2021 05:31:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 269D1C433CA; Sat, 13 Mar 2021 05:31:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 269D1C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Jiri Kosina Cc: Luca Coelho , Johannes Berg , Emmanuel Grumbach , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd() References: Date: Sat, 13 Mar 2021 07:31:16 +0200 In-Reply-To: (Jiri Kosina's message of "Sat, 13 Mar 2021 02:44:12 +0100 (CET)") Message-ID: <87h7lfbowr.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Kosina writes: > On Mon, 8 Mar 2021, Jiri Kosina wrote: > >> > From: Jiri Kosina >> > >> > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs >> > disabled (e.g. from LED core). We can't enable BHs in such a situation. >> > >> > Turn the unconditional BH-enable/BH-disable code into >> > hardirq-disable/conditional-enable. >> > >> > This fixes the warning below. >> >> Hi, >> >> friendly ping on this one ... > > Luca, > > Johannes is telling me that he merged this patch internally, but I have no > idea what is happening to it ... ? > > The reported splat is a clear bug, so it should be fixed one way or the > other. Should I take this to wireless-drivers? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches