Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 13 Mar 2021 12:17:34 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Andreas Kemnade <andreas@kemnade.info>, j.neuschaefer@gmx.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Message-ID: <YEyfTrTFzUaXiklf@latitude>
References: <20210308212952.20774-1-andreas@kemnade.info>
 <20210310095545.GC701493@dell>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6xrxmgrtIHvv4b2T"
Content-Disposition: inline
In-Reply-To: <20210310095545.GC701493@dell>
Precedence: bulk


--6xrxmgrtIHvv4b2T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 10, 2021 at 09:55:45AM +0000, Lee Jones wrote:
> On Mon, 08 Mar 2021, Andreas Kemnade wrote:
[...]
> > -static const struct mfd_cell ntxec_subdevices[] =3D {
> > +static const struct mfd_cell ntxec_subdev[] =3D {
> >  	{ .name =3D "ntxec-rtc" },
> >  	{ .name =3D "ntxec-pwm" },
> >  };
> > =20
> > +static const struct mfd_cell ntxec_subdev_pwm[] =3D {
> > +	{ .name =3D "ntxec-pwm" },
> > +};
>=20
> To put across what you're trying to achieve, maybe call this:
>=20
>   ntxec_subdev_no_rtc[]
>=20
> Then if other devices are added, the semantics/intent stays the same
> and it won't have to be renamed.

Andreas, what is the full amount of functionality this version of the EC
can ever provide?

If it's only PWM, I think ntxec_subdev_pwm fits well.

[ The next subdevice that I can foresee is battery monitoring. ]


Sorry for the delay,
Jonathan

--6xrxmgrtIHvv4b2T
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmBMnz0ACgkQCDBEmo7z
X9t+fA//QT5K19ZzN+XVLtv3JzvokDS3hrSV5FhYld62wM1idRN8+sbrgaRN5rQ9
qILNGzDoO33og2AskIgHcCh38Cn2kZGNXgSNEbH2w+QWZhczJ70Wx/D7G5jnzgx5
vxIK4OCeHYIYbUKXJae7G65x9QFTR5nbrDue+EaOjWcfOWTjk4aK4NkjCFLNAspD
kWJSkbWN9Cz4/CDvea2kFL27AWLCBWyjheZOuBb3njRxEybYb5qcWYxubTdwuvOA
GoGy0oPIeQQ0VgS3dezZKFCb6QSfXZIJUkjYz/utxWCttCc+5IErooXZe6Vec+yR
G5ydY/iTDKao8DTntmm8iZfvrpKa5otqDYlX30BwDwNaNTQO+pfVsO/EvfN7fgFA
4z5gbuwUwd66oHpt+qXkDU42uqxcjYw5o25tNYL5gX+KX8D0P1RyUUFJWp822+Ae
aH+6F5mcf/PxY5C9lasJH2cmr/zgLj1aOCWUsra68n3MQYqCjv3sI9FJ5sVTzkyk
tU/RcCgYi8JPYaqqlZqrk74POBFTQMXpNQT6pFJmYKVKCXW9gLxlzsRKd9QDrTdd
PG3A8KKaTssG5VAZSWZ7A+Bxdj6l0Vz5Q6SvBwcG2RJ4mlXp8XM0MrXRxxYa2ePw
SuDGGayWbgXHz7sT1iS/hVcASvMf/37/g7/aJzjka4GxdO61lMM=
=/krD
-----END PGP SIGNATURE-----

--6xrxmgrtIHvv4b2T--