Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 13 Mar 2021 12:25:04 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     j.neuschaefer@gmx.net, lee.jones@linaro.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Message-ID: <YEyhEG96E41Q967E@latitude>
References: <20210313104258.17111-1-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qIRk1fK7k0/AsWzA"
Content-Disposition: inline
In-Reply-To: <20210313104258.17111-1-andreas@kemnade.info>
Precedence: bulk


--qIRk1fK7k0/AsWzA
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 13, 2021 at 11:42:58AM +0100, Andreas Kemnade wrote:
> Add the version of the EC in the Tolino Shine 2 HD
> to the supported versions. It seems not to have an RTC
> and does not ack data written to it.
> The vendor kernel happily ignores write errors, using
> I2C via userspace i2c-set also shows the error.
> So add a quirk to ignore that error.
>=20
> PWM can be successfully configured despite of that error.
>=20
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Reviewed-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
> ---
[...]
> +static const struct mfd_cell ntxec_subdev_no_rtc[] =3D {
> +	{ .name =3D "ntxec-pwm" },
> +};

I left a comment/question about 'no_rtc' vs. 'pwm' in the other thread.


> -	res =3D devm_mfd_add_devices(ec->dev, PLATFORM_DEVID_NONE, ntxec_subdev=
ices,
> -				   ARRAY_SIZE(ntxec_subdevices), NULL, 0, NULL);
> +	res =3D devm_mfd_add_devices(ec->dev, PLATFORM_DEVID_NONE,
> +				   subdevs, n_subdevs,
> +				   NULL, 0, NULL);

The last two lines might as well be one, width-wise.


This version of the patch looks nice and short :)
Jonathan

--qIRk1fK7k0/AsWzA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmBMoRAACgkQCDBEmo7z
X9thuQ//XYAt8vpYkdqpb3K+o3GeLBxUIBK5DHivXk0r7z9uHuoYzKOUX8wUcYkB
tNxrujKJe8YQhE0ItoBYQqPTOXslEMKC4UELPbhLBqYC3+IqKpti7oXDGd0z2Pjd
GYr3f61bQQ1hLlBIn2tWL20L+0daoVyifMAucgvZ8zKUvBvteCAmLcSkekLhnkZl
75bb2vAOSEI+iRuP/OT6IufFo3ZsBqtyOP/tiV5JVWQppw8bXnDRNfqz0F2Qsn0M
2TmXrw9gmeYXupzgIsGME9W/OmEEQp3ujddMF98deFxuFBibPu4HPlSb9RFEeyyi
Jntu6QT/Jwap4hJMpVwF/p1fM3V4IP34QDI87h6iBqFyX08rO3mRqwqSAoimlkKB
q9NuXkPO5bK+Qk2hxcBsSYk4jPfsp3ISTFbbJm1tigCjgu0bUmqvQriQ/CcI9/aS
2d8oW816wxhufTLKkdo/MSz8LrVB4lH36fUEFfOlyBpJzw4BqurkV1xeo7GOMbEP
s+B8ys2mD+kPmL+KsAKYuUJxJeGrkQve9DhYWKbxaX+x+2b//N0IkwN566LthKnI
klt5vRU+qqBjnN614FQs7Jp6BEFb+B0RzSjQNBbi0dOW8d10o66/RdJZDz81kvj7
JBFcLYVaYAkH5tr59z/0MocjmzGLkr3A+saMGjEP0XeRUXphCSc=
=0T1u
-----END PGP SIGNATURE-----

--qIRk1fK7k0/AsWzA--