Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 13 Mar 2021 16:07:57 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= <j.neuschaefer@gmx.net>
Cc:     Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Message-ID: <20210313160757.084d74d0@aktux>
In-Reply-To: <YEyfTrTFzUaXiklf@latitude>
References: <20210308212952.20774-1-andreas@kemnade.info>
        <20210310095545.GC701493@dell>
        <YEyfTrTFzUaXiklf@latitude>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, 13 Mar 2021 12:17:34 +0100
Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net> wrote:

> On Wed, Mar 10, 2021 at 09:55:45AM +0000, Lee Jones wrote:
> > On Mon, 08 Mar 2021, Andreas Kemnade wrote: =20
> [...]
> > > -static const struct mfd_cell ntxec_subdevices[] =3D {
> > > +static const struct mfd_cell ntxec_subdev[] =3D {
> > >  	{ .name =3D "ntxec-rtc" },
> > >  	{ .name =3D "ntxec-pwm" },
> > >  };
> > > =20
> > > +static const struct mfd_cell ntxec_subdev_pwm[] =3D {
> > > +	{ .name =3D "ntxec-pwm" },
> > > +}; =20
> >=20
> > To put across what you're trying to achieve, maybe call this:
> >=20
> >   ntxec_subdev_no_rtc[]
> >=20
> > Then if other devices are added, the semantics/intent stays the same
> > and it won't have to be renamed. =20
>=20
> Andreas, what is the full amount of functionality this version of the EC
> can ever provide?
>=20
> If it's only PWM, I think ntxec_subdev_pwm fits well.
>=20
I think it is only PWM. At least I could not see any other I2C access.

> [ The next subdevice that I can foresee is battery monitoring. ]
>=20
That is done via the RC5T619 on that device.

Regards,
Andreas