Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jay Vosburgh <jay.vosburgh@canonical.com>
To:     Jianlin Lv <Jianlin.Lv@arm.com>
cc:     vfalico@gmail.com, andy@greyhouse.net, davem@davemloft.net,
        kuba@kernel.org, iecedge@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] bonding: Added -ENODEV interpret for slaves option
In-reply-to: <20210313140210.3940183-1-Jianlin.Lv@arm.com>
References: <20210313140210.3940183-1-Jianlin.Lv@arm.com>
Comments: In-reply-to Jianlin Lv <Jianlin.Lv@arm.com>
   message dated "Sat, 13 Mar 2021 22:02:10 +0800."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6675.1615665036.1@famine>
Content-Transfer-Encoding: 8BIT
Date:   Sat, 13 Mar 2021 11:50:36 -0800
Message-ID: <6676.1615665036@famine>
Precedence: bulk

Jianlin Lv <Jianlin.Lv@arm.com> wrote:

>After upgrading the kernel, the slave interface name is changed,
>Systemd cannot use the original configuration to create bond interface,
>thereby losing the connection with the host.
>
>Adding log for ENODEV will make it easier to find out such problem lies.

	To be clear, this specifically affects add/remove of interfaces
to/from the bond via the "slaves" sysfs interface.

	Please update your log to better describe this (that it affects
the sysfs API only) and resubmit.

	I'm sympathetic to the problem this is trying to solve, and the
message shouldn't spam the kernel log particularly, but the commit log
needs to more clearly describe what the problem is and how it's being
fixed.

	Thanks,

	-J

>Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
>---
> drivers/net/bonding/bond_options.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
>index 77d7c38bd435..c9d3604ae129 100644
>--- a/drivers/net/bonding/bond_options.c
>+++ b/drivers/net/bonding/bond_options.c
>@@ -640,6 +640,15 @@ static void bond_opt_error_interpret(struct bonding *bond,
> 		netdev_err(bond->dev, "option %s: unable to set because the bond device is up\n",
> 			   opt->name);
> 		break;
>+	case -ENODEV:
>+		if (val && val->string) {
>+			p = strchr(val->string, '\n');
>+			if (p)
>+				*p = '\0';
>+			netdev_err(bond->dev, "option %s: interface %s does not exist!\n",
>+				   opt->name, val->string);
>+		}
>+		break;
> 	default:
> 		break;
> 	}
>-- 
>2.25.1
>

---
	-Jay Vosburgh, jay.vosburgh@canonical.com