Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20210313054654.11693-2-srivasam@codeaurora.org>
References: <20210313054654.11693-1-srivasam@codeaurora.org> <20210313054654.11693-2-srivasam@codeaurora.org>
Subject: Re: [PATCH v6 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     Ajit Pandey <ajitp@codeaurora.org>,
        V Sujith Kumar Reddy <vsujithk@codeaurora.org>,
        Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To:     Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
        agross@kernel.org, bjorn.andersson@linaro.org,
        devicetree@vger.kernel.org, dianders@chromium.org,
        judyhsiao@chromium.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        rohitkr@codeaurora.org, srinivas.kandagatla@linaro.org
Date:   Sat, 13 Mar 2021 12:56:35 -0800
Message-ID: <161566899554.1478170.1265435102634351195@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Srinivasa Rao Mandadapu (2021-03-12 21:46:53)
> From: Ajit Pandey <ajitp@codeaurora.org>
>=20
> Add dai link for supporting lpass I2S driver, which is used
> for audio capture and playback.
> Add lpass-cpu node with  pin controls and i2s primary

Why two spaces before 'pin'?

> and secondary dai-links

Please end sentence with a period.

>=20
> Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 58 ++++++++++++++++++++
>  1 file changed, 58 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/bo=
ot/dts/qcom/sc7180-trogdor.dtsi
> index 436582279dad..3a24383247db 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -283,6 +284,42 @@ keyboard_backlight: keyboard-backlight {
>                         max-brightness =3D <1023>;
>                 };
>         };
> +
> +       sound: sound {
> +               compatible =3D "google,sc7180-trogdor";
> +               model =3D "sc7180-rt5682-max98357a-1mic";
> +
> +               audio-routing =3D
> +                       "Headphone Jack", "HPOL",
> +                       "Headphone Jack", "HPOR";
> +
> +               #address-cells =3D <1>;
> +               #size-cells =3D <0>;
> +
> +               dai-link@0 {
> +                       link-name =3D "MultiMedia0";
> +                       reg =3D <MI2S_PRIMARY>;
> +                       cpu {
> +                               sound-dai =3D <&lpass_cpu MI2S_PRIMARY>;
> +                       };
> +
> +                       sound_multimedia0_codec: codec {
> +                               sound-dai =3D <&alc5682 0 /*aif1*/>;

Nitpick, add a space for comment

                               sound-dai =3D <&alc5682 0 /* aif1 */>;

> +                       };
> +               };
> +
> +               dai-link@1 {
> +                       link-name =3D "MultiMedia1";
> +                       reg =3D <MI2S_SECONDARY>;
> +                       cpu {
> +                               sound-dai =3D <&lpass_cpu MI2S_SECONDARY>;
> +                       };
> +
> +                       sound_multimedia1_codec: codec {
> +                               sound-dai =3D <&max98357a>;
> +                       };
> +               };
> +       };
>  };
> =20
>  &qfprom {
> @@ -720,6 +757,27 @@ &ipa {
>         modem-init;
>  };
> =20
> +&lpass_cpu {
> +       status =3D "okay";
> +
> +       pinctrl-names =3D "default";
> +       pinctrl-0 =3D <&sec_mi2s_active &pri_mi2s_active &pri_mi2s_mclk_a=
ctive>;

Super nitpick: I prefer this style

	pinctrl-0 =3D <&sec_mi2s_active>, <&pri_mi2s_active>, <&pri_mi2s_mclk_acti=
ve>;

It's effectively the same but the brackets help us see that these are
the end of the phandle specifier instead of having to figure out that
the first phandle isn't specifying the second phandle as an argument.

> +
> +       #address-cells =3D <1>;
> +       #size-cells =3D <0>;
> +
> +       mi2s-primary@0 {

Should the node name just be mi2s instead of mi2s-primary? We have reg
property so I think 'mi2s' should be sufficient to differentiate.

> +               reg =3D <MI2S_PRIMARY>;
> +               qcom,playback-sd-lines =3D <1>;
> +               qcom,capture-sd-lines =3D <0>;
> +       };
> +
> +       mi2s-secondary@1 {
> +               reg =3D <MI2S_SECONDARY>;
> +               qcom,playback-sd-lines =3D <0>;
> +       };
> +};
> +
>  &mdp {
>         status =3D "okay";
>  };