Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2248714pxf; Sat, 13 Mar 2021 13:04:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJzfNaTrfrI28JI6I3AqM3ED4ZYeMuW4A8Wlw6+hge/6NN9Kgh/0zLil40wsCi1W0Ox0KLYl X-Received: by 2002:a17:906:5e4a:: with SMTP id b10mr15681184eju.116.1615669443049; Sat, 13 Mar 2021 13:04:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615669443; cv=none; d=google.com; s=arc-20160816; b=x6egV5xJ6wFMB73n4JPMN/4FUglIWJY/X0+GnmQNlP4j6wPJSV4YiXCXPr02b6PUpg H2N9RgY/zJ5ZjL2psIIyzjTqsBI1eCAYtbvPW5XfHHa9gccd3S7sduw3x998pUlig2b7 qN49sSA6zBa5+//DrUOsKcy+EDVfb+qe2Y1zAeFFEYjH8YYr6Mqy+QvYTYOaR/53458w xK708zwHFoTIiZMkIXSmeY4Ok143GIG4VABJbZa2vDYwJ4EXOqe5GO6MsvUobeDUJcTI uhjiSLxrDM1mOmAqaue7pelPJrBcMIqKRuxNNmrNcfMWKnckZWkZW4GbM8TWk7g5K3bj vMzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=Prh/GvLlCXahiqAWMZ5suVERYpG5btIIgSbUFPcodtc=; b=VElh+7VKL9iGCQZ0johyftPDvpu/D4Ws+zNGNO+is3ruJ99zhugWv23TuPIS8oGYAm 3ZlIeb3kwOceJHFg5hFke6zYqxAOVFaVgfJ0aqzNtO6QJtRqRmrYixfHsdCBNqqW7pOu mwyFPN/eJU8sxT3qQNi+JSp0uMLIK6dVIrlFn9kznlmw6F9MAnQAa30/ffyBbAMC5+yY tm99sbqWfOjoYU6QV9adIj8aSI23UfDTYBvcj5p7iry9UxOare2fPxYW/ww63c96fz0R wyD6KHG19Xa1a1BY5d2K4QJBcp7Pu/R3mL7NebMWuVmT41T4+Ul7B8fchQ5PCm52dUEv eFTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PPgTBXoH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y9si7580236edp.151.2021.03.13.13.03.40; Sat, 13 Mar 2021 13:04:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PPgTBXoH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234735AbhCMVAA (ORCPT + 99 others); Sat, 13 Mar 2021 16:00:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:41432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234593AbhCMU7v (ORCPT ); Sat, 13 Mar 2021 15:59:51 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D728C64ECE; Sat, 13 Mar 2021 20:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615669191; bh=Prh/GvLlCXahiqAWMZ5suVERYpG5btIIgSbUFPcodtc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=PPgTBXoHCyaxPOsdFe1ja617sL9z3o/8j7RV1LBDWPKQ6DTMsiHGzlKlwOYvauN8b 5gcTiYGkavqvWI8h1kJ52n3CC20ma1eb4rihbtLupNxu3iVWrKvAca5NKbkd5Y+Jq7 UrCz/0+/Y56VwLorgCKTDtjlsBp/nnbbFwgMfsdW37mToFKiR9D9iCLy7/WbD+lff8 56OmJthmcMU1eScTA/si38mIrUwOeHcVPcXg0LR04+rL93uYwq2aWM8HG83rEmyWW6 PEBfYRjvtzgoUAQlkYJYAzzpq5p53i2TPnoNg3eCVF5MxIz9tx9Wri8U8wDZV8cp9m IUlv4W3JubjZQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210302234106.3418665-1-marijn.suijten@somainline.org> References: <20210302234106.3418665-1-marijn.suijten@somainline.org> Subject: Re: [PATCH] clk: qcom: rcg2: Rectify clk_gfx3d rate rounding without mux division From: Stephen Boyd Cc: ~postmarketos/upstreaming@lists.sr.ht, angelogioacchino.delregno@somainline.org, konrad.dybcio@somainline.org, martin.botka@somainline.org, Marijn Suijten , Andy Gross , Bjorn Andersson , Michael Turquette , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Marijn Suijten , phone-devel@vger.kernel.org Date: Sat, 13 Mar 2021 12:59:49 -0800 Message-ID: <161566918965.1478170.7122514783960594682@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marijn Suijten (2021-03-02 15:41:06) > In case the mux is not divided parent_req was mistakenly not assigned to > leading __clk_determine_rate to determine the best frequency setting for > a requested rate of 0, resulting in the msm8996 platform not booting. > Rectify this by refactoring the logic to unconditionally assign to > parent_req.rate with the clock rate the caller is expecting. >=20 > Fixes: 7cbb78a99db6 ("clk: qcom: rcg2: Stop hardcoding gfx3d pingpong par= ent numbers") > Reported-by: Konrad Dybcio > Tested-by: Konrad Dybcio > Reviewed-By: AngeloGioacchino Del Regno > Signed-off-by: Marijn Suijten > --- Applied to clk-fixes