Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20210313034112.eqa7zxtes2ruklqj@pallavi>
References: <20210313034112.eqa7zxtes2ruklqj@pallavi>
Subject: Re: [PATCH] clk: clk.c: Fixed statics initialized to 0
From:   Stephen Boyd <sboyd@kernel.org>
To:     Pallavi Prabhu <rpallaviprabhu@gmail.com>,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        mturquette@baylibre.com
Date:   Sat, 13 Mar 2021 13:06:14 -0800
Message-ID: <161566957437.1478170.3351022111021245800@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Pallavi Prabhu (2021-03-12 19:41:12)
> Uninitialized static variable from 0, as statics get auto-initialized to =
0 during execution.
> Signed-off-by: Pallavi Prabhu <rpallaviprabhu@gmail.com>

Need a newline between signed-off-by line and commit text. Also please
wrap the commit text at 80 or 78 characters or so.

> ---
>  drivers/clk/clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 5052541a0986..763ad2c960bd 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2931,7 +2931,7 @@ EXPORT_SYMBOL_GPL(clk_is_match);
>  #include <linux/debugfs.h>
> =20
>  static struct dentry *rootdir;
> -static int inited =3D 0;
> +static int inited;

I think it's being explicit; although it is the same. Is this noticed by
some static checker or something? I'd like to ignore this patch if
possible.

>  static DEFINE_MUTEX(clk_debug_lock);
>  static HLIST_HEAD(clk_debug_list);
>