Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <87tupl30kl.fsf@igel.home> <04a7e801-9a55-c926-34ad-3a7665077a4e@microchip.com>
 <87y2euu6lf.fsf@igel.home>
In-Reply-To: <87y2euu6lf.fsf@igel.home>
From:   Emil Renner Berthing <emil.renner.berthing@gmail.com>
Date:   Sat, 13 Mar 2021 22:54:02 +0100
Message-ID: <CANBLGcyteTgQ2BgyesrTycpVqpPeYaiUCTEEp=KmPB0TPqK_LQ@mail.gmail.com>
Subject: Re: macb broken on HiFive Unleashed
To:     Andreas Schwab <schwab@linux-m68k.org>
Cc:     Claudiu.Beznea@microchip.com,
        linux-riscv <linux-riscv@lists.infradead.org>,
        ckeepax@opensource.cirrus.com, andrew@lunn.ch,
        Willy Tarreau <w@1wt.eu>,
        Nicolas Ferre <Nicolas.Ferre@microchip.com>, daniel@0x0f.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        pthombar@cadence.com, Network Development <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Andreas

On Wed, 10 Mar 2021 at 20:55, Andreas Schwab <schwab@linux-m68k.org> wrote:
> On M=C3=A4r 09 2021, Claudiu.Beznea@microchip.com wrote:
> > I don't have a SiFive HiFive Unleashed to investigate this. Can you che=
ck
> > if reverting commits on macb driver b/w 5.10 and 5.11 solves your issue=
s:
> >
> > git log --oneline v5.10..v5.11 -- drivers/net/ethernet/cadence/
> > 1d0d561ad1d7 net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag
> > 1d608d2e0d51 Revert "macb: support the two tx descriptors on at91rm9200=
"
> > 700d566e8171 net: macb: add support for sama7g5 emac interface
> > ec771de654e4 net: macb: add support for sama7g5 gem interface
> > f4de93f03ed8 net: macb: unprepare clocks in case of failure
> > 38493da4e6a8 net: macb: add function to disable all macb clocks
> > daafa1d33cc9 net: macb: add capability to not set the clock rate
> > edac63861db7 net: macb: add userio bits as platform configuration
> > 9e6cad531c9d net: macb: Fix passing zero to 'PTR_ERR'
> > 0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config metho=
d
> > e4e143e26ce8 net: macb: add support for high speed interface
>
> Unfortunately, that didn't help.

Sorry, for being late to test this, but I just compiled and booted
5.11.6 and ethernet works just fine for me:
https://esmil.dk/hfu-5.11.6.txt

As you can see I haven't updated OpenSBI or u-boot in a while, don't
know if that makes a difference. You can fetch the config is used
here:
https://esmil.dk/hfu-5.11.6.config

/Emil