Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1615621683-2122-1-git-send-email-wangqing@vivo.com>
In-Reply-To: <1615621683-2122-1-git-send-email-wangqing@vivo.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Sun, 14 Mar 2021 09:42:34 +0800
Message-ID: <CAAOTY__77A5ckALr=dxXK4zV3sbm_84_m9Bo0nBKBxPMMv2sxQ@mail.gmail.com>
Subject: Re: [PATCH] gpu: drm: mediatek: delete redundant printing of return value
To:     Wang Qing <wangqing@vivo.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Wang:

Wang Qing <wangqing@vivo.com> =E6=96=BC 2021=E5=B9=B43=E6=9C=8813=E6=97=A5 =
=E9=80=B1=E5=85=AD =E4=B8=8B=E5=8D=883:48=E5=AF=AB=E9=81=93=EF=BC=9A
>
> platform_get_irq() has already checked and printed the return value,
> the printing here is nothing special, it is not necessary at all.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/=
log/?h=3Dmediatek-drm-next

Regards,
Chun-Kuang.

>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediate=
k/mtk_dpi.c
> index b05f900..0ac4962
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -751,10 +751,8 @@ static int mtk_dpi_probe(struct platform_device *pde=
v)
>         }
>
>         dpi->irq =3D platform_get_irq(pdev, 0);
> -       if (dpi->irq <=3D 0) {
> -               dev_err(dev, "Failed to get irq: %d\n", dpi->irq);
> +       if (dpi->irq <=3D 0)
>                 return -EINVAL;
> -       }
>
>         ret =3D drm_of_find_panel_or_bridge(dev->of_node, 0, 0,
>                                           NULL, &dpi->next_bridge);
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel