From: Arnd Bergmann <arnd@arndb.de>
To: Linas Vepstas <linas@austin.ibm.com>
Subject: Re: [PATCH 1/4]: Spidernet stop queue when queue is full
Date: Wed, 4 Oct 2006 00:19:42 +0200
User-Agent: KMail/1.9.4
Cc: akpm@osdl.org, jeff@garzik.org, netdev@vger.kernel.org,
       James K Lewis <jklewis@us.ibm.com>, linux-kernel@vger.kernel.org,
       linuxppc-dev@ozlabs.org
References: <20061003205240.GE4381@austin.ibm.com> <20061003205729.GF4381@austin.ibm.com>
In-Reply-To: <20061003205729.GF4381@austin.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200610040019.43028.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 996
Lines: 29

On Tuesday 03 October 2006 22:57, Linas Vepstas wrote:
> +???????if ((chain->head->next == chain->tail->prev) ||
> +??????? ? (spider_net_get_descr_status(descr) != SPIDER_NET_DESCR_NOT_IN_USE)) {
> ????????????????result = NETDEV_TX_LOCKED;
> ????????????????goto out;
> ????????}

...

> ?out:
> -???????netif_wake_queue(netdev);
> +???????card->netdev_stats.tx_dropped++;
> +???????netif_stop_queue(netdev);
> ????????return result;
> ?}

Hmm, this looks a little strange to me. I would assume that we should not
stop the queue when the device is locked, but only when it is busy.

I would assume though that the fix is to return NETDEV_TX_BUSY instead
of NETDEV_TX_LOCKED in the case above, while the netif_stop_queue()
is correct here.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/