Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 14 Mar 2021 14:31:01 -0700 (PDT)
Message-Id: <20210314.143101.1456394019713348728.davem@davemloft.net>
To:     vladimir.oltean@nxp.com
Cc:     jakub@cloudflare.com, alobakin@pm.me, kuba@kernel.org,
        ast@kernel.org, andriin@fb.com, dcaratti@redhat.com,
        gnault@redhat.com, wenxu@ucloud.cn, eranbe@nvidia.com,
        mcroce@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20210314204449.6ogfogeiqfwwqfso@skbuf>
References: <20210312200834.370667-1-alobakin@pm.me>
        <87wnu932qz.fsf@cloudflare.com>
        <20210314204449.6ogfogeiqfwwqfso@skbuf>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: Sun, 14 Mar 2021 20:44:49 +0000

> On Sun, Mar 14, 2021 at 09:21:40PM +0100, Jakub Sitnicki wrote:
>> On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote:
>> 
>> Smells like a breaking change for existing consumers of this value.
>> 
>> How about we change the type of flow_dissector_key_icmp{}.id to __be16
>> instead to make sparse happy?
> 
> The struct flow_dissector_key_icmp::id only appears to be used in
> bond_xmit_hash, and there, the exact value doesn't seem to matter.
> 
> This appears to be a real bug and not just to appease sparse:
> ih->un.echo.id has one endianness and "1" has another. Both cannot
> be correct.

Agreed, so I will apply this, thanks.