Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: /htU0sR2WskbsACLvmL9wPOxKceUcAVtJpdZAtKBb8JGz73usCdsyP2bny/uoBcVCf7/NvncAg
 u3y0VffW7GaA==
IronPort-SDR: qiRYHTeyZJR7NNbv0bBzWEpKYT2uQJMAMugrpDkwcuexGTShOrbDwqh8zaQk/w57fJeu3S08Fw
 v0TZ00EqNidw==
Subject: Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size
 mismatch
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     kernel test robot <lkp@intel.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        kbuild-all@lists.01.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20210311130328.2859337-1-oberpar@linux.ibm.com>
 <202103120329.VU4uJ0yZ-lkp@intel.com>
 <CAHk-=whmwEJ-4tGamqOCw4BDJ-yjYrLRYxaFq5YurVc-XXO+hg@mail.gmail.com>
 <db88186a-d6af-33c9-f1fb-10b673b8fdd6@intel.com>
 <CAHk-=wji=we4HQ2m6Z=fnUSM4UW8+X0eTnb9YPGYdcTqpVAL2Q@mail.gmail.com>
From:   Rong Chen <rong.a.chen@intel.com>
Message-ID: <09373c3d-73e8-933a-24ad-5c4ba4fdc615@intel.com>
Date:   Mon, 15 Mar 2021 10:31:49 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAHk-=wji=we4HQ2m6Z=fnUSM4UW8+X0eTnb9YPGYdcTqpVAL2Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 3/13/21 1:52 AM, Linus Torvalds wrote:
> On Thu, Mar 11, 2021 at 7:50 PM Rong Chen <rong.a.chen@intel.com> wrote:
>>
>> The issue is from a=!, and [ "$a $b" = ".size .LPBX0," ] can avoid the
>> error.
>>
>> + [ ! = .size -a ABI = .LPBX0, ]
>> ./kernel/gcov/geninfosize.sh: 13: [: =: unexpected operator
> But that's not what the patch did.
>
> The patch used quotes around $a, so "$a" should still be fine.
>
> See:
>
>     [torvalds@ryzen ~]$ a="!" [ "$a" = ".size" ]
>
> is fine, but
>
>     [torvalds@ryzen ~]$ a="!" [ $a = ".size" ]
>     -bash: [: =: unary operator expected
>
> and the patch I saw, and that the test robot replied to, had that
> correct quoting, afaik.
>
> So I still don't see what the test robot is complaining about. Was
> there an earlier version of the patch without the quotes that I didn't
> see?
>
> Or is the shell on the test robot doing something really really odd,
> and it's somehow nds32-specific?
>
>                  Linus

Hi Linus,

It can be reproduced with '-a' option in dash:

     $ a="!"
     $ [ "$a" = ".size" ]
     $ [ "$a" = ".size" -a "$b" = ".LPBX0," ]
     sh: 2: [: =: unexpected operator

and there is a advice for the option at 
https://wiki.ubuntu.com/DashAsBinSh, I'm not sure it's the best practice 
or not.

     While dash supports most uses of the -a and -o options, they have 
very confusing semantics even in bash and are best avoided. Commands 
like the following:
         [ \( "$foo" = "$bar" -a -f /bin/baz \) -o ! -x /bin/quux ]
     should be replaced with:
         (([ "$foo" = "$bar" ] && [ -f /bin/baz ]) || [ ! -x /bin/quux ])

Best Regards,
Rong Chen