Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Swapnil Kashinath Jakhade <sjakhade@cadence.com>
To:     Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Lokesh Vutla <lokeshvutla@ti.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v6 02/13] phy: ti: j721e-wiz: Invoke wiz_init() before
 of_platform_device_create()
Thread-Topic: [PATCH v6 02/13] phy: ti: j721e-wiz: Invoke wiz_init() before
 of_platform_device_create()
Thread-Index: AQHXFcSB69/wViqcVUq4MNab63JkLap/7Zug
Date:   Mon, 15 Mar 2021 05:47:17 +0000
Message-ID: <MN2PR07MB6160046609B94969CAC0EB17C56C9@MN2PR07MB6160.namprd07.prod.outlook.com>
References: <20210310154558.32078-1-kishon@ti.com>
 <20210310154558.32078-3-kishon@ti.com>
In-Reply-To: <20210310154558.32078-3-kishon@ti.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 141f63c5-732e-423c-19e4-08d8e775cae7
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2021 05:47:17.3468
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Yk1g4Byp6mbEzVq0UNj9625uFWDLhn7GTTtasGoEprdwG/ZyaQVdpNO8q+2m/QVGNAPK3w5Dd35HiCdQQDB3MtRZdis5UVGaYmROsLT+Dy4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR07MB8258
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-15_01:2021-03-15,2021-03-15 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 adultscore=0
 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1011
 lowpriorityscore=0 malwarescore=0 spamscore=0 suspectscore=0
 impostorscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103150039
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Kishon Vijay Abraham I <kishon@ti.com>
> Sent: Wednesday, March 10, 2021 9:16 PM
> To: Kishon Vijay Abraham I <kishon@ti.com>; Vinod Koul
> <vkoul@kernel.org>; Rob Herring <robh+dt@kernel.org>; Philipp Zabel
> <p.zabel@pengutronix.de>; Swapnil Kashinath Jakhade
> <sjakhade@cadence.com>
> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Lokesh Vutl=
a
> <lokeshvutla@ti.com>; stable@vger.kernel.org
> Subject: [PATCH v6 02/13] phy: ti: j721e-wiz: Invoke wiz_init() before
> of_platform_device_create()
>=20
> EXTERNAL MAIL
>=20
>=20
> Invoke wiz_init() before configuring anything else in Sierra/Torrent
> (invoked as part of of_platform_device_create()). wiz_init() resets the
> SERDES device and any configuration done in the probe() of
> Sierra/Torrent will be lost. In order to prevent SERDES configuration
> from getting reset, invoke wiz_init() immediately before invoking
> of_platform_device_create().
>=20
> Fixes: 091876cc355d ("phy: ti: j721e-wiz: Add support for WIZ module
> present in TI J721E SoC")
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: <stable@vger.kernel.org> # v5.10
> ---
>  drivers/phy/ti/phy-j721e-wiz.c | 17 +++++++----------
>  1 file changed, 7 insertions(+), 10 deletions(-)
>=20

Reviewed-by: Swapnil Jakhade <sjakhade@cadence.com>

Thanks & regards,
Swapnil

> diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wi=
z.c
> index 995c7dbec77b..1bb73822f44a 100644
> --- a/drivers/phy/ti/phy-j721e-wiz.c
> +++ b/drivers/phy/ti/phy-j721e-wiz.c
> @@ -1262,27 +1262,24 @@ static int wiz_probe(struct platform_device
> *pdev)
>  		goto err_get_sync;
>  	}
>=20
> +	ret =3D wiz_init(wiz);
> +	if (ret) {
> +		dev_err(dev, "WIZ initialization failed\n");
> +		goto err_wiz_init;
> +	}
> +
>  	serdes_pdev =3D of_platform_device_create(child_node, NULL, dev);
>  	if (!serdes_pdev) {
>  		dev_WARN(dev, "Unable to create SERDES platform
> device\n");
>  		ret =3D -ENOMEM;
> -		goto err_pdev_create;
> -	}
> -	wiz->serdes_pdev =3D serdes_pdev;
> -
> -	ret =3D wiz_init(wiz);
> -	if (ret) {
> -		dev_err(dev, "WIZ initialization failed\n");
>  		goto err_wiz_init;
>  	}
> +	wiz->serdes_pdev =3D serdes_pdev;
>=20
>  	of_node_put(child_node);
>  	return 0;
>=20
>  err_wiz_init:
> -	of_platform_device_destroy(&serdes_pdev->dev, NULL);
> -
> -err_pdev_create:
>  	wiz_clock_cleanup(wiz, node);
>=20
>  err_get_sync:
> --
> 2.17.1