Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <53cd571332cd7e941589a25c284fc9e28c69725f.camel@fi.rohmeurope.com>
Subject: Re: [PATCH 2/3] regulator: bd9571mwv: Fix regulator name printed
 on registration failure
From:   Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reply-To: matti.vaittinen@fi.rohmeurope.com
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Marek Vasut <marek.vasut+renesas@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>
Cc:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
In-Reply-To: <20210312130242.3390038-3-geert+renesas@glider.be>
References: <20210312130242.3390038-1-geert+renesas@glider.be>
         <20210312130242.3390038-3-geert+renesas@glider.be>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date:   Mon, 15 Mar 2021 07:49:32 +0200
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Fri, 2021-03-12 at 14:02 +0100, Geert Uytterhoeven wrote:
> If a regulator fails to register, the driver prints an error message
> like:
> 
>     bd9571mwv-regulator bd9571mwv-regulator.6.auto: failed to
> register bd9571mwv-regulator regulator
> 
> However, the platform device's name is already printed as part of
> dev_err(), and does not allow the user to distinguish among the
> various
> regulators that are part of the PMIC.
> 
> Fix this by printing regulator_desc.name instead, to change the
> message
> like:
> 
>     bd9571mwv-regulator bd9571mwv-regulator.6.auto: failed to
> register DVFS regulator
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>