Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Swapnil Kashinath Jakhade <sjakhade@cadence.com>
To:     Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Lokesh Vutla <lokeshvutla@ti.com>
Subject: RE: [PATCH v6 03/13] phy: cadence: cadence-sierra: Create PHY only
 for "phy" or "link" sub-nodes
Thread-Topic: [PATCH v6 03/13] phy: cadence: cadence-sierra: Create PHY only
 for "phy" or "link" sub-nodes
Thread-Index: AQHXFcSDWYhUizFLY0OWp/kzgnrN0Kp/8pQg
Date:   Mon, 15 Mar 2021 05:50:04 +0000
Message-ID: <MN2PR07MB6160EAB28F3A60B2E7582672C56C9@MN2PR07MB6160.namprd07.prod.outlook.com>
References: <20210310154558.32078-1-kishon@ti.com>
 <20210310154558.32078-4-kishon@ti.com>
In-Reply-To: <20210310154558.32078-4-kishon@ti.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 021b08fc-aeb6-473b-fb82-08d8e7762ea9
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2021 05:50:04.3746
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5MaDot+hGj6Oq2yWwQNeMesBmjD3AQQw82qfZmc0O86jQphpXvrF3cPTlF9LTDNEfZ2gRq6mL+6cEK+Y+4oiertqrngzfmBxAKCz75DUCM8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR07MB8258
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-15_01:2021-03-15,2021-03-15 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 phishscore=0
 mlxlogscore=999 priorityscore=1501 bulkscore=0 impostorscore=0 spamscore=0
 adultscore=0 malwarescore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2103150040
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Kishon Vijay Abraham I <kishon@ti.com>
> Sent: Wednesday, March 10, 2021 9:16 PM
> To: Kishon Vijay Abraham I <kishon@ti.com>; Vinod Koul
> <vkoul@kernel.org>; Rob Herring <robh+dt@kernel.org>; Philipp Zabel
> <p.zabel@pengutronix.de>; Swapnil Kashinath Jakhade
> <sjakhade@cadence.com>
> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Lokesh Vutl=
a
> <lokeshvutla@ti.com>
> Subject: [PATCH v6 03/13] phy: cadence: cadence-sierra: Create PHY only f=
or
> "phy" or "link" sub-nodes
>=20

Nitpick, subject line in all Sierra patches in the series could be uniform.
Maybe, phy: cadence: Sierra as per earlier commits.

Reviewed-by: Swapnil Jakhade <sjakhade@cadence.com>

Thanks & regards,
Swapnil

> EXTERNAL MAIL
>=20
>=20
> Cadence Sierra PHY driver registers PHY using devm_phy_create()
> for all sub-nodes of Sierra device tree node. However Sierra device
> tree node can have sub-nodes for the various clocks in addtion to the
> PHY. Use devm_phy_create() only for nodes with name "phy" (or "link"
> for old device tree) which represent the actual PHY.
>=20
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/phy/cadence/phy-cadence-sierra.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c
> b/drivers/phy/cadence/phy-cadence-sierra.c
> index 19f32ae877b9..f7ba0ed416bc 100644
> --- a/drivers/phy/cadence/phy-cadence-sierra.c
> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
> @@ -577,6 +577,10 @@ static int cdns_sierra_phy_probe(struct
> platform_device *pdev)
>  	for_each_available_child_of_node(dn, child) {
>  		struct phy *gphy;
>=20
> +		if (!(of_node_name_eq(child, "phy") ||
> +		      of_node_name_eq(child, "link")))
> +			continue;
> +
>  		sp->phys[node].lnk_rst =3D
>  			of_reset_control_array_get_exclusive(child);
>=20
> --
> 2.17.1