Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3095026pxf; Mon, 15 Mar 2021 00:51:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw66Fjgs++W7mus9Xyz4so1ZU5Fay6S40KloiKRSkN03Orh8Gh9tYN0xmBpgp80VkMNrZco X-Received: by 2002:a17:907:d10:: with SMTP id gn16mr11327243ejc.304.1615794680865; Mon, 15 Mar 2021 00:51:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615794680; cv=none; d=google.com; s=arc-20160816; b=NeJne1HxOkbDv/4iB0BKe4M4PkaVkjwU22kdnkUde6JlpJTf7FtuxhOy8LgCSM5ico onrfE0IWd5APwe0ggd9K4XSh0bM6EANG0rluZguC6BapwKexrgzEaF5ihuhF2AiXSzlR On3wD3vj3QOUS4VhjjHWjIi0Zgk8QNxyoNLpKp0ooPll68+a25Me/DMQhvDU3KE0BeEV MAoeATRNIWlGPAk9a1YYJlsVAcgyiLxXW3jSFCH/bLNGBCTq0Lcr3Xm/ZU2yTfF8H7id XQbESUAN/QQEphVGsAPCVmcceQuiKBl4y6npEVcqYaOJYmBlfJwmLrMor/jomvoFxnw7 mdAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date; bh=Ymvrdu5pjGcrbro+0wZb3juzzfB9KpIr+IOkrsUyXeQ=; b=ejQMqT1WAkGfvVa3Bw5ssJp7u8IVu2xOfeZJ2t3nc9gPWM/QrZYB0tQdvhltVVEtyH 2simzeO03OJVTWBLMCUM7TQyAhiFBoLaHF9423bL1Z3WHu3mRDzibFzEK2f8rnb/BJ3S Zi/kORTNhVk+FvYAOpKNHghatOKwhGVH3lDJgnniXAPq3siBWKDAi6TXWwX7R5Yw9ZPA wjBQt7WEn7C+zQI2mS3FqSSQNssP/uq9jC6TESHNS7woYE7EhTV0+D12uff8NCUWEwyu g4U2p95phFy5bQxSED4qyfOjzi2haZEiezJDTUyxiYcsdiN1Fgtudy13tH1L/alaqG9J gy5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si10833283ejv.67.2021.03.15.00.50.58; Mon, 15 Mar 2021 00:51:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbhCOHuG (ORCPT + 99 others); Mon, 15 Mar 2021 03:50:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:44310 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbhCOHt5 (ORCPT ); Mon, 15 Mar 2021 03:49:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5CB30ABD7; Mon, 15 Mar 2021 07:49:56 +0000 (UTC) Date: Mon, 15 Mar 2021 08:49:56 +0100 Message-ID: From: Takashi Iwai To: Vitaly Rodionov Cc: Jaroslav Kysela , Takashi Iwai , , , , Stefan Binding Subject: Re: [PATCH v1 4/4] ALSA: hda/cirrus: Make CS8409 driver more generic by using fixups. In-Reply-To: <20210313113410.90088-5-vitalyr@opensource.cirrus.com> References: <20210313113410.90088-1-vitalyr@opensource.cirrus.com> <20210313113410.90088-5-vitalyr@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Mar 2021 12:34:10 +0100, Vitaly Rodionov wrote: > @@ -1357,6 +1362,22 @@ static const struct hda_verb cs8409_cs42l42_init_verbs[] = { > { 0x47, AC_VERB_SET_PROC_COEF, 0x0080 }, /* I2C mode */ > { 0x47, AC_VERB_SET_COEF_INDEX, 0x005b }, /* Set I2C bus speed */ > { 0x47, AC_VERB_SET_PROC_COEF, 0x0200 }, /* 100kHz I2C_STO = 2 */ > + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0xF0 }, /* Widget node ASP-1-TX */ > + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x20 }, > + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0x21 }, > + { 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x04 }, > + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0x50 }, /* Widget node ASP-1-RX0 */ > + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x20 }, > + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0xa1 }, > + { 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x04 }, > + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0xF0 }, /* Widget node ASP-2-TX */ > + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x00 }, > + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0x10 }, > + { 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x90 }, > + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0x90 }, /* Widget node DMIC-1 */ > + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x00 }, > + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0xA0 }, > + { 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x90 }, Those widgets are all pin widgets, right? If so, setting via the pincfg table would be more suitable, as it's cached and exposed via sysfs for debugging. thanks, Takashi