Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] vhost: Fix vhost_vq_reset()
To:     Laurent Vivier <lvivier@redhat.com>, linux-kernel@vger.kernel.org
Cc:     virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        "Michael S. Tsirkin" <mst@redhat.com>, kvm@vger.kernel.org
References: <20210312140913.788592-1-lvivier@redhat.com>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <7bb4ee1a-d204-eb94-792f-ca250dacacea@redhat.com>
Date:   Mon, 15 Mar 2021 16:31:11 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210312140913.788592-1-lvivier@redhat.com>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


?? 2021/3/12 ????10:09, Laurent Vivier д??:
> vhost_reset_is_le() is vhost_init_is_le(), and in the case of
> cross-endian legacy, vhost_init_is_le() depends on vq->user_be.
>
> vq->user_be is set by vhost_disable_cross_endian().
>
> But in vhost_vq_reset(), we have:
>
>      vhost_reset_is_le(vq);
>      vhost_disable_cross_endian(vq);
>
> And so user_be is used before being set.
>
> To fix that, reverse the lines order as there is no other dependency
> between them.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>


Acked-by: Jason Wang <jasowang@redhat.com>


> ---
>   drivers/vhost/vhost.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index a262e12c6dc2..5ccb0705beae 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -332,8 +332,8 @@ static void vhost_vq_reset(struct vhost_dev *dev,
>   	vq->error_ctx = NULL;
>   	vq->kick = NULL;
>   	vq->log_ctx = NULL;
> -	vhost_reset_is_le(vq);
>   	vhost_disable_cross_endian(vq);
> +	vhost_reset_is_le(vq);
>   	vq->busyloop_timeout = 0;
>   	vq->umem = NULL;
>   	vq->iotlb = NULL;