Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] powerpc: define the variable 'uaccess_flush' as static
To:     "heying (H)" <heying24@huawei.com>,
        =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>,
        mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
        npiggin@gmail.com, dja@axtens.net, akpm@linux-foundation.org,
        rppt@kernel.org, aneesh.kumar@linux.ibm.com
Cc:     johnny.chenyi@huawei.com, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
References: <20210312110638.178974-1-heying24@huawei.com>
 <a06a0dc8-c717-da4c-c5ad-eaf56bbbd896@kaod.org>
 <2c7bf6e0-d950-c728-bfe9-2db99a4d18a9@huawei.com>
From:   Christophe Leroy <christophe.leroy@csgroup.eu>
Message-ID: <c522ca02-4053-3e3d-f25e-2c1482c5a8bd@csgroup.eu>
Date:   Mon, 15 Mar 2021 10:16:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <2c7bf6e0-d950-c728-bfe9-2db99a4d18a9@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Precedence: bulk


Le 15/03/2021 à 07:51, heying (H) a écrit :
> 
>> I think this is the case also for entry_flush. compiling with W=1 will tell you more.
> 
> When I use these commands:
> 
> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> make C=2 arch/powerpc/kernel/setup_64.o ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> 
> I find warnings as followings:
> 
> arch/powerpc/kernel/setup_64.c:422:6: warning: symbol 'panic_smp_self_stop' was not declared. Should 
> it be static?
> arch/powerpc/kernel/setup_64.c:951:6: warning: symbol 'rfi_flush' was not declared. Should it be static?
> arch/powerpc/kernel/setup_64.c:952:6: warning: symbol 'entry_flush' was not declared. Should it be 
> static?
> arch/powerpc/kernel/setup_64.c:953:6: warning: symbol 'uaccess_flush' was not declared. Should it be 
> static?
> 
> When I use the command "make W=1 arch/powerpc/kernel/setup_64.o ARCH=powerpc 
> CROSS_COMPILE=powerpc64-linux-gnu-", warning becomes this:
> 
> arch/powerpc/kernel/setup_64.c:422:6: warning: no previous prototype for ‘panic_smp_self_stop’ 
> [-Wmissing-prototypes]
>   void panic_smp_self_stop(void)
>        ^~~~~~~~~~~~~~~~~~~
> 
> My sparse tool is the latest one with the version "v0.6.3". So, should I fix all the warnings 
> reported by sparse?

I think W=1 will only report missing function prototypes.

sparse also reports missing variables prototypes so that's better. All should be fixed.

Christophe