Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3166805pxf; Mon, 15 Mar 2021 03:18:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGL1ANXXOkyJUSY5btpUM6PdoZ2XVRd+BvTtsbg+HsXAvvAOne6lPAiN7upJv2x46kX05w X-Received: by 2002:a05:6402:1157:: with SMTP id g23mr28989543edw.303.1615803516378; Mon, 15 Mar 2021 03:18:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615803516; cv=none; d=google.com; s=arc-20160816; b=qiJi9rfMrcfOv5Exx6Rdfaul+81lHyr3fgjBpWHYw49qvE5wTfopZdZKHc7d4/V8kQ 3+dC+Ro78T5cb+yGW02O6vvTa9ubTed0WAahC7G743q8B0mFYvdMDpyjD3uVXxdjQuru oHSrIqE9h9hSmP333qlkLUlno4yMH4pN8RL5SBgJsvzK+qy4gKMf1km6yVmV1EffA8sM jjp4sP77O6PJBsdxz73EIpOcyqHLntUmOZO1Mx2lSRiOy+10WDEbkldoMm1H/82yctwp ORmPwv2uVFGoWc4htMdQpVgdIPUKwLnjUlf8MYHh8T+IB06XF2SdpvWhbfR1UgTUnHK7 EpCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=58hGSBX7H8nGOBRskBWyk16Oz7UBORL1R+Y5nIDeG8I=; b=0HkleyhMGGhD7xkRp+UCedN5wmd2T1fpGmbleUqjRMSq1KxU/XZ4jhssftb46JMwY5 azP3/vGEw0KLS65b/yQgT/CUcRHH7T1C71+aUULwlT1pTV6aW4XCkWVPIJ/N9+kK+q4m QCyJnzQhElEGz2p9zoVPQdSm9y2vWCwnfvanRiJFYT/y2+RLg8sYbBYnsOswiBU7H8g+ CFULLJZDPEa1NherdKp32cJXBFGkMyxq5LXxeOCE+be6BAisZs/YvT17xcl5W/Tpzlet Tp07L8MyNqjN46c/xE3i6fSSucJrf02FsFylIfImPjb52oYSC7YV77g0Se/HLqnIkM+B ODpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=l+16VG6p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c8si10219182edq.326.2021.03.15.03.18.14; Mon, 15 Mar 2021 03:18:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=l+16VG6p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbhCOKRS (ORCPT + 99 others); Mon, 15 Mar 2021 06:17:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229964AbhCOKQv (ORCPT ); Mon, 15 Mar 2021 06:16:51 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61325C061574 for ; Mon, 15 Mar 2021 03:16:51 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id g20so7770161wmk.3 for ; Mon, 15 Mar 2021 03:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=58hGSBX7H8nGOBRskBWyk16Oz7UBORL1R+Y5nIDeG8I=; b=l+16VG6p0qdrMsxf2YNawvIlC9jdxD2LN3IKbdk2wdjI71Hhpc5ek30tdiao0bsfF3 6m8Lc4MYyy6P4m5pn2exxc6ZzkRk2sEpSVUVTaMJM12CsYU34DamkegIskhw87xR1Xhr oqiwJdEUm9hNqqZdrVEv5HoL7KXZwih6jQPixKP3xco4Bp89lSoHtS+O/U34vexZaQvJ 2X35wz5STY9JmDvf4GpABg+AOmVVgWZx4xkVYp3+iFxFL6/EWSOycOSn0l3oSEqXLthc 0HjwwUPmm7qvIxM9ULzLdJG9q+lGhwxfTxFmKJy1D+9XFkUxK+1m7QwfZg3sAvl3At+u 5ocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=58hGSBX7H8nGOBRskBWyk16Oz7UBORL1R+Y5nIDeG8I=; b=OZNBs7xx/I/ikrc88C28kPcLcW/do2nqXCvSIADHhMaG9owkUbIyrPGtX6Jgn6mLDQ 7dUqPmZbreaD9/O82/uz4ANk5DidA/n2nenxhX+o1n/cvJzUvo9qgdAnXNQa317vYV/q Xo8/asthb3gCvQWHE544c6b6Uq3ZF7GkxH8b9QLvkCCFVyXmXEM4fRB/ZsGBeZxIa6hQ 1/OmPlhmj+mnwnJc1Iq6sPaunS1nS2P/oL78EDV4MUmYFGr0e6WNjZu1a9TAGj/oKqgs sfxbN2+horbzjsl1GTPOCi3IXVC7kxbBg+FEHKATiWEYLGaiMXKxYQrErKpDtWN6Vuaz X68g== X-Gm-Message-State: AOAM530F/z4Hg6TpA24Ziyca45QQoaEQDDd4M1WolUPfy48OLC5FpXzs aN+Sj1XAZafFTCBZMQarZTk= X-Received: by 2002:a1c:2288:: with SMTP id i130mr25239574wmi.62.1615803410083; Mon, 15 Mar 2021 03:16:50 -0700 (PDT) Received: from agape.jhs ([5.171.72.229]) by smtp.gmail.com with ESMTPSA id z2sm17815581wrv.47.2021.03.15.03.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 03:16:49 -0700 (PDT) Date: Mon, 15 Mar 2021 11:16:47 +0100 From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_CHECK_BT_HANG Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org remove conditional code blocks checked by unused CONFIG_CHECK_BT_HANG cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 31 ------------------- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 7 ----- .../staging/rtl8723bs/include/rtl8723b_hal.h | 7 ----- 3 files changed, 45 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 9f059fb78c7d..5854590e5811 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -4421,34 +4421,3 @@ void rtl8723b_stop_thread(struct adapter *padapter) } #endif } - -#if defined(CONFIG_CHECK_BT_HANG) -extern void check_bt_status_work(void *data); -void rtl8723bs_init_checkbthang_workqueue(struct adapter *adapter) -{ - adapter->priv_checkbt_wq = alloc_workqueue("sdio_wq", 0, 0); - INIT_DELAYED_WORK(&adapter->checkbt_work, (void *)check_bt_status_work); -} - -void rtl8723bs_free_checkbthang_workqueue(struct adapter *adapter) -{ - if (adapter->priv_checkbt_wq) { - cancel_delayed_work_sync(&adapter->checkbt_work); - flush_workqueue(adapter->priv_checkbt_wq); - destroy_workqueue(adapter->priv_checkbt_wq); - adapter->priv_checkbt_wq = NULL; - } -} - -void rtl8723bs_cancle_checkbthang_workqueue(struct adapter *adapter) -{ - if (adapter->priv_checkbt_wq) - cancel_delayed_work_sync(&adapter->checkbt_work); -} - -void rtl8723bs_hal_check_bt_hang(struct adapter *adapter) -{ - if (adapter->priv_checkbt_wq) - queue_delayed_work(adapter->priv_checkbt_wq, &(adapter->checkbt_work), 0); -} -#endif diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index d0e5b482f382..82b54131c9ec 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -1420,11 +1420,4 @@ void rtl8723bs_set_hal_ops(struct adapter *padapter) pHalFunc->hal_xmit = &rtl8723bs_hal_xmit; pHalFunc->mgnt_xmit = &rtl8723bs_mgnt_xmit; pHalFunc->hal_xmitframe_enqueue = &rtl8723bs_hal_xmitframe_enqueue; - -#if defined(CONFIG_CHECK_BT_HANG) - pHalFunc->hal_init_checkbthang_workqueue = &rtl8723bs_init_checkbthang_workqueue; - pHalFunc->hal_free_checkbthang_workqueue = &rtl8723bs_free_checkbthang_workqueue; - pHalFunc->hal_cancle_checkbthang_workqueue = &rtl8723bs_cancle_checkbthang_workqueue; - pHalFunc->hal_checke_bt_hang = &rtl8723bs_hal_check_bt_hang; -#endif } diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h index 0f787ec44b5b..6449238fb2a5 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h @@ -240,13 +240,6 @@ void _8051Reset8723(struct adapter *padapter); void rtl8723b_start_thread(struct adapter *padapter); void rtl8723b_stop_thread(struct adapter *padapter); -#if defined(CONFIG_CHECK_BT_HANG) -void rtl8723bs_init_checkbthang_workqueue(struct adapter *adapter); -void rtl8723bs_free_checkbthang_workqueue(struct adapter *adapter); -void rtl8723bs_cancle_checkbthang_workqueue(struct adapter *adapter); -void rtl8723bs_hal_check_bt_hang(struct adapter *adapter); -#endif - int FirmwareDownloadBT(struct adapter *adapter, struct rt_firmware *firmware); void CCX_FwC2HTxRpt_8723b(struct adapter *padapter, u8 *pdata, u8 len); -- 2.20.1