Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Mar 2021 13:28:25 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     j.neuschaefer@gmx.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Message-ID: <20210315132819.0970d493@aktux>
In-Reply-To: <20210315081231.GX701493@dell>
References: <20210313104258.17111-1-andreas@kemnade.info>
        <20210315081231.GX701493@dell>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 15 Mar 2021 08:12:31 +0000
Lee Jones <lee.jones@linaro.org> wrote:

[...]
> >  static int ntxec_probe(struct i2c_client *client)
> >  {
> >  	struct ntxec *ec;
> >  	unsigned int version;
> >  	int res;
> > +	const struct mfd_cell *subdevs = ntxec_subdev;
> > +	size_t n_subdevs = ARRAY_SIZE(ntxec_subdev);  
> 
> This is a little confusing.  I had to re-read to figure it out.
> 
> In my mind, it would be clearer to explicitly set these in the
> switch, rather than have a default which can be over-written.
> 
yes, it is clearer. I was just afraid that your compiler cannot
figure it out that things get initialized and getting comments like
"This code has never seen a compiler."
But I will throw it against several ones.

Regards,
Andreas