Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3311025pxf; Mon, 15 Mar 2021 06:55:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+rNo9rA/fQcykoq0eAjZKQU6NsIrd0YquZpxanNbPl66mCWDzyDhTWzLU2H0kfegha/4z X-Received: by 2002:a17:906:4f02:: with SMTP id t2mr23623806eju.121.1615816527604; Mon, 15 Mar 2021 06:55:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615816527; cv=none; d=google.com; s=arc-20160816; b=BmSc7bcF4bWOsPqvc7EXQRjhDepABhjHmmJZm75cKZA2qS6tz4txFqghK8Cr9S7Axm iU/lpRHxCUKGo5D4iOyUoluPFFE5YHR+3o+dFiaVu39VhAs6Isufk79DlNyrdH9HHT/n OJwSvPlY3poOwhO8JLAg0KJ1G4fz33RShbnnkYLYrPea17B97vXAlKcNwqefpDGrgXD8 tzcocshn25HHd+OzuUmmb1cHtMCuCqB7P+mGOTXpvRWDThdxjmukGiKTpZQQUbAhIXo9 KWaP6Oyjbq20g4rcg9sKjC7GbswAcq/YTaD5ulNG8On01i/ctUwm5mdcE2i2b9a52eS2 CBGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3Az8NuogOkJZ7NU/opluoH+O3rgrTgId54iqSfsbHKg=; b=zWXgvqrs7J4eJpL5Sc2tT3sfqSZoD5BbEA1jfqbkX/tRCVWTuXifAhkIYB2Qo7RC4C VWaVEqT7Ga7Bdloyj8PQOyZM5nNANStQYNHEvuKn/HWL0pJ18IaLjh22Bq1QLnd/NT6a znQsicbpbSyWaSIJ+/H1eADX/BahEbnT7AKEjKStxdyD77pQS6LxUTnoguvT9HeO/0iw rMf/0VT/KYGH0Vk3LNvfs1whJi1B5AqKNjxE17mvFBe1Ygd77pfT3oHBfKTlcFrvVxu0 HdISQ0CvP3syqzHgBXw1ccIo55CcgjHDBR5Yh+kfKfvS/6+1IFmriBZDRR6du7gRJQEE 7m2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LQriiOvV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg2si10414832edb.136.2021.03.15.06.55.04; Mon, 15 Mar 2021 06:55:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LQriiOvV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231209AbhCONyO (ORCPT + 99 others); Mon, 15 Mar 2021 09:54:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:55758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbhCONxO (ORCPT ); Mon, 15 Mar 2021 09:53:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3928964EEC; Mon, 15 Mar 2021 13:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816394; bh=dMn7XsKtA1xK+QI9+vobxM8LkEqT1GfUZUUKSTSHkMU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LQriiOvVDmxj3fG9O93wYf9otBkYtyRcBb0kNVSXIZkaFrxKJ1sTTjuedxwXOFy7v Tu0iBl9/KpYW7T9Dybdgw+4BnMMpsWeKNwxXWB9YJQG57SOsg0jgF/sS00wi+Cv5d9 4lSpzusxY26NPTXDmSlxxq4ilLwvdhbcm7gw+nHY= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Ulf Hansson , Sasha Levin Subject: [PATCH 4.4 19/75] mmc: mxs-mmc: Fix a resource leak in an error handling path in mxs_mmc_probe() Date: Mon, 15 Mar 2021 14:51:33 +0100 Message-Id: <20210315135208.881886983@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135208.252034256@linuxfoundation.org> References: <20210315135208.252034256@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Christophe JAILLET [ Upstream commit 0bb7e560f821c7770973a94e346654c4bdccd42c ] If 'mmc_of_parse()' fails, we must undo the previous 'dma_request_chan()' call. Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/20201208203527.49262-1-christophe.jaillet@wanadoo.fr Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/mxs-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index c8b8ac66ff7e..687fd68fbbcd 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -651,7 +651,7 @@ static int mxs_mmc_probe(struct platform_device *pdev) ret = mmc_of_parse(mmc); if (ret) - goto out_clk_disable; + goto out_free_dma; mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34; -- 2.30.1