Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3324275pxf; Mon, 15 Mar 2021 07:09:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyV1EViMhDf6APMImvc03G5WCeg00o0uHOIDplyo14oSA0tiGqlpW/OxgBRGSNOoAgnOFn X-Received: by 2002:a17:906:8583:: with SMTP id v3mr24116243ejx.361.1615817367854; Mon, 15 Mar 2021 07:09:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615817367; cv=none; d=google.com; s=arc-20160816; b=SMRfeC0V00KGFnlKkVyPn0p655eNly2MCM1J6Vz23MUPIRPf9sxPHYIYsN8J50IGNS bI/GtUWSoctyFkcMVeSIh8Bu8XBrc2muBVK99g2GNS3NNT11mu6gkwVFrmLlOpYqu273 PeyVnUcLs6E1+nfRnnWGupGq/kPALGrGeS/G8PwtZ7wYyu+NzaiAu7IkZaIBo1Wa/fv1 xJO0/hZzN8Hz4SzOr6DYU3slxkvju+XzkYq67B8iAKVp0wgJOQh/ooAGHh3eE1ge5rak sktn2KiSXu9HIqoX0TAvjRk6ur3U0VLikBSfQBmWXRXSMo3hbSX6mPtb8O64fZ7hLPWi PwlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Xk5/l/yabEmFXHEn2uPhKcs7xDRuU++wU9Zz+THgHuw=; b=wy3jhPeTGvRiBkezuzKiwm66qwwhw/TpeYImURkSmKsOILxGiTLgiiMoE15L6fReXK zp0nqP7EzYeSgFoqTWvtOtLZ8pSRuTnVV3D6X/Tyi2FFXiR1QqvjUL470Nas0UUKLMLa 1SLF3utZMJr2Zo/qqqRmHJRPHKsGiNhWboGFeGEhK7Uq1xErXkTqknEzMZhRTlupOJyb GClB8Spv82vuUnuoHGgtUOu6iHA1Gi8XV2xoKNHHu/WLY+dbZmqzPKNAu/lbyk92b980 3Bkku85ymQzO3a2SOKPxgtfltPI5gvTTYY5WqT4SSZMhfiM5GNV3qLcsM4UMaPRqQYLs yF4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OhYQ4ZUG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y59si12645022ede.77.2021.03.15.07.09.04; Mon, 15 Mar 2021 07:09:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OhYQ4ZUG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235320AbhCOOH3 (ORCPT + 99 others); Mon, 15 Mar 2021 10:07:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:35904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232176AbhCON5y (ORCPT ); Mon, 15 Mar 2021 09:57:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 80FC264F46; Mon, 15 Mar 2021 13:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816673; bh=NA7KxTzMwB/3fc+2h+6SWGrMvXG17Xc0AhBUCDyRlew=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OhYQ4ZUG6hYfkFCVQM6TasYGt0iyDQ4Vj3AABy0FzoVy0GjUWmxHoyrrd0CL5E4Kq x/JR6HShI3yCDJVbYsORztX8PE0aCGOn8TZPsfuIkJTeVdn6Z+vqcRd/BhQfkAkuDv XNnuh5Go5d1eGwOdsSq7QndJrbdYBiL8rIqJFNdQ= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joakim Zhang , Jakub Kicinski Subject: [PATCH 5.4 039/168] net: stmmac: stop each tx channel independently Date: Mon, 15 Mar 2021 14:54:31 +0100 Message-Id: <20210315135551.631141231@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135550.333963635@linuxfoundation.org> References: <20210315135550.333963635@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Joakim Zhang commit a3e860a83397bf761ec1128a3f0ba186445992c6 upstream. If clear GMAC_CONFIG_TE bit, it would stop all tx channels, but users may only want to stop specific tx channel. Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") Signed-off-by: Joakim Zhang Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c @@ -60,10 +60,6 @@ void dwmac4_dma_stop_tx(void __iomem *io value &= ~DMA_CONTROL_ST; writel(value, ioaddr + DMA_CHAN_TX_CONTROL(chan)); - - value = readl(ioaddr + GMAC_CONFIG); - value &= ~GMAC_CONFIG_TE; - writel(value, ioaddr + GMAC_CONFIG); } void dwmac4_dma_start_rx(void __iomem *ioaddr, u32 chan)