Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3343335pxf; Mon, 15 Mar 2021 07:34:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLU20tQiWJCli6Pf47pvw9K/bhFiDQq7e7J1DlVhcAGvxiQ2hdk8Zyvu3Ebe0RGH9Fm5EL X-Received: by 2002:a05:6402:168c:: with SMTP id a12mr30734365edv.344.1615818880470; Mon, 15 Mar 2021 07:34:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615818880; cv=none; d=google.com; s=arc-20160816; b=uP2gkk1dV/2Wg4yzXJnBP82sBGGA/eOvht5Rf3uMtMvFmyEMznjK8+f0te1rFWra+V 3BAV83gdgeU2DqnOTwp0lz4e9lWA62+UjM4mCBRBLtpf+PJOmvTW8qRADhzjKSSMKCHr TIjJGTYuLek299jS4kHldF/RjPcWqYYV2BdVwrdLuZmbt8fm7OwLw8/K7HQEwPXsDYsN yzQrZimF/P6ijRI9h935HOyWu7J/j3cRbVf6fOAVavEuEsxehpmFYdjy/W8tQInnN2jm FdBpHb47nYL5fP4KpCT6YsEQa9HsLNJwevCA5u/EFmQgvcVoBzfKcLdu4KaAebyXeLm6 OK7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EHxk+8u/1K2BLLnmQifyJXoOZ7gXHMmn3xEAyD0j1ek=; b=PyTCe95z4p9h4Hxu1XTtmR0PRSLTxx0KwQ8oeTYwTqY2auLv2fZzJWdeD0BqWAbgi/ 8RRtNEuIpNXIOHAb/qnTZalN0UC1xQlAbfHBRu8zd0z+vZF0gVjwO/C9UiIHg/CbivpT T9IHjwHxTCwKJBLaLAyXMt/sE5tXRoTGzxKDlubNsE6eohKulp0qRSmuUemI+RwzF+VM 0t4zN1YwrYuqCxe3KrVRDs7WFMOoVbU4684NBWIOrwLS0GshPFJ/n+hmgrJnpO4F1iQ3 OT2aX8hZ+Myo/96+wY5ioZwANlTw5+klQS0jqep+gKV/UYxgEudRPwd1YPZIUXZvMnUM iCXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EIUrx9dc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v25si11615340ejw.423.2021.03.15.07.34.17; Mon, 15 Mar 2021 07:34:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EIUrx9dc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239529AbhCOOcj (ORCPT + 99 others); Mon, 15 Mar 2021 10:32:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:37612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233163AbhCOOA4 (ORCPT ); Mon, 15 Mar 2021 10:00:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FF4A64F2A; Mon, 15 Mar 2021 14:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816833; bh=9bj6SCD5EJuiL7/Owysds0FsYr2HYAQQYLveL93WhDU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EIUrx9dcyn5NsNjJPXL+6lU5qFLziz9Cag9MfoFo3cT2Ws0rUJo5k53LbaRIo+X3/ Fjk7bzripak++KqaeFCC1zK1VrMHRzsfwS0YfJ4zA/LTZc/PMtJ77ccnLEocwp4C8e rimiHreMTC4kf788NwmyxzJUcGXbq/eE7Yl4AKNA= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kernel test robot , Oliver OHalloran , Michael Ellerman , Sasha Levin Subject: [PATCH 5.10 140/290] powerpc/pci: Add ppc_md.discover_phbs() Date: Mon, 15 Mar 2021 14:53:53 +0100 Message-Id: <20210315135546.648228562@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135541.921894249@linuxfoundation.org> References: <20210315135541.921894249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Oliver O'Halloran [ Upstream commit 5537fcb319d016ce387f818dd774179bc03217f5 ] On many powerpc platforms the discovery and initalisation of pci_controllers (PHBs) happens inside of setup_arch(). This is very early in boot (pre-initcalls) and means that we're initialising the PHB long before many basic kernel services (slab allocator, debugfs, a real ioremap) are available. On PowerNV this causes an additional problem since we map the PHB registers with ioremap(). As of commit d538aadc2718 ("powerpc/ioremap: warn on early use of ioremap()") a warning is printed because we're using the "incorrect" API to setup and MMIO mapping in searly boot. The kernel does provide early_ioremap(), but that is not intended to create long-lived MMIO mappings and a seperate warning is printed by generic code if early_ioremap() mappings are "leaked." This is all fixable with dumb hacks like using early_ioremap() to setup the initial mapping then replacing it with a real ioremap later on in boot, but it does raise the question: Why the hell are we setting up the PHB's this early in boot? The old and wise claim it's due to "hysterical rasins." Aside from amused grapes there doesn't appear to be any real reason to maintain the current behaviour. Already most of the newer embedded platforms perform PHB discovery in an arch_initcall and between the end of setup_arch() and the start of initcalls none of the generic kernel code does anything PCI related. On powerpc scanning PHBs occurs in a subsys_initcall so it should be possible to move the PHB discovery to a core, postcore or arch initcall. This patch adds the ppc_md.discover_phbs hook and a core_initcall stub that calls it. The core_initcalls are the earliest to be called so this will any possibly issues with dependency between initcalls. This isn't just an academic issue either since on pseries and PowerNV EEH init occurs in an arch_initcall and depends on the pci_controllers being available, similarly the creation of pci_dns occurs at core_initcall_sync (i.e. between core and postcore initcalls). These problems need to be addressed seperately. Reported-by: kernel test robot Signed-off-by: Oliver O'Halloran [mpe: Make discover_phbs() static] Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20201103043523.916109-1-oohall@gmail.com Signed-off-by: Sasha Levin --- arch/powerpc/include/asm/machdep.h | 3 +++ arch/powerpc/kernel/pci-common.c | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm/machdep.h index 475687f24f4a..d319160d790c 100644 --- a/arch/powerpc/include/asm/machdep.h +++ b/arch/powerpc/include/asm/machdep.h @@ -59,6 +59,9 @@ struct machdep_calls { int (*pcibios_root_bridge_prepare)(struct pci_host_bridge *bridge); + /* finds all the pci_controllers present at boot */ + void (*discover_phbs)(void); + /* To setup PHBs when using automatic OF platform driver for PCI */ int (*pci_setup_phb)(struct pci_controller *host); diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c index be108616a721..7920559a1ca8 100644 --- a/arch/powerpc/kernel/pci-common.c +++ b/arch/powerpc/kernel/pci-common.c @@ -1625,3 +1625,13 @@ static void fixup_hide_host_resource_fsl(struct pci_dev *dev) } DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MOTOROLA, PCI_ANY_ID, fixup_hide_host_resource_fsl); DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, fixup_hide_host_resource_fsl); + + +static int __init discover_phbs(void) +{ + if (ppc_md.discover_phbs) + ppc_md.discover_phbs(); + + return 0; +} +core_initcall(discover_phbs); -- 2.30.1