Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <fb1bb7be6fad2dfb4bb3d311fddb39b13966311d.camel@perches.com>
Subject: Re: [PATCH v2 5/5] mtd: spi-nor: swp: Drop 'else' after 'return'
From:   Joe Perches <joe@perches.com>
To:     Tudor.Ambarus@microchip.com, p.yadav@ti.com
Cc:     vigneshr@ti.com, michael@walle.cc, linux-mtd@lists.infradead.org,
        miquel.raynal@bootlin.com, richard@nod.at,
        linux-kernel@vger.kernel.org
Date:   Mon, 15 Mar 2021 07:43:01 -0700
In-Reply-To: <3ed8da81-55cc-4fbc-cb01-9405ac9709d7@microchip.com>
References: <20210306095002.22983-1-tudor.ambarus@microchip.com>
         <20210306095002.22983-6-tudor.ambarus@microchip.com>
         <20210308062821.wn4uqfxcg6vo3gcb@ti.com>
         <5723fabcc03455ee6624a7d223186e5fad2bf2e9.camel@perches.com>
         <3ed8da81-55cc-4fbc-cb01-9405ac9709d7@microchip.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-03-15 at 11:24 +0000, Tudor.Ambarus@microchip.com wrote:
> On 3/15/21 8:53 AM, Joe Perches wrote:
> > On Mon, 2021-03-08 at 11:58 +0530, Pratyush Yadav wrote:
> > > On 06/03/21 11:50AM, Tudor Ambarus wrote:
> > > > else is not generally useful after a break or return.
> > > > 
> > > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> > > 
> > > Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> > > 
> > 
> > I don't think this improves the code.
> > 
> > Generally, checkpatch is a stupid little script.
> > 
> > This code uses a form like:
> > ????????if (foo)
> > ????????????????return bar;
> > ????????else
> > ????????????????return baz;
> 
> Isn't else redundant? What are the benefits of keeping the else?

Visual consistency and it's a widely used style.

A long time ago Al Viro wrote:

https://lore.kernel.org/lkml/20140925032215.GK7996@ZenIV.linux.org.uk/

which resulted in the patch to checkpatch that tries to ignore that style.

https://lore.kernel.org/lkml/1411621434.4026.9.camel@joe-AO725/

> > I think better would be to change the code to use temporaries
> > and convert the functions to bool.

> returning one is wrong indeed, would you submit a patch for the conversion
> of the functions to bool?

Just a suggestion...