Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Mar 2021 16:03:43 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Jernej =?utf-8?Q?=C5=A0krabec?= <jernej.skrabec@siol.net>
Cc:     wens@csie.org, robh+dt@kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@googlegroups.com
Subject: Re: [PATCH] ARM: dts: sun8i: h3: beelink-x2: Add power button
Message-ID: <20210315150343.uzq46th6eecdr4e2@gilmour>
References: <20210306203611.15534-1-jernej.skrabec@siol.net>
 <20210308130506.v35gjviwknr5hat5@gilmour>
 <2517400.0zBCEEo8qi@kista>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="mfhruzbnsooaoye6"
Content-Disposition: inline
In-Reply-To: <2517400.0zBCEEo8qi@kista>
Precedence: bulk


--mfhruzbnsooaoye6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Mar 11, 2021 at 10:59:35PM +0100, Jernej =C5=A0krabec wrote:
> Hi!
>=20
> Dne ponedeljek, 08. marec 2021 ob 14:05:06 CET je Maxime Ripard napisal(a=
):
> > Hi
> >=20
> > On Sat, Mar 06, 2021 at 09:36:11PM +0100, Jernej Skrabec wrote:
> > > Beelink X2 has power button. Add node for it.
> > >=20
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > > ---
> > >  arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >=20
> > > diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boo=
t/dts/
> sun8i-h3-beelink-x2.dts
> > > index 62b5280ec093..4a2cb072ecf6 100644
> > > --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > @@ -111,6 +111,17 @@ spdif_out: spdif-out {
> > >  		#sound-dai-cells =3D <0>;
> > >  		compatible =3D "linux,spdif-dit";
> > >  	};
> > > +
> > > +	r_gpio_keys {
> >=20
> > Underscores are not valid for node names (and will trigger a dtc warning
> > when running with W=3D1).
>=20
> Unless I'm doing something wrong, I didn't get any warning with "make dtb=
s=20
> W=3D1". In fact many H3 boards have a node with this name and not a singl=
e=20
> warning is produced with this command for underscores (there are other=20
> warnings though).

It looks like I've been remembering it wrong, and it's actually W=3D2 that
reports it, but it's here nonetheless :)

Maxime

--mfhruzbnsooaoye6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYE93TwAKCRDj7w1vZxhR
xYexAQDb6dkfEktXz1olTmB8ij8tEMvdw1+q+P4jn663TrYYlAEAwOCcYZI9M/W4
PYGJSL4AaL7FgNeesPXOs7AB7A0KygU=
=znPS
-----END PGP SIGNATURE-----

--mfhruzbnsooaoye6--