Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3393093pxf; Mon, 15 Mar 2021 08:36:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBAAs1gDl1Ui5YbqbaS86pmlxh3nsvk+c3q9SdGDM04sQL/pp5LDt15Cc/Kqv8+P30QYr1 X-Received: by 2002:a17:907:2672:: with SMTP id ci18mr12158132ejc.384.1615822575973; Mon, 15 Mar 2021 08:36:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615822575; cv=none; d=google.com; s=arc-20160816; b=VvtB3lc+9UZgnxwIK4S9D0VbtXWgZrhpzl44yMrekyAmNZq8wgE0UzWI4TA56EzvlQ d3Qre3pzmMhzjK92NkV1rVKeqO80ytAPjry6kTcdD1rfFqEAQdcq9FqM7vrhazTD6u63 iRq2mIwHVgJC8T+BJrrEcrOtPNgmrDGe24uy3ve4+seQctAqL+0AKTuByQlbNoTSbV7C fig/WHMYWy2jArH4WUiUxQ3gn6ldeu49X1bBTHNYC/UWIazg0NZvRht6ZN8fsA26DXhf RMcP/ZPOouSTOXNRhAOiIUSsFxeCgtyM6RItZa4bRmO6kV5Unsv+Pb8wicN3XBFEaOxa FBRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=DJFHgQj3Rz5NWDR4XSLYMVinHkl1IuvWsJnnQR1mi3o=; b=Yc3QlQUXbVHClmZfU18RBi1bjDvgVxLu9PJDI79ZX2+8M3oMarNCo9CFwhZpq5wtdF Tir2VfPU0u6G5E13cNLDfbe180gY/Ib7YXF1SuSCbGnL6aNzBJvBmr57nz/VNSNnXhVa zfo8mkUJWafRqn9PbyH6RUoCzv6B+DChuR1vEXGkBxd/YgCWyvTG42cGg/R5cTisjz+A AKn3sagTg5Y54CGr+/n3sk8TjhEEt4V+KqjxJ6zrAPWvo5LIwYFbO6Hx8fikfTb792uw A1sMNZCPbwKl5xSuI0olWwcUxzRT0K35a96f9RSfJVriHkeJIobmESOxaFK12BvZD0gU /PDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="J/c5I95b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oz17si11786430ejb.205.2021.03.15.08.35.53; Mon, 15 Mar 2021 08:36:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="J/c5I95b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbhCOPe5 (ORCPT + 99 others); Mon, 15 Mar 2021 11:34:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231897AbhCOPe1 (ORCPT ); Mon, 15 Mar 2021 11:34:27 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8110C06174A for ; Mon, 15 Mar 2021 08:34:26 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id n16so57568332lfb.4 for ; Mon, 15 Mar 2021 08:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DJFHgQj3Rz5NWDR4XSLYMVinHkl1IuvWsJnnQR1mi3o=; b=J/c5I95b0Hba1H+HkbeBYx+R2Rk7dFsvCoVzEzi3+2GnM3eyQu3OpehyaAz+HW9hQe Ldn06hcbwYPP0+HMNIrrA1Dwdf5sS8vIWDJoDuw3QLvYFZLZT4LHlXcAwpdpLyt6ofD2 jOktV+J4PoWD/g19bu5zgmCRZW6oqbDRwW8sw7w12XO5kZnMnG5qCCT+mubiCdHspL4a Q8JFZJuKLz4G/SuT3FdBtjMrF3feGMs4gOYvdNHhpN+gNizyWDDz+aJP1bbmWjCLzD1g EOsDiK7OlGGWVJhfYstvNy4xkocD0V6Cc75qOQN8FeDVp6zY3k4Ki2ZO+KobFthjaJtv 8moA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DJFHgQj3Rz5NWDR4XSLYMVinHkl1IuvWsJnnQR1mi3o=; b=gK1tCG3joRpDxmTsLaEk7JzoTtwnuWBC1J3p47RetOU15IwpUWaXWWxgPWbiyoIeZV qOqte0YlZeyTlJZReKO/wBkFH7LiIC9cyb45R1gTQpeXScLzuKRSxQAC/7M7uEwIBOYy jJy8aseFgrObfoWACTnA96NWvOhvHwaFwSGU9N1MYXAZKemjvh0ZW11bCcGODiaWDcFr 5rXir2nG35nv9x9bCW69pdtL0OWhHJHRVQZk/3bzH0Uf0CgxaQs88NqZqudkEP8QiWMY qE+BmUpZbktNvrejk3wV/35G/ylM7tT1i/E6FM73BjMNEipikzxUgjz/59MlWBf+WL8p vFyg== X-Gm-Message-State: AOAM533419IPxMS+dRw9/SvgapF3T5xkCPqyqSguM2esR2IJwcTosZrf BKt89Ucbesk9Nb5DbNVoohn6cbG4GRv+r+OQA1g2LA== X-Received: by 2002:a19:548:: with SMTP id 69mr8249366lff.465.1615822465329; Mon, 15 Mar 2021 08:34:25 -0700 (PDT) MIME-Version: 1.0 References: <20210306125122.15043-1-baijiaju1990@gmail.com> In-Reply-To: <20210306125122.15043-1-baijiaju1990@gmail.com> From: Linus Walleij Date: Mon, 15 Mar 2021 16:34:14 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: ti: fix error return code of ti_iodelay_probe() To: Jia-Ju Bai Cc: Souptick Joarder , Zheng Yongjun , "Alexander A. Klimov" , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 6, 2021 at 1:51 PM Jia-Ju Bai wrote: > When ti_iodelay_pinconf_init_dev() fails, no error return code of > ti_iodelay_probe() is assigned. > To fix this bug, ret is assigned with the return value of > ti_iodelay_pinconf_init_dev(), and then ret is checked. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Patch applied! Yours, Linus Walleij