Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3396145pxf; Mon, 15 Mar 2021 08:40:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeIvxBx2VUO/gql376yiP9s7SKnR9QSx94FkD5GXohkMM+rVmf6XEbpVozgPqJa0j2+2vl X-Received: by 2002:a17:906:4e17:: with SMTP id z23mr24530265eju.439.1615822832483; Mon, 15 Mar 2021 08:40:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615822832; cv=none; d=google.com; s=arc-20160816; b=Uf8GjH8HB89F8y4WtuGNSJwFpZKELlO0Z13/FN+fnVPTFWzPcYe9r7GW0Bia8isZMF h2+3qzptlHasck2qNpK/5soMyJqaMIaOM0neYO0BNeTjKuFDigFJTBoNILw/NTb0shHL UNm/r5HjlE5nbMoPWUMvIcQKjrxNa6O4sZaix3S/hIB2GCpgaRk1ks5VC3mSganFIJkj KirKByCVkRBjy0FcgOqgemwCYmrHzMnX5a2CSpMKK2FI3gjOPRWXRt+ctt0f1FTrsAR2 1GnLXf6dYesPVFQ/pdYHQhCaAae5qwfSN995iL7x956tr2YJJsrIcpyM9yvEFn++7lpK 37Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=l5m3eRIWBciz+5D97tbfJ976ybi27aUfRGK7p8odf8I=; b=XndL4rOq58ygyfmcKBmXrvZjQln8yep2dDqsIVxvxVf1E5qAZIdEqi/PwatSFQuECf DjjxZfvyCRf81czp5kSfl01cyZf99y7YtIvZLw3uryFfcukAF97Ss1do9LqmJjdov5rX TQ5hJpDQ3NDLeSU5ifWCT3cX96zNQZyAU4ruodL1skTiBkttv1rjAQ4ii5nXZ3nzMKac yhxDmcfJgOfkuymP4iFxGaVN61miCI/25FKe46MQ1SfbCOrcYdgjDVsnKBg4Re9oKnjC iCCrwzjQnU2CuDiZzaBc7QpVIULMa7FHpb6+sBf/p++jc9wknKVnXHoyCOD8qDqYozS0 duVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="OCuhB/jt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gl1si11077015ejc.456.2021.03.15.08.40.08; Mon, 15 Mar 2021 08:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="OCuhB/jt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230125AbhCOPin (ORCPT + 99 others); Mon, 15 Mar 2021 11:38:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbhCOPiP (ORCPT ); Mon, 15 Mar 2021 11:38:15 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 882CFC061762 for ; Mon, 15 Mar 2021 08:38:14 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id u10so5318699lju.7 for ; Mon, 15 Mar 2021 08:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l5m3eRIWBciz+5D97tbfJ976ybi27aUfRGK7p8odf8I=; b=OCuhB/jteSNd4aNXQwTbisgd4RrEJ5sB+xsniqqzWWt++79boE0htITEo68BWVKFlc 4XrbVMghjPvltVaO/J8CNC11xVry4+2n0rj3V/f7y1vkN9O0sUL8BKcRJh3oYuEdivO6 B5BYjsmP4/P/67vLpOuw/Gf0m8hdTyAdaoI5kD0GYwFNSnQ9zCZSk0hmQefIWLgwGrP4 sZkqvXBkSnd2sAjIsqc9GqMZIRPkBezoLroq2gSI7WEOI4EPw2QemiQox+b38mvd6Oex lB5hpMjWceXCAtr9HBJjNRiNJlAI/9+4676DToSyKN7/vIetVC1TWtZJ/K+DNXt8Ov6q 8yvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l5m3eRIWBciz+5D97tbfJ976ybi27aUfRGK7p8odf8I=; b=ICxqvh8EkEkrwFt9ROtUsov0efWSWLFC1L5Ru7+xKBsdmYAFdYEz3IOrSx4L4iVuhJ e1cvu54yNTRYdbm9BKZY4dVcJp3JE0waKuwzj6KwQHXkQ4FhwUk+8cjUOQ9CZXtAz5lU 0Dvbz4FcGXyn/Fjlysnc9dVdksxedwAEuqzmS+vSD+slOR3XQdQpS8h82fkNXdrzk3TW zwpCVTojgbELdvI7IGCid1EVupsz8UeLTGE0H/oicwe2lluMQs8/NxFl2KOR9qdP+bwU v7x6nt+yiBIh3vge5LOSrxUj8JH9ukDY/xu6fwidwf/9sim7hkCVsjbwWrVbW4fCR/Bw SMKQ== X-Gm-Message-State: AOAM5333qKDRum4wS44v8qUgJ3IkS8y91wqCTZvYfPvuBjLIhMwS4X0y fgTfbeL+no8tlpGHA1q2rg9jIf1ZvaZmulM/QswDxw== X-Received: by 2002:a2e:7001:: with SMTP id l1mr10941550ljc.200.1615822692811; Mon, 15 Mar 2021 08:38:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Mon, 15 Mar 2021 16:38:02 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: core: Set ret to 0 when group is skipped To: Michal Simek Cc: "linux-kernel@vger.kernel.org" , Michal Simek , git , Colin King , Dan Carpenter , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 12, 2021 at 8:31 AM Michal Simek wrote: > Static analyzer tool found that the ret variable is not initialized but > code expects ret value >=0 when pinconf is skipped in the first pinmux > loop. The same expectation is for pinmux in a pinconf loop. > That's why initialize ret to 0 to avoid uninitialized ret value in first > loop or reusing ret value from first loop in second. > > Addresses-Coverity: ("Uninitialized variables") > Signed-off-by: Michal Simek > CC: Colin Ian King > CC: Dan Carpenter Patch applied! Yours, Linus Walleij