Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3444831pxf; Mon, 15 Mar 2021 09:39:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgJ6ZXNTcaBhwEG5YDQIl0fGdTke2o1d7/p9PQ3CH8QJl9Z/JHstF97+p17sUUy1ocj15F X-Received: by 2002:a17:906:fcc7:: with SMTP id qx7mr24692792ejb.486.1615826385894; Mon, 15 Mar 2021 09:39:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615826385; cv=none; d=google.com; s=arc-20160816; b=h/W6r9L/ArCwR12pFoPPlM8/hXBXfEYBAU+qWG047bkhBbRJhasQrtfYdjBNr87GLl rzl0ZYszGmMF30tsCkKwE3xNI1YxRloC5oBjxL6nsH5s6xvRN+r2PbCsAMn8xW8STod7 60/HY6ySwhlXHa37ymHPKeUci/hQ5eq81Pn1hon+UAOCpyqmuyikSZcwOEeecHJq5WwQ ktPILX/VIdMnqiPJD0zFhNLDCxcUEs+dXITWE+tP1+/dy5MO48tQCMrEB/IBC3w3Q5yh RmJhGfVNF31Nki361tqRpUDFV5MejvG9LJ15EDB9AxYIcI3DIBvh0Porj8A2iAQmY0jH 12mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hxTr+jCjNOdK/SRs3Tz7jJtcDFSQzLPh/SdXv7CFTJg=; b=wHfi6bZ+Dm5UD0sMtT5cBkPbeg2oHvYBx6x7pczoHt9DU5bF0iH6/WHdpw9N5M+UvS yanaUZZ+2kcQYb9qHBhoHCjjx+n7F1FZ76yxUQXOUAyI7pRZItMdExtEO7RjODLU5x0F l/fosm9kJQWDtejZwCLucBdIPLMzZXuzQvh4/wIj5n8//ApMXQMucH8lCprZgg5S5CiW iqQfjoamSWzsNhODq94mQ2c7Envv2EkJgkbqQSZZSCEmnt9mihd6HXHqdDgz6QHbLN/x cijLSWOxLQB0gxhCUqdMnsxotvCAq5U1QasjeLosTA4DVZB5U6MMOoHpsWhLkks2oZ52 OnVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JHodpzXG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i19si10952900ejd.152.2021.03.15.09.39.22; Mon, 15 Mar 2021 09:39:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JHodpzXG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234583AbhCOQhc (ORCPT + 99 others); Mon, 15 Mar 2021 12:37:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233454AbhCOQhM (ORCPT ); Mon, 15 Mar 2021 12:37:12 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AB1CC06174A; Mon, 15 Mar 2021 09:37:11 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id kk2-20020a17090b4a02b02900c777aa746fso15079728pjb.3; Mon, 15 Mar 2021 09:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hxTr+jCjNOdK/SRs3Tz7jJtcDFSQzLPh/SdXv7CFTJg=; b=JHodpzXGHG28Jf7mWc3g/MgAtc320RuyEet1UCcaWQyK7ZZuuQwfPATnMaaDu3UZ6g rfSKVM9y1Cr2jQHWZ3puucVOcr3BEdF/82IRcLQpmMac6pXzmSwKeVsHJKj39o4z5iaj 5RK4yk/8FJtIL8tKGtaxR87ThL2p6796IsY3aCSCYqweaI7SU5IYz30cJ7CF6Ep2zaXI 6V+GeqBOtftcGES3z677GDgAVpkObIjjPV5fd1KbBpQoEqvLCR+Cbwns5YotzYe0qGV6 yqKklX7LkN3/XQmjYwYxg63j2XS/mjqnZEiZBQGR+8+G2lPWn/74mfxMELRmmUnVuX4N +9qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hxTr+jCjNOdK/SRs3Tz7jJtcDFSQzLPh/SdXv7CFTJg=; b=WNgvFgkPGipVhjlJO1Rs7Z9fnKev7EBdLUxKmCj4pF5hKUZ3R/6k5AKEwYdtNtpsyo 0yBqCq/lJKE3RCqZDTQtbSb62N/Bfr3x3ldbUjPgwZzUSLwLinLMZnphx5OvOS1YxCOv vdMpclm7eST9bWC1WGSq+yUJAUNbnNgI76E2SUA2sTjWYe8lwZaeBHCY4X8T1RgGJpjB 0ak7vGkZ7y7sgZ+cseB99Mj3nwRpKDl2nnLAIZyH2PdJ1gHd/4Q3vQNzpK3PP4sAUrbT JFjupJ/fO6N8w5vhjBevfuuVYEf/2UzAdmU88rTw3XBHvda2MFiMUduQkHRm1BwJFuJO LjsA== X-Gm-Message-State: AOAM530tnw+VRyTikVv1YEEHHNPOsNc75h2ZaOnk8MtJfNso3YmtrIqK UyNaGjarW/10abnXL6U+bYWO0HdXArJMy2zI9h8= X-Received: by 2002:a17:90a:db49:: with SMTP id u9mr14249289pjx.181.1615826230873; Mon, 15 Mar 2021 09:37:10 -0700 (PDT) MIME-Version: 1.0 References: <20210315091400.13772-1-brgl@bgdev.pl> <20210315091400.13772-3-brgl@bgdev.pl> <6bc83972093a4be4ad163069a437ec25@AcuMS.aculab.com> In-Reply-To: <6bc83972093a4be4ad163069a437ec25@AcuMS.aculab.com> From: Andy Shevchenko Date: Mon, 15 Mar 2021 18:36:54 +0200 Message-ID: Subject: Re: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags To: David Laight Cc: Bartosz Golaszewski , Joel Becker , Christoph Hellwig , Shuah Khan , Linus Walleij , Andy Shevchenko , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Geert Uytterhoeven , Kent Gibson , Jonathan Corbet , Greg Kroah-Hartman , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 5:33 PM David Laight wrote: > From: Bartosz Golaszewski > > Sent: 15 March 2021 09:14 > > > > From: Bartosz Golaszewski > > > > For better readability and maintenance: use the (1UL << bit) for flag > > definitions. > > If the values ever get printed in hex the hex definitions are > actually more useful. Huh?! -- With Best Regards, Andy Shevchenko