Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3471420pxf; Mon, 15 Mar 2021 10:15:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwigg4KYa/4VOkMxf5lCPW4K8ncV1Scon8y1fJYZ1yfEOdjTotqFNwe07IeGp0+ECwcmjdZ X-Received: by 2002:a17:906:38da:: with SMTP id r26mr25459455ejd.251.1615828514143; Mon, 15 Mar 2021 10:15:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1615828514; cv=pass; d=google.com; s=arc-20160816; b=bCwGGw2cJdSfV/PtnTtB6ADSLaUcBvJmMX93lOLYQwrjUiYqEoIpZTYx+byER+RgtF gVkj7DiqcOcx0Tp+Cv9aTZfq7jnEodZvLrkW2T8BouQqJZyaboDyIOw/+ft6KYYbO7I1 gAv+ufORyIGQxTYp1666fo3ScHWyqg06bxnSguRwM/2d/rQBPFzKiCuPCyvvPOGJ/Yfs z9SDRl6RTNR9xscfIywJMIpoMUjadubN8w75cEYqyDVkaG/44r6QYZSnX/nMyI+Tqkko gQVeRMJ8U3iu4UBTgiw4tFQ8HjmP9Xj8wzoueAxve8L35JM6rI/fA82w+k0MMBnC4cNM Cudg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=iGu8nV2+pJONbNsrLoKJWcCLR53IYpJPhqznMUUVndo=; b=k9kwcujC/Yox8b75lYlV8wqSLMe14G3505MVupjZsKYx8y1c/+fDkUID9r5gAaA9u1 nI4XpWICtr7oz+jbfQfgGyWiLwghqqlNpwGstuczcBfwYQbeWFaQuEM3yk3TrFIWK7nO CsjTNz8Lx5m48ehBWfKYUBfy5V3wie7QjmdmIBRNfPM/nboGdrWTPUpNHgJ+WrXC+QTS TbWl7G9mtjto5yIEhU5YcgxE4uXG2Gj3/39AYmrQPOaWB0hF3v5lIuAeH4z6OByLorgA hc6bfMZ2K6mMVJWvD2ShETB3pXOvrtGYcsRBileDZHmT/Iodh2ry40O94O6h9mMh/a/E b3fg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=A3RrCRo4; arc=pass (i=1 spf=pass spfdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si11601302ejd.179.2021.03.15.10.14.50; Mon, 15 Mar 2021 10:15:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=A3RrCRo4; arc=pass (i=1 spf=pass spfdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234118AbhCORLb (ORCPT + 99 others); Mon, 15 Mar 2021 13:11:31 -0400 Received: from mail-dm6nam11on2058.outbound.protection.outlook.com ([40.107.223.58]:16096 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233912AbhCORLT (ORCPT ); Mon, 15 Mar 2021 13:11:19 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HlKTtEhOY7kbKV92dfUMNqdN38iljcCABuSz32jSzTDnz50+U0MBanQsvxXz6jL4J6ClMy14UkclO+cpa80rKf1iPonPfxBc3OyY0rd8KJwEUQ0V+KGFn6EfNqq5It5y0z1zfZSPLh/zM8PxZj8O7716jK3Sjcsedx2AKFoLM+FaTqHhR6DLesXbr75iEZltfrUnFtpYDZrSlP2/c/Z/aubhNgKepoJMx+2+ZVHEdGNDXzIz3bTUgvqmQZlq3+ul8iSmw7pLslKKVhg42pP3XOR0RvPTjp9TZmE1WMQxy5LnQawhy4OBu7MAusXpB9OgxtKbIdG1H0RNogyYHmVuKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iGu8nV2+pJONbNsrLoKJWcCLR53IYpJPhqznMUUVndo=; b=gT7K2SC9GuDu3k4Y1/kipL/AiOI4y7cUkLzxGkHdg4FMMelG40ImiqIHAuyC85N4wgeqHkcYqxmnw0kDxAxrdhnTUwSOGKncMlPy7Rtf3MZfX+hc4Sd2wZlgoP2nNy+7I0/MY/3ijQCEB8AuiuxbOJGx45f4eftvD8thnSUVKP4uR9nHZlyAZS97G7MWG4yII2YxodEYDG5/Nj4kl2Ux/gMlPrjWnAE1bNwgOGodR/nqHMMAVVJYXBD6HloZcj6uM6MqvVCAK9hHlUGRi65gY58uHPKTbuA37FMXfz7M/3wfYq8sQzVI38TWjJKwpBzwcXyJSPvPsc4de1tSygbu8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=alsa-project.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iGu8nV2+pJONbNsrLoKJWcCLR53IYpJPhqznMUUVndo=; b=A3RrCRo4eqwtEfTT8Z59MfkIO+30Ll9b8pwLrIQq18wpgDRnkTJbwbk8gAsNrLDtgN8L5k+PrwqbPTkmkW9qMCyBLmtKHNu785NfAjkHPH+/a5G37fBwkwdN0vqVrRowKlPqv4x2NBJVE3Q7am9XQ1D9BPWBad3s2GG4andNOgTuOx3s4fWBFkgcVvYFmWdXIKN4mIUmiXkqB5FTjrCaNrfvL53QBPRDxZ6dj8vZQD/SqwEay8gw1vYzKbhEhYFZUTu+YBcwW3rYiYmZB/jLsBU403wJMFcukK4AwbnrolrfoRSaljVOnFMyFAjcDm+Qn4/T2pXf+Yn/OM/mbqgRgw== Received: from MW4PR03CA0114.namprd03.prod.outlook.com (2603:10b6:303:b7::29) by DM6PR12MB3754.namprd12.prod.outlook.com (2603:10b6:5:1c4::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Mon, 15 Mar 2021 17:11:15 +0000 Received: from CO1NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b7:cafe::68) by MW4PR03CA0114.outlook.office365.com (2603:10b6:303:b7::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Mon, 15 Mar 2021 17:11:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; alsa-project.org; dkim=none (message not signed) header.d=none;alsa-project.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT055.mail.protection.outlook.com (10.13.175.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3933.31 via Frontend Transport; Mon, 15 Mar 2021 17:11:13 +0000 Received: from [10.25.96.88] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 15 Mar 2021 17:10:43 +0000 Subject: Re: Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock To: Mark Brown CC: Michael Walle , , , , , , , , , References: <20210311161558.GG4962@sirena.org.uk> <20210312113544.GB5348@sirena.org.uk> <6ed28bb5330879b1919aced5174f319f@walle.cc> <20210312120456.GD5348@sirena.org.uk> <684332700f8be9f77348a510eb6eba22@walle.cc> <20210312134642.GF5348@sirena.org.uk> <8cdf1cfa971945792b509a687a4de735@walle.cc> <6af6439c-bdb8-cd0f-635d-069040ba5b65@nvidia.com> <20210315153925.GC4595@sirena.org.uk> From: Sameer Pujar Message-ID: <3b3c5aea-60bc-d7bd-9ae6-5e890782b2e8@nvidia.com> Date: Mon, 15 Mar 2021 22:40:40 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210315153925.GC4595@sirena.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d10ef49a-00fb-4757-c617-08d8e7d55697 X-MS-TrafficTypeDiagnostic: DM6PR12MB3754: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VIynl7zJZRwHYRAcuMV+amfO9g3vnPg0O5atVYYb/3nHaUwNbglQU0ZIGjMgLm2SPEs9QMK8L+EWnp44tM6cnb3vxY0uatXkUn61EP7WoR3YWYSBaHyS0bXCfDhN54JxgEm4RWJ569LWmEwkvzlc9y3XGo3l8YDeKO5eVSOIwndnwjyLq6fKxGA5cdv2goQOmNOp7JmJBG8WiFREXzfyUxTrS1bWCbaYxphKUiKILYAxvT068xPZ88LMgbJZzMEGNN+Hj68p6xhMzRpU3iDy2n17J8TMk0D2mAH4Hg0eRbPtkaM1HsY4C3+tWvKO0si8HhCeGbVpIO77hyXKsKYiqcw+WxvJRn6JZJzbPlbwnM92/hY3bTSgOKHw96GzxAxB0+XdwzjJ4CvxunthDBzR6jo9TtnbanoWNzH4Mv3bwKdgf1tQ/RbDgbrruJ4qkgMQ0Zw2xD5HfYDFch5MKTmPBsB7u3TjqqNr/HEdduuIyvK2bsrRkxYMSHiSSc5Kof2xuvMFAzWSJMCZojgOb4zOU0dvq2XGoD8Xa23R8G0ca59b923HsOsnDWW46T/ptvxvOyrCNLjY5gtURM/LC7TZC+T+QWkNh+wFR1TQkxmopie3j0UuWzOWtoW55VwwSMcJh007BuVCO0Gv99uzsynGuCaMPo/17MmHoVJrTobcfHp7Sfyh0OvGEqaB5igbOUBPX22WOGFVhCdQzOkJmJlgTV+cGBb/3fxU/WEzd5n1JHQ= X-Forefront-Antispam-Report: CIP:216.228.112.34;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid03.nvidia.com;CAT:NONE;SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(46966006)(36840700001)(16576012)(356005)(7636003)(34020700004)(316002)(31686004)(36860700001)(82310400003)(2906002)(36906005)(5660300002)(83380400001)(8936002)(47076005)(36756003)(82740400003)(54906003)(2616005)(8676002)(6916009)(16526019)(426003)(4326008)(26005)(86362001)(70586007)(186003)(70206006)(336012)(31696002)(4744005)(478600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2021 17:11:13.8263 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d10ef49a-00fb-4757-c617-08d8e7d55697 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3754 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Yes this is a problem, unfortunately I missed checking some of the >> simple-card examples. I wonder we should be specifically looking for "mclk" >> clock here. > That would definitely help mitigate the problem but I really think it's > cleaner and safer to just push this down to set_sysclk(). Understand now. I will push patches based on this. Thanks for the details.