Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3496249pxf;
        Mon, 15 Mar 2021 10:49:04 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxlOtrbwGeOxU9Efyis8jqAkaCbZtaiUFclDNcEXg+YsCPl3MCqSxdc5zboWRBVKGYzkhZF
X-Received: by 2002:a17:907:2112:: with SMTP id qn18mr24542767ejb.220.1615830544152;
        Mon, 15 Mar 2021 10:49:04 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1615830544; cv=none;
        d=google.com; s=arc-20160816;
        b=YX0/8h9vQpmx6JXJVtXBU5RjxdTk0UFEd/N9HhJoy4baJ9YtS3pIWeHStDGzbljURs
         +kGRUAd3dBYzJeLcY5XT0coQKR536W5UbaA2tpeMbMuQ7mM3mKoT8XduJcir+Rrlsicv
         7SB0zWKCEUg9JqB3IaypB83huQUXM1SCbtBUv9JxAmuX4C4VirwF7v3IphvgX+egztR9
         roGNAlEMpUQ0ZL7fzJZ3w6Z2R0H/wk2HqeP435+8SwzIZtnxzc1zXm9CNg/fhextFhbz
         4zyNWGabhFopDvUi6/oTrsGkU5qS91kCw5Pq72Tw9Iwev6uYTBoljwiwr/O1LK7Ka7kA
         kChQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:message-id:user-agent:references:in-reply-to
         :subject:cc:to:from:date:content-transfer-encoding:mime-version
         :dkim-signature;
        bh=d5Z7hIwaOvVEkPuQ/yO5n6QsbNAjH+MEMoi2JmnTPOE=;
        b=xzYBlCr04CziwhDYFWDLJ58fSCywAiDYkGHlaAoiCMX30GCXnZxc+3xikOn9fW+NGm
         HjdP12BvGuEW9TjRJGl3vMjPAQ87zu7CUiAiwnvElrTcK7OdbcTJYQRKmgk3ZStk9Cyt
         wVp4H7kAESBPMWJC3xheBFdhwP9iqXB2UtaBsND00Lp3Z4vvJ/epZ6y8WKBS4lVNr9Vs
         MKkz6wp6Zdwn5vftqMq31qjqpGeq8qH4Op5DTxkceHqGwHFZwafWLDTVHEnBlcBmhf9n
         CMPNM0UR/8lU2w4jatQyp45WHkD7VbClv048KOr+CKpPf/zTo2Z6n/4ZsCK/1tTTiGJb
         EZRg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=RZBHsDx9;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id w14si11353818edu.225.2021.03.15.10.48.38;
        Mon, 15 Mar 2021 10:49:04 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=RZBHsDx9;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231655AbhCORjw (ORCPT <rfc822;maagaton03@gmail.com> + 99 others);
        Mon, 15 Mar 2021 13:39:52 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36510 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231469AbhCORjk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Mar 2021 13:39:40 -0400
Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8276FC06174A;
        Mon, 15 Mar 2021 10:39:40 -0700 (PDT)
Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ssl.serverraum.org (Postfix) with ESMTPSA id 4A3D022234;
        Mon, 15 Mar 2021 18:39:31 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301;
        t=1615829971;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=d5Z7hIwaOvVEkPuQ/yO5n6QsbNAjH+MEMoi2JmnTPOE=;
        b=RZBHsDx9Y5MjBUY5csUgmC1nFPa8dTjN7jJIpPRI2n93+1k5+1DEroe2KSWAB1BXD655G/
        n8KQgVkL2apu2tHioXkWQJLrEA4uplu9369VnsQP84xo2jAZTV/DMKspBXYHnQBb989XTg
        gsHabVe+AdcOT3daGqCeASHgQCLOnIQ=
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 15 Mar 2021 18:39:31 +0100
From:   Michael Walle <michael@walle.cc>
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     broonie@kernel.org, lgirdwood@gmail.com, oder_chiou@realtek.com,
        jonathanh@nvidia.com, kuninori.morimoto.gx@renesas.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
        sharadg@nvidia.com
Subject: Re: [PATCH 1/2] ASoC: simple-card-utils: Do not handle device clock
In-Reply-To: <1615829492-8972-2-git-send-email-spujar@nvidia.com>
References: <1615829492-8972-1-git-send-email-spujar@nvidia.com>
 <1615829492-8972-2-git-send-email-spujar@nvidia.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <62f003b9cf2bc1ae238689ea811b870d@walle.cc>
X-Sender: michael@walle.cc
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2021-03-15 18:31, schrieb Sameer Pujar:
> This reverts commit 1e30f642cf29 ("ASoC: simple-card-utils: Fix device
> module clock"). The original patch ended up breaking following 
> platform,
> which depends on set_sysclk() to configure internal PLL on wm8904 codec
> and expects simple-card-utils to not update the MCLK rate.
>  - 
> "arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts"
> 
> It would be best if codec takes care of setting MCLK clock via DAI
> set_sysclk() callback.
> 
> Reported-by: Michael Walle <michael@walle.cc>
> Suggested-by: Mark Brown <broonie@kernel.org>
> Suggested-by: Michael Walle <michael@walle.cc>
> Fixes: 1e30f642cf29 ("ASoC: simple-card-utils: Fix device module 
> clock")
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>

Thanks!

Tested-by: Michael Walle <michael@walle.cc>

-michael