Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3514686pxf; Mon, 15 Mar 2021 11:14:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKYgRocX1x+DM908S8uYlkgi4DZiodrK6goiX8rkD4DiFSSSyyE/CXGGV5lEvdZRfVVxR3 X-Received: by 2002:a05:6402:10c6:: with SMTP id p6mr31444683edu.241.1615832060007; Mon, 15 Mar 2021 11:14:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615832060; cv=none; d=google.com; s=arc-20160816; b=TShjtJIz1V9t9pPiL+Una3MkIewsO93IL1c+ALj/AgA7MUqu3iJYw/fwzZKkSHbyZJ WsA8VMxAfAdA8bjc8It7eC3cgUvdxIwZb7gEJEMMHW4RypQ014e2TLyxBQ6dAcah0oHl hBQkmzntbTJkbGGNK2pI7Q46mWt98t0RfNjOjeLGjxECTXFYAvWDZrnUd0Leas7xkT7b v+nVwU5h0+OHS6IskWAmp86ZIQza24cetBBUkZBXBEv36nT9kbUsebD1XdEn1LlAefXL oXG/GMUy8HlaWyIKLzbA2izzlKCIxyTR2iUDO6m5Wg2EGYBnspSWzwbm8Vmu+Fp1ZEPy onCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oMmhjHwOUBh9ABf1FqTe8m5Ia0w5QE7yw4RPKe75o1w=; b=T1OMvmvayZpNKUuTMn6lpbIAe8gYfKqjc/mwEDoxoctfW02nVnprZfJWzrevCGGjKD BT/tnGSYNerXLZi1m98YRnBCNfWFpAqtoAIWSa0ycxKYp7qA2dCeuyiC7j5BtWxwdXdv TI+JgP+QISZ4A8yxg2VeciACYtVp2TBWn/fRQ5Fp2A86Win0zPaDnRKjLnhcHmvMFH+d GTOMtf1Nw75PyGyTMAzJE8Ixy4lZYksCdkYRPF5AmkrdpejfKXl/rlK3FNf6oi8DgGH1 ubw3qjbf+h7Rrw22ko/+wF7oELvsuyY42osC6YWf8suG5PopGsUBbmk3SiB32awicTS+ rI3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="r/3PofNB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a20si12114356eda.157.2021.03.15.11.13.58; Mon, 15 Mar 2021 11:14:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="r/3PofNB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236460AbhCOONC (ORCPT + 99 others); Mon, 15 Mar 2021 10:13:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:37500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231331AbhCON65 (ORCPT ); Mon, 15 Mar 2021 09:58:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7B65764F47; Mon, 15 Mar 2021 13:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816718; bh=/8R6R06lhlNFIZDBwF3ujdYr58JUCq8f0opCZTPs2JY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r/3PofNB1tA9DLtpB+Yuw7Rw0UJT8Tu0egTvEaURnf8u0YGUBB+cayoX2T+MgqLrh kHQEb9vOM7uyj/BBN0TrUvsRRneZc2NS3vx5FjAWJ904G31h53H+CbQ/8zZfoz5r4C Bp3xnd/5wQpsThbgWFA7ZKuTpT7aT7PtBg5E5L3Q= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xie He , Martin Schiller , "David S. Miller" Subject: [PATCH 4.19 025/120] net: lapbether: Remove netif_start_queue / netif_stop_queue Date: Mon, 15 Mar 2021 14:56:16 +0100 Message-Id: <20210315135720.818663923@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135720.002213995@linuxfoundation.org> References: <20210315135720.002213995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Xie He commit f7d9d4854519fdf4d45c70a4d953438cd88e7e58 upstream. For the devices in this driver, the default qdisc is "noqueue", because their "tx_queue_len" is 0. In function "__dev_queue_xmit" in "net/core/dev.c", devices with the "noqueue" qdisc are specially handled. Packets are transmitted without being queued after a "dev->flags & IFF_UP" check. However, it's possible that even if this check succeeds, "ops->ndo_stop" may still have already been called. This is because in "__dev_close_many", "ops->ndo_stop" is called before clearing the "IFF_UP" flag. If we call "netif_stop_queue" in "ops->ndo_stop", then it's possible in "__dev_queue_xmit", it sees the "IFF_UP" flag is present, and then it checks "netif_xmit_stopped" and finds that the queue is already stopped. In this case, it will complain that: "Virtual device ... asks to queue packet!" To prevent "__dev_queue_xmit" from generating this complaint, we should not call "netif_stop_queue" in "ops->ndo_stop". We also don't need to call "netif_start_queue" in "ops->ndo_open", because after a netdev is allocated and registered, the "__QUEUE_STATE_DRV_XOFF" flag is initially not set, so there is no need to call "netif_start_queue" to clear it. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Xie He Acked-by: Martin Schiller Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/wan/lapbether.c | 3 --- 1 file changed, 3 deletions(-) --- a/drivers/net/wan/lapbether.c +++ b/drivers/net/wan/lapbether.c @@ -286,7 +286,6 @@ static int lapbeth_open(struct net_devic return -ENODEV; } - netif_start_queue(dev); return 0; } @@ -294,8 +293,6 @@ static int lapbeth_close(struct net_devi { int err; - netif_stop_queue(dev); - if ((err = lapb_unregister(dev)) != LAPB_OK) pr_err("lapb_unregister error: %d\n", err);