Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3518287pxf; Mon, 15 Mar 2021 11:19:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAlD3gKZiHNACCDXZ2GpwSs0P8+mNZ482LPLEUmCAm71MXyouID0DdI3/kIhGl44trBewQ X-Received: by 2002:a17:906:a2d3:: with SMTP id by19mr24647221ejb.98.1615832378904; Mon, 15 Mar 2021 11:19:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615832378; cv=none; d=google.com; s=arc-20160816; b=Jw0TRNYbf47AXyhYSBKz6mG8VGPYw86Yuguqe34Nz/+iNfaVLs7rPwQ35NZ85IRQib ThZOf6DJcHmRzx7uROp2/q2eCaAT8LV0szzu1gVhUoclXjxO8ab+OsYABIYDIwLsRV88 CldclO3Tf0U6nZ2Fl2EPngqZFSzSra1i2gBqipPd2e0zgSeR/8gSqDa9vhVNpTmVVM8r NuMAo+PUSyVlnzcG0202bLysg2kf/yo63RqcvPp7XMg0KTb24Qo3jTMsZOEnKt1okyXw IeVlmVur8o1/py5h0rhYjTHGUK/WY6wPPxslgDun6UHBpFiz15gvisLGqFnifXKIX8hI 2eLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A7ngkmuUMs6lL8C4AnHvFXwIHrNM2ceoGTbwl56G1mY=; b=dXmkSi6Bx4fZtXe+gfeMgh0S45UbRUfwBn85sjqojX4L89aU79yRYRw9lvhdSCIjFM uxiLl97921uC9FM6gt6UggX1sy9kJLNRfMaHwzHULjdbh7yPvFnNbUShrnlYB74l+Y1l RAGcijYrMEzJySckK0QO3cHsXYL38Ygz6lF6QryWUiAIdMCUytU7C0M0zdpUOj+RMOs9 b3DSpJ0R5oE8vBIIRSRIUTj9cjZnZ7eqkly/cJyuH8XLEdjE5IZQae1O9btQoD7sAUCK 0cPIpq35WNWp82e/ehNavDj13LEFXo7P29oWd6mdE5kKzRwtltxFfRaKjXmek6plHijm FYdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MGOESBYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si12155998ejx.751.2021.03.15.11.19.16; Mon, 15 Mar 2021 11:19:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MGOESBYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237510AbhCOOR7 (ORCPT + 99 others); Mon, 15 Mar 2021 10:17:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:35610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232582AbhCON7k (ORCPT ); Mon, 15 Mar 2021 09:59:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A03864F6E; Mon, 15 Mar 2021 13:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816763; bh=m5F9fIMXZbrWjSGrFblYs8bJF/yIr5BzsaaChNL54PI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MGOESBYOpqfm77T1DfBYf3PnGMQC8h/DM4rjrDsUL23RmZDKZuaAYJfLdGjSToSpX Tn7jN6zdmOL5pTTULD4q4nzWezyMgkG/o7arbmIBFMU01Rb7GLDpff0E6Hbke0HPzZ Ne/j09X1r7CZfxPbkeq71zFgIAMq4rl2ekOdsRIc= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Gerd Hoffmann , Maarten Lankhorst Subject: [PATCH 5.10 100/290] qxl: Fix uninitialised struct field head.surface_id Date: Mon, 15 Mar 2021 14:53:13 +0100 Message-Id: <20210315135545.297951225@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135541.921894249@linuxfoundation.org> References: <20210315135541.921894249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Colin Ian King commit 738acd49eb018feb873e0fac8f9517493f6ce2c7 upstream. The surface_id struct field in head is not being initialized and static analysis warns that this is being passed through to dev->monitors_config->heads[i] on an assignment. Clear up this warning by initializing it to zero. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: a6d3c4d79822 ("qxl: hook monitors_config updates into crtc, not encoder.") Signed-off-by: Colin Ian King Link: http://patchwork.freedesktop.org/patch/msgid/20210304094928.2280722-1-colin.king@canonical.com Signed-off-by: Gerd Hoffmann Signed-off-by: Maarten Lankhorst Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/qxl/qxl_display.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -327,6 +327,7 @@ static void qxl_crtc_update_monitors_con head.id = i; head.flags = 0; + head.surface_id = 0; oldcount = qdev->monitors_config->count; if (crtc->state->active) { struct drm_display_mode *mode = &crtc->mode;