Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3520023pxf; Mon, 15 Mar 2021 11:22:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCwtrlfkOJ8UFa59E351rC52D5RG4VKFrE/GqK8wWhb5zGJ/tpwC/IQ4KXFZ4FNFr3RM/Y X-Received: by 2002:a17:906:cb0a:: with SMTP id lk10mr20345139ejb.479.1615832540155; Mon, 15 Mar 2021 11:22:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615832540; cv=none; d=google.com; s=arc-20160816; b=PfXH985n6SygUIF4ZUdjQi4lQIRFe8Bh14s7blY5+Kb87cN3wfjC5ujz7Lbf4Me1NT sh4uM9xpHtoKM9687kXgvDj6JuVHZUU5JZurTvkt0kreEX+6AxNyh8vx7H8yq68K0QA2 P0qJ1zmsIVG5yb9XJCd0pN6B+aQYsBCHUTeVf6XpfS1Z6IqKx/wtP590EdDT4SAyMV1V 3W3NEVzdseqqbp9ouUQk3jvmsxn7FvUzU+3uydQ2cY9mGbcjAmt9taBf7YbD5V5TAd4u C8227FkxsZRNGs+/xWP2Zch9x1MXO6luFrpba5YmvuBzLDpX3B0rjFubn5tHaEWt7ln3 gbjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DOK+BeaDxHXaUNxMPRm1StxQigk+DiHv4pGK7U9YeiU=; b=olaVVCsXlDeViYIS/rQCHpBwgXoX2yZr2g6NqGkZNqmTB+ToUElUdL0DyxE0iw0NvB Ug0tgtvluMidfOuyjryxpQL/0Vhy+76stqnqHhVZvnfFrR+z0ZMpF2IBblr1eHmJOdhT Na//CfsZPIR6wj6WhaNzU79HYNa33DCwOTgIXm0su53XHfzvw62aRU7PM0CACkJVgsYH 3W6QZxWetwpU3PdTzyNl2Hp4NWwKqyo2UbDjCdzQrpU7fnykU6cfIu38FxO+KxKGy57Q BcHUp7A/ikic1OVINzk+Zus/ViQRn1HsvPpCHSc82qtNA058IdvbbZiefMF0ynK8ktNG yPuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RZaIYZ5y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s7si5762309eja.630.2021.03.15.11.21.57; Mon, 15 Mar 2021 11:22:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RZaIYZ5y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237776AbhCOOUA (ORCPT + 99 others); Mon, 15 Mar 2021 10:20:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:37500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232608AbhCON7w (ORCPT ); Mon, 15 Mar 2021 09:59:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3028964EF3; Mon, 15 Mar 2021 13:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816774; bh=2L7puG+yzZ4TW/Os7JW9fjafcAwTAHMZ6V+iNCv1x6k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RZaIYZ5y85MPxS8U0SG/sfv0pen7ES1GgPXG3M2mY7Hjxgz031di3Wm4S7tERemiM ZuioAOrUpdOiDPxAZ6838ZTsPEjpfdw8G5qjPSUFAnku+7nLIPXDq7hyjn+J74nNTP VeVjQ6mNth5tBZI50qhBx/O//j2eZpxk2odTS1m4= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ruslan Bilovol Subject: [PATCH 4.14 52/95] usb: gadget: f_uac1: stop playback on function disable Date: Mon, 15 Mar 2021 14:57:22 +0100 Message-Id: <20210315135741.981252235@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135740.245494252@linuxfoundation.org> References: <20210315135740.245494252@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: Ruslan Bilovol commit cc2ac63d4cf72104e0e7f58bb846121f0f51bb19 upstream. There is missing playback stop/cleanup in case of gadget's ->disable callback that happens on events like USB host resetting or gadget disconnection Fixes: 0591bc236015 ("usb: gadget: add f_uac1 variant based on a new u_audio api") Cc: # 4.13+ Signed-off-by: Ruslan Bilovol Link: https://lore.kernel.org/r/1614599375-8803-3-git-send-email-ruslan.bilovol@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/function/f_uac1.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/gadget/function/f_uac1.c +++ b/drivers/usb/gadget/function/f_uac1.c @@ -503,6 +503,7 @@ static void f_audio_disable(struct usb_f uac1->as_out_alt = 0; uac1->as_in_alt = 0; + u_audio_stop_playback(&uac1->g_audio); u_audio_stop_capture(&uac1->g_audio); }